* [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()
@ 2023-07-27 1:39 Yue Haibing
2023-07-27 22:21 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Yue Haibing @ 2023-07-27 1:39 UTC (permalink / raw)
To: marcel, johan.hedberg, luiz.dentz, yuehaibing
Cc: linux-bluetooth, linux-kernel, pmenzel
This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
and never be implemented.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
v2: fix SOB and update commit log
---
net/bluetooth/amp.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
index 832764dfbfb3..97c87abd129f 100644
--- a/net/bluetooth/amp.h
+++ b/net/bluetooth/amp.h
@@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
-void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()
2023-07-27 1:39 [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info() Yue Haibing
@ 2023-07-27 22:21 ` Luiz Augusto von Dentz
2023-07-28 3:29 ` YueHaibing
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2023-07-27 22:21 UTC (permalink / raw)
To: Yue Haibing; +Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, pmenzel
Hi Yue,
On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>
> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
> and never be implemented.
The commit information above shall be added with Fixes: tag so it can
be properly backported, etc.
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> v2: fix SOB and update commit log
> ---
> net/bluetooth/amp.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
> index 832764dfbfb3..97c87abd129f 100644
> --- a/net/bluetooth/amp.h
> +++ b/net/bluetooth/amp.h
> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>
> int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>
> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
> void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
> void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
> void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
> --
> 2.34.1
>
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info()
2023-07-27 22:21 ` Luiz Augusto von Dentz
@ 2023-07-28 3:29 ` YueHaibing
0 siblings, 0 replies; 3+ messages in thread
From: YueHaibing @ 2023-07-28 3:29 UTC (permalink / raw)
To: Luiz Augusto von Dentz
Cc: marcel, johan.hedberg, linux-bluetooth, linux-kernel, pmenzel
On 2023/7/28 6:21, Luiz Augusto von Dentz wrote:
> Hi Yue,
>
> On Wed, Jul 26, 2023 at 6:42 PM Yue Haibing <yuehaibing@huawei.com> wrote:
>>
>> This is introduced in commit 903e45411099 ("Bluetooth: AMP: Use HCI cmd to Read Loc AMP Assoc")
>> and never be implemented.
>
> The commit information above shall be added with Fixes: tag so it can
> be properly backported, etc.
Ok, v3 on the way.
>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>> ---
>> v2: fix SOB and update commit log
>> ---
>> net/bluetooth/amp.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/net/bluetooth/amp.h b/net/bluetooth/amp.h
>> index 832764dfbfb3..97c87abd129f 100644
>> --- a/net/bluetooth/amp.h
>> +++ b/net/bluetooth/amp.h
>> @@ -28,7 +28,6 @@ struct hci_conn *phylink_add(struct hci_dev *hdev, struct amp_mgr *mgr,
>>
>> int phylink_gen_key(struct hci_conn *hcon, u8 *data, u8 *len, u8 *type);
>>
>> -void amp_read_loc_info(struct hci_dev *hdev, struct amp_mgr *mgr);
>> void amp_read_loc_assoc_frag(struct hci_dev *hdev, u8 phy_handle);
>> void amp_read_loc_assoc(struct hci_dev *hdev, struct amp_mgr *mgr);
>> void amp_read_loc_assoc_final_data(struct hci_dev *hdev,
>> --
>> 2.34.1
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-28 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27 1:39 [PATCH v2 -next] Bluetooth: Remove unused declaration amp_read_loc_info() Yue Haibing
2023-07-27 22:21 ` Luiz Augusto von Dentz
2023-07-28 3:29 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®