* [PATCH 0/2] pinctrl: bcm: Use dev_err_probe()
@ 2023-08-07 21:30 Florian Fainelli
2023-08-07 21:30 ` [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Florian Fainelli
2023-08-07 21:30 ` [PATCH 2/2] pinctrl: nsp-gpio: " Florian Fainelli
0 siblings, 2 replies; 5+ messages in thread
From: Florian Fainelli @ 2023-08-07 21:30 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Andy Shevchenko,
open list:PIN CONTROL SUBSYSTEM,
moderated list:BROADCOM IPROC ARM ARCHITECTURE
[-- Attachment #1: Type: text/plain, Size: 425 bytes --]
These two drivers were giving "unable to add GPIO chip data" which
was slightly concerning but did not have any functional impact.
Florian Fainelli (2):
pinctrl: iproc-gpio: Silence probe deferral messages
pinctrl: nsp-gpio: Silence probe deferral messages
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages
2023-08-07 21:30 [PATCH 0/2] pinctrl: bcm: Use dev_err_probe() Florian Fainelli
@ 2023-08-07 21:30 ` Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko
2023-08-07 21:30 ` [PATCH 2/2] pinctrl: nsp-gpio: " Florian Fainelli
1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2023-08-07 21:30 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Andy Shevchenko,
open list:PIN CONTROL SUBSYSTEM,
moderated list:BROADCOM IPROC ARM ARCHITECTURE
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
produce the "unable to add GPIO chip" message which is confusing. Use
dev_err_probe() to silence probe deferral messages.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index cc3eb7409ab3..153bfd3a48a4 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -892,7 +892,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
ret = gpiochip_add_data(gc, chip);
if (ret < 0) {
- dev_err(dev, "unable to add GPIO chip\n");
+ dev_err_probe(dev, ret, "unable to add GPIO chip\n");
return ret;
}
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages
2023-08-07 21:30 ` [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Florian Fainelli
@ 2023-08-08 13:09 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-08-08 13:09 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list,
open list:PIN CONTROL SUBSYSTEM,
moderated list:BROADCOM IPROC ARM ARCHITECTURE
On Mon, Aug 07, 2023 at 02:30:21PM -0700, Florian Fainelli wrote:
> We can have gpiochip_add_data() return -EPROBE_DEFER which will make us
> produce the "unable to add GPIO chip" message which is confusing. Use
> dev_err_probe() to silence probe deferral messages.
...
> ret = gpiochip_add_data(gc, chip);
> if (ret < 0) {
> - dev_err(dev, "unable to add GPIO chip\n");
> + dev_err_probe(dev, ret, "unable to add GPIO chip\n");
> return ret;
return dev_err_probe(...);
> }
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages
2023-08-07 21:30 [PATCH 0/2] pinctrl: bcm: Use dev_err_probe() Florian Fainelli
2023-08-07 21:30 ` [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Florian Fainelli
@ 2023-08-07 21:30 ` Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2023-08-07 21:30 UTC (permalink / raw)
To: linux-kernel
Cc: Florian Fainelli, Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list, Andy Shevchenko,
open list:PIN CONTROL SUBSYSTEM,
moderated list:BROADCOM IPROC ARM ARCHITECTURE
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
We can have gpiochip_add_data() return -EPROBE_DEFER which will make
us produce the "unable to add GPIO chip" message which is confusing.
Use dev_err_probe() to silence probe deferral messages.
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index 5045a7e57f1d..e32901a92fcf 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -687,7 +687,7 @@ static int nsp_gpio_probe(struct platform_device *pdev)
ret = devm_gpiochip_add_data(dev, gc, chip);
if (ret < 0) {
- dev_err(dev, "unable to add GPIO chip\n");
+ dev_err_probe(dev, ret, "unable to add GPIO chip\n");
return ret;
}
--
2.34.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] pinctrl: nsp-gpio: Silence probe deferral messages
2023-08-07 21:30 ` [PATCH 2/2] pinctrl: nsp-gpio: " Florian Fainelli
@ 2023-08-08 13:09 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2023-08-08 13:09 UTC (permalink / raw)
To: Florian Fainelli
Cc: linux-kernel, Linus Walleij, Ray Jui, Scott Branden,
Broadcom internal kernel review list,
open list:PIN CONTROL SUBSYSTEM,
moderated list:BROADCOM IPROC ARM ARCHITECTURE
On Mon, Aug 07, 2023 at 02:30:22PM -0700, Florian Fainelli wrote:
> We can have gpiochip_add_data() return -EPROBE_DEFER which will make
> us produce the "unable to add GPIO chip" message which is confusing.
> Use dev_err_probe() to silence probe deferral messages.
The same.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-08-08 20:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-07 21:30 [PATCH 0/2] pinctrl: bcm: Use dev_err_probe() Florian Fainelli
2023-08-07 21:30 ` [PATCH 1/2] pinctrl: iproc-gpio: Silence probe deferral messages Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko
2023-08-07 21:30 ` [PATCH 2/2] pinctrl: nsp-gpio: " Florian Fainelli
2023-08-08 13:09 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®