From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Reinette Chatre" <reinette.chatre@intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>
Cc: "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Babu Moger" <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v5 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init
Date: Mon, 4 Sep 2023 12:53:36 +0300 [thread overview]
Message-ID: <20230904095339.11321-6-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230904095339.11321-1-ilpo.jarvinen@linux.intel.com>
Benchmark command is initialized before resctrl FS check and
preparation code that can call ksft_exit_skip(). There is no strong
reason why the resctrl FS support check and unmounting it (if already
mounted), has to be done after the benchmark command initialization.
Move benchmark command initialization such that it is done not until
right before the tests commence. This simplifies rollback handling when
benchmark command initialization starts to use dynamic allocation (in a
change following this).
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
---
tools/testing/selftests/resctrl/resctrl_tests.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 64e28bde5131..f105e00d6099 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -252,6 +252,14 @@ int main(int argc, char **argv)
if (geteuid() != 0)
return ksft_exit_skip("Not running as root. Skipping...\n");
+ if (!check_resctrlfs_support())
+ return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
+
+ if (umount_resctrlfs())
+ return ksft_exit_skip("resctrl FS unmount failed.\n");
+
+ filter_dmesg();
+
if (has_ben) {
if (argc - ben_ind >= BENCHMARK_ARGS)
ksft_exit_fail_msg("Too long benchmark command.\n");
@@ -277,14 +285,6 @@ int main(int argc, char **argv)
benchmark_cmd[5] = NULL;
}
- if (!check_resctrlfs_support())
- return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n");
-
- if (umount_resctrlfs())
- return ksft_exit_skip("resctrl FS unmount failed.\n");
-
- filter_dmesg();
-
ksft_set_plan(tests ? : 4);
if (mbm_test)
--
2.30.2
next prev parent reply other threads:[~2023-09-04 9:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:53 [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array Ilpo Järvinen
2023-09-05 16:41 ` Reinette Chatre
2023-09-04 9:53 ` [PATCH v5 2/8] selftests/resctrl: Correct benchmark command help Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 3/8] selftests/resctrl: Remove bw_report and bm_type from main() Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 4/8] selftests/resctrl: Simplify span lifetime Ilpo Järvinen
2023-09-04 9:53 ` Ilpo Järvinen [this message]
2023-09-04 9:53 ` [PATCH v5 6/8] selftests/resctrl: Make benchmark command const and build it with pointers Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 7/8] selftests/resctrl: Remove ben_count variable Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 8/8] selftests/resctrl: Cleanup benchmark argument parsing Ilpo Järvinen
2023-09-07 8:42 ` [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Shaopeng Tan (Fujitsu)
2023-09-26 18:09 ` Reinette Chatre
2023-09-26 21:03 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904095339.11321-6-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®