From: Reinette Chatre <reinette.chatre@intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>
Cc: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Babu Moger <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array
Date: Tue, 5 Sep 2023 09:41:23 -0700 [thread overview]
Message-ID: <359da41a-813a-1fac-bfa2-8c0044c042cf@intel.com> (raw)
In-Reply-To: <20230904095339.11321-2-ilpo.jarvinen@linux.intel.com>
Hi Ilpo,
On 9/4/2023 2:53 AM, Ilpo Järvinen wrote:
> Benchmark command is copied into an array in the stack. The array is
> BENCHMARK_ARGS items long but the command line could try to provide a
> longer command. Argument size is also fixed by BENCHMARK_ARG_SIZE (63
> bytes of space after fitting the terminating \0 character) and user
> could have inputted argument longer than that.
>
> Return error in case the benchmark command does not fit to the space
> allocated for it.
>
> Fixes: ecdbb911f22d ("selftests/resctrl: Add MBM test")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
> Reviewed-by: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2023-09-05 17:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:53 [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array Ilpo Järvinen
2023-09-05 16:41 ` Reinette Chatre [this message]
2023-09-04 9:53 ` [PATCH v5 2/8] selftests/resctrl: Correct benchmark command help Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 3/8] selftests/resctrl: Remove bw_report and bm_type from main() Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 4/8] selftests/resctrl: Simplify span lifetime Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 6/8] selftests/resctrl: Make benchmark command const and build it with pointers Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 7/8] selftests/resctrl: Remove ben_count variable Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 8/8] selftests/resctrl: Cleanup benchmark argument parsing Ilpo Järvinen
2023-09-07 8:42 ` [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Shaopeng Tan (Fujitsu)
2023-09-26 18:09 ` Reinette Chatre
2023-09-26 21:03 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=359da41a-813a-1fac-bfa2-8c0044c042cf@intel.com \
--to=reinette.chatre@intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®