From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Reinette Chatre" <reinette.chatre@intel.com>,
"Shuah Khan" <skhan@linuxfoundation.org>,
linux-kselftest@vger.kernel.org, "Shuah Khan" <shuah@kernel.org>,
"Maciej Wieczór-Retman" <maciej.wieczor-retman@intel.com>
Cc: "Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Babu Moger" <babu.moger@amd.com>,
LKML <linux-kernel@vger.kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v5 7/8] selftests/resctrl: Remove ben_count variable
Date: Mon, 4 Sep 2023 12:53:38 +0300 [thread overview]
Message-ID: <20230904095339.11321-8-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230904095339.11321-1-ilpo.jarvinen@linux.intel.com>
ben_count is only used to write the terminator for the list. It is
enough to use i from the loop so no need for another variable.
Remove ben_count variable as it is not needed.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Tested-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Reviewed-by: "Wieczor-Retman, Maciej" <maciej.wieczor-retman@intel.com>
---
tools/testing/selftests/resctrl/resctrl_tests.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 89edde416f07..48e5afb1530c 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -172,7 +172,7 @@ int main(int argc, char **argv)
bool has_ben = false, mbm_test = true, mba_test = true, cmt_test = true;
int c, cpu_no = 1, argc_new = argc, i, no_of_bits = 0;
const char *benchmark_cmd[BENCHMARK_ARGS];
- int ben_ind, ben_count, tests = 0;
+ int ben_ind, tests = 0;
char *span_str = NULL;
bool cat_test = true;
int ret;
@@ -180,7 +180,6 @@ int main(int argc, char **argv)
for (i = 0; i < argc; i++) {
if (strcmp(argv[i], "-b") == 0) {
ben_ind = i + 1;
- ben_count = argc - ben_ind;
argc_new = ben_ind - 1;
has_ben = true;
break;
@@ -265,7 +264,7 @@ int main(int argc, char **argv)
/* Extract benchmark command from command line. */
for (i = 0; i < argc - ben_ind; i++)
benchmark_cmd[i] = argv[i + ben_ind];
- benchmark_cmd[ben_count] = NULL;
+ benchmark_cmd[i] = NULL;
} else {
/* If no benchmark is given by "-b" argument, use fill_buf. */
benchmark_cmd[0] = "fill_buf";
--
2.30.2
next prev parent reply other threads:[~2023-09-04 9:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 9:53 [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 1/8] selftests/resctrl: Ensure the benchmark commands fits to its array Ilpo Järvinen
2023-09-05 16:41 ` Reinette Chatre
2023-09-04 9:53 ` [PATCH v5 2/8] selftests/resctrl: Correct benchmark command help Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 3/8] selftests/resctrl: Remove bw_report and bm_type from main() Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 4/8] selftests/resctrl: Simplify span lifetime Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 5/8] selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init Ilpo Järvinen
2023-09-04 9:53 ` [PATCH v5 6/8] selftests/resctrl: Make benchmark command const and build it with pointers Ilpo Järvinen
2023-09-04 9:53 ` Ilpo Järvinen [this message]
2023-09-04 9:53 ` [PATCH v5 8/8] selftests/resctrl: Cleanup benchmark argument parsing Ilpo Järvinen
2023-09-07 8:42 ` [PATCH v5 0/8] selftests/resctrl: Rework benchmark command handling Shaopeng Tan (Fujitsu)
2023-09-26 18:09 ` Reinette Chatre
2023-09-26 21:03 ` Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230904095339.11321-8-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=babu.moger@amd.com \
--cc=fenghua.yu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tan.shaopeng@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®