* [PATCH -next] scsi: ufs: core: Simplify bool conversion
@ 2023-09-07 0:54 Yang Li
2023-09-07 22:47 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-09-07 0:54 UTC (permalink / raw)
To: jejb, martin.petersen
Cc: alim.akhtar, avri.altman, bvanassche, linux-scsi, linux-kernel, Yang Li
./drivers/ufs/core/ufshcd.c:2307:26-31: WARNING: conversion to bool not needed here
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/ufs/core/ufshcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index c2df07545f96..04bbe38ffd87 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -2304,7 +2304,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
500, UIC_CMD_TIMEOUT * 1000, false, hba,
REG_CONTROLLER_STATUS);
- return ret == 0 ? true : false;
+ return ret == 0;
}
/**
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH -next] scsi: ufs: core: Simplify bool conversion
2023-09-07 0:54 [PATCH -next] scsi: ufs: core: Simplify bool conversion Yang Li
@ 2023-09-07 22:47 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2023-09-07 22:47 UTC (permalink / raw)
To: Yang Li, jejb, martin.petersen
Cc: alim.akhtar, avri.altman, linux-scsi, linux-kernel
On 9/6/23 17:54, Yang Li wrote:
> ./drivers/ufs/core/ufshcd.c:2307:26-31: WARNING: conversion to bool not needed here
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/ufs/core/ufshcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index c2df07545f96..04bbe38ffd87 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -2304,7 +2304,7 @@ static inline bool ufshcd_ready_for_uic_cmd(struct ufs_hba *hba)
> int ret = read_poll_timeout(ufshcd_readl, val, val & UIC_COMMAND_READY,
> 500, UIC_CMD_TIMEOUT * 1000, false, hba,
> REG_CONTROLLER_STATUS);
> - return ret == 0 ? true : false;
> + return ret == 0;
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-09-07 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-07 0:54 [PATCH -next] scsi: ufs: core: Simplify bool conversion Yang Li
2023-09-07 22:47 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®