mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arseniy Krasnov <avkrasnov@salutedevices.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
	<avkrasnov@salutedevices.com>
Subject: [PATCH net-next v2 03/12] vsock: check for MSG_ZEROCOPY support on send
Date: Sun, 1 Oct 2023 00:02:59 +0300	[thread overview]
Message-ID: <20230930210308.2394919-4-avkrasnov@salutedevices.com> (raw)
In-Reply-To: <20230930210308.2394919-1-avkrasnov@salutedevices.com>

This feature totally depends on transport, so if transport doesn't
support it, return error.

Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
---
 include/net/af_vsock.h   | 7 +++++++
 net/vmw_vsock/af_vsock.c | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/include/net/af_vsock.h b/include/net/af_vsock.h
index b01cf9ac2437..e302c0e804d0 100644
--- a/include/net/af_vsock.h
+++ b/include/net/af_vsock.h
@@ -177,6 +177,9 @@ struct vsock_transport {
 
 	/* Read a single skb */
 	int (*read_skb)(struct vsock_sock *, skb_read_actor_t);
+
+	/* Zero-copy. */
+	bool (*msgzerocopy_allow)(void);
 };
 
 /**** CORE ****/
@@ -241,4 +244,8 @@ static inline void __init vsock_bpf_build_proto(void)
 {}
 #endif
 
+static inline bool vsock_msgzerocopy_allow(const struct vsock_transport *t)
+{
+	return t->msgzerocopy_allow && t->msgzerocopy_allow();
+}
 #endif /* __AF_VSOCK_H__ */
diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index 0365382beab6..f1da06aa6b00 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -1824,6 +1824,12 @@ static int vsock_connectible_sendmsg(struct socket *sock, struct msghdr *msg,
 		goto out;
 	}
 
+	if (msg->msg_flags & MSG_ZEROCOPY &&
+	    !vsock_msgzerocopy_allow(transport)) {
+		err = -EOPNOTSUPP;
+		goto out;
+	}
+
 	/* Wait for room in the produce queue to enqueue our user's data. */
 	timeout = sock_sndtimeo(sk, msg->msg_flags & MSG_DONTWAIT);
 
-- 
2.25.1


  parent reply	other threads:[~2023-09-30 21:10 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 21:02 [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Arseniy Krasnov
2023-09-30 21:02 ` [PATCH net-next v2 01/12] vsock: set EPOLLERR on non-empty error queue Arseniy Krasnov
2023-10-03 16:22   ` Stefano Garzarella
2023-09-30 21:02 ` [PATCH net-next v2 02/12] vsock: read from socket's " Arseniy Krasnov
2023-10-03 16:23   ` Stefano Garzarella
2023-09-30 21:02 ` Arseniy Krasnov [this message]
2023-09-30 21:03 ` [PATCH net-next v2 04/12] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 05/12] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 06/12] vsock/virtio: " Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 07/12] vsock/loopback: " Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 08/12] vsock: enable setting SO_ZEROCOPY Arseniy Krasnov
2023-10-03 16:23   ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 09/12] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-10-03 16:23   ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 10/12] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-10-03 16:24   ` Stefano Garzarella
2023-10-04  5:24     ` Arseniy Krasnov
2023-10-04 15:39   ` Stefano Garzarella
2023-10-04 16:20     ` Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 11/12] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-10-04 15:45   ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 12/12] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-10-04 15:48   ` Stefano Garzarella
2023-10-03 16:26 ` [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Stefano Garzarella
2023-10-04  5:25   ` Arseniy Krasnov
2023-10-04 16:22     ` Arseniy Krasnov
2023-10-04 16:42       ` Stefano Garzarella
2023-10-04 16:40         ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230930210308.2394919-4-avkrasnov@salutedevices.com \
    --to=avkrasnov@salutedevices.com \
    --cc=bobby.eshleman@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kernel@sberdevices.ru \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oxffffaa@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®