mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arseniy Krasnov <avkrasnov@salutedevices.com>
To: Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>
Cc: <kvm@vger.kernel.org>,
	<virtualization@lists.linux-foundation.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel@sberdevices.ru>, <oxffffaa@gmail.com>,
	<avkrasnov@salutedevices.com>
Subject: [PATCH net-next v2 08/12] vsock: enable setting SO_ZEROCOPY
Date: Sun, 1 Oct 2023 00:03:04 +0300	[thread overview]
Message-ID: <20230930210308.2394919-9-avkrasnov@salutedevices.com> (raw)
In-Reply-To: <20230930210308.2394919-1-avkrasnov@salutedevices.com>

For AF_VSOCK, zerocopy tx mode depends on transport, so this option must
be set in AF_VSOCK implementation where transport is accessible (if
transport is not set during setting SO_ZEROCOPY: for example socket is
not connected, then SO_ZEROCOPY will be enabled, but once transport will
be assigned, support of this type of transmission will be checked).

To handle SO_ZEROCOPY, AF_VSOCK implementation uses SOCK_CUSTOM_SOCKOPT
bit, thus handling SOL_SOCKET option operations, but all of them except
SO_ZEROCOPY will be forwarded to the generic handler by calling
'sock_setsockopt()'.

Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
---
 Changelog:
 v1 -> v2:
  * Place 'sock_valbool_flag()' in a single line.

 net/vmw_vsock/af_vsock.c | 45 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 43 insertions(+), 2 deletions(-)

diff --git a/net/vmw_vsock/af_vsock.c b/net/vmw_vsock/af_vsock.c
index ff44bab05191..a84f242466cf 100644
--- a/net/vmw_vsock/af_vsock.c
+++ b/net/vmw_vsock/af_vsock.c
@@ -1406,8 +1406,16 @@ static int vsock_connect(struct socket *sock, struct sockaddr *addr,
 			goto out;
 		}
 
-		if (vsock_msgzerocopy_allow(transport))
+		if (vsock_msgzerocopy_allow(transport)) {
 			set_bit(SOCK_SUPPORT_ZC, &sk->sk_socket->flags);
+		} else if (sock_flag(sk, SOCK_ZEROCOPY)) {
+			/* If this option was set before 'connect()',
+			 * when transport was unknown, check that this
+			 * feature is supported here.
+			 */
+			err = -EOPNOTSUPP;
+			goto out;
+		}
 
 		err = vsock_auto_bind(vsk);
 		if (err)
@@ -1643,7 +1651,7 @@ static int vsock_connectible_setsockopt(struct socket *sock,
 	const struct vsock_transport *transport;
 	u64 val;
 
-	if (level != AF_VSOCK)
+	if (level != AF_VSOCK && level != SOL_SOCKET)
 		return -ENOPROTOOPT;
 
 #define COPY_IN(_v)                                       \
@@ -1666,6 +1674,33 @@ static int vsock_connectible_setsockopt(struct socket *sock,
 
 	transport = vsk->transport;
 
+	if (level == SOL_SOCKET) {
+		int zerocopy;
+
+		if (optname != SO_ZEROCOPY) {
+			release_sock(sk);
+			return sock_setsockopt(sock, level, optname, optval, optlen);
+		}
+
+		/* Use 'int' type here, because variable to
+		 * set this option usually has this type.
+		 */
+		COPY_IN(zerocopy);
+
+		if (zerocopy < 0 || zerocopy > 1) {
+			err = -EINVAL;
+			goto exit;
+		}
+
+		if (transport && !vsock_msgzerocopy_allow(transport)) {
+			err = -EOPNOTSUPP;
+			goto exit;
+		}
+
+		sock_valbool_flag(sk, SOCK_ZEROCOPY, zerocopy);
+		goto exit;
+	}
+
 	switch (optname) {
 	case SO_VM_SOCKETS_BUFFER_SIZE:
 		COPY_IN(val);
@@ -2322,6 +2357,12 @@ static int vsock_create(struct net *net, struct socket *sock,
 		}
 	}
 
+	/* SOCK_DGRAM doesn't have 'setsockopt' callback set in its
+	 * proto_ops, so there is no handler for custom logic.
+	 */
+	if (sock_type_connectible(sock->type))
+		set_bit(SOCK_CUSTOM_SOCKOPT, &sk->sk_socket->flags);
+
 	vsock_insert_unbound(vsk);
 
 	return 0;
-- 
2.25.1


  parent reply	other threads:[~2023-09-30 21:11 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-30 21:02 [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Arseniy Krasnov
2023-09-30 21:02 ` [PATCH net-next v2 01/12] vsock: set EPOLLERR on non-empty error queue Arseniy Krasnov
2023-10-03 16:22   ` Stefano Garzarella
2023-09-30 21:02 ` [PATCH net-next v2 02/12] vsock: read from socket's " Arseniy Krasnov
2023-10-03 16:23   ` Stefano Garzarella
2023-09-30 21:02 ` [PATCH net-next v2 03/12] vsock: check for MSG_ZEROCOPY support on send Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 04/12] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 05/12] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 06/12] vsock/virtio: " Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 07/12] vsock/loopback: " Arseniy Krasnov
2023-09-30 21:03 ` Arseniy Krasnov [this message]
2023-10-03 16:23   ` [PATCH net-next v2 08/12] vsock: enable setting SO_ZEROCOPY Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 09/12] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-10-03 16:23   ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 10/12] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-10-03 16:24   ` Stefano Garzarella
2023-10-04  5:24     ` Arseniy Krasnov
2023-10-04 15:39   ` Stefano Garzarella
2023-10-04 16:20     ` Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 11/12] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-10-04 15:45   ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 12/12] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-10-04 15:48   ` Stefano Garzarella
2023-10-03 16:26 ` [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Stefano Garzarella
2023-10-04  5:25   ` Arseniy Krasnov
2023-10-04 16:22     ` Arseniy Krasnov
2023-10-04 16:42       ` Stefano Garzarella
2023-10-04 16:40         ` Arseniy Krasnov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230930210308.2394919-9-avkrasnov@salutedevices.com \
    --to=avkrasnov@salutedevices.com \
    --cc=bobby.eshleman@bytedance.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jasowang@redhat.com \
    --cc=kernel@sberdevices.ru \
    --cc=kuba@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oxffffaa@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®