From: Arseniy Krasnov <avkrasnov@salutedevices.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Bobby Eshleman <bobby.eshleman@bytedance.com>,
<kvm@vger.kernel.org>,
<virtualization@lists.linux-foundation.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel@sberdevices.ru>, <oxffffaa@gmail.com>
Subject: Re: [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support
Date: Wed, 4 Oct 2023 19:40:03 +0300 [thread overview]
Message-ID: <3b7fa94a-3cee-8bec-ce43-b61d893e05d8@salutedevices.com> (raw)
In-Reply-To: <zilryvqespe5k4d3xjer2fcrseqo3yu3lvairvobvop6shqvsz@gzdmzpujxzkx>
On 04.10.2023 19:42, Stefano Garzarella wrote:
> On Wed, Oct 04, 2023 at 07:22:04PM +0300, Arseniy Krasnov wrote:
>>
>>
>> On 04.10.2023 08:25, Arseniy Krasnov wrote:
>>>
>>>
>>> On 03.10.2023 19:26, Stefano Garzarella wrote:
>>>> Hi Arseniy,
>>>>
>>>> On Sun, Oct 01, 2023 at 12:02:56AM +0300, Arseniy Krasnov wrote:
>>>>> Hello,
>>>>>
>>>>> this patchset contains second and third parts of another big patchset
>>>>> for MSG_ZEROCOPY flag support:
>>>>> https://lore.kernel.org/netdev/20230701063947.3422088-1-AVKrasnov@sberdevices.ru/
>>>>>
>>>>> During review of this series, Stefano Garzarella <sgarzare@redhat.com>
>>>>> suggested to split it for three parts to simplify review and merging:
>>>>>
>>>>> 1) virtio and vhost updates (for fragged skbs) (merged to net-next, see
>>>>> link below)
>>>>> 2) AF_VSOCK updates (allows to enable MSG_ZEROCOPY mode and read
>>>>> tx completions) and update for Documentation/. <-- this patchset
>>>>> 3) Updates for tests and utils. <-- this patchset
>>>>>
>>>>> Part 1) was merged:
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=71b263e79370348349553ecdf46f4a69eb436dc7
>>>>>
>>>>> Head for this patchset is:
>>>>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=236f3873b517acfaf949c23bb2d5dec13bfd2da2
>>>>>
>>>>> Link to v1:
>>>>> https://lore.kernel.org/netdev/20230922052428.4005676-1-avkrasnov@salutedevices.com/
>>>>>
>>>>> Changelog:
>>>>> v1 -> v2:
>>>>> * Patchset rebased and tested on new HEAD of net-next (see hash above).
>>>>> * See per-patch changelog after ---.
>>>>
>>>> Thanks for this new version.
>>>> I started to include vsock_uring_test in my test suite and tests are
>>>> going well.
>>>>
>>>> I reviewed code patches, I still need to review the tests.
>>>> I'll do that by the end of the week, but they looks good!
>>>
>>> Thanks for review! Ok, I'll wait for tests review, and then send next
>>> version.
>>
>> Got your comments from review. I'll update patches by:
>> 1) Trying to avoid touching util.c/util.h
>
> I mean, we can touch it ;-) but for this case it looks like we don't
> need most of that functions to be there.
>
> At least for now. If we need them to be used in more places, then it
> makes sense.
Yes, I mean touching without need :)
>
>> 2) Add new header with functions shared between util vsock_perf and
>> tests
>
> We can do this also later in another PR as cleanup if you prefer.
>
> Thanks,
> Stefano
>
prev parent reply other threads:[~2023-10-04 16:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-30 21:02 Arseniy Krasnov
2023-09-30 21:02 ` [PATCH net-next v2 01/12] vsock: set EPOLLERR on non-empty error queue Arseniy Krasnov
2023-10-03 16:22 ` Stefano Garzarella
2023-09-30 21:02 ` [PATCH net-next v2 02/12] vsock: read from socket's " Arseniy Krasnov
2023-10-03 16:23 ` Stefano Garzarella
2023-09-30 21:02 ` [PATCH net-next v2 03/12] vsock: check for MSG_ZEROCOPY support on send Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 04/12] vsock: enable SOCK_SUPPORT_ZC bit Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 05/12] vhost/vsock: support MSG_ZEROCOPY for transport Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 06/12] vsock/virtio: " Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 07/12] vsock/loopback: " Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 08/12] vsock: enable setting SO_ZEROCOPY Arseniy Krasnov
2023-10-03 16:23 ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 09/12] docs: net: description of MSG_ZEROCOPY for AF_VSOCK Arseniy Krasnov
2023-10-03 16:23 ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 10/12] test/vsock: MSG_ZEROCOPY flag tests Arseniy Krasnov
2023-10-03 16:24 ` Stefano Garzarella
2023-10-04 5:24 ` Arseniy Krasnov
2023-10-04 15:39 ` Stefano Garzarella
2023-10-04 16:20 ` Arseniy Krasnov
2023-09-30 21:03 ` [PATCH net-next v2 11/12] test/vsock: MSG_ZEROCOPY support for vsock_perf Arseniy Krasnov
2023-10-04 15:45 ` Stefano Garzarella
2023-09-30 21:03 ` [PATCH net-next v2 12/12] test/vsock: io_uring rx/tx tests Arseniy Krasnov
2023-10-04 15:48 ` Stefano Garzarella
2023-10-03 16:26 ` [PATCH net-next v2 00/12] vsock/virtio: continue MSG_ZEROCOPY support Stefano Garzarella
2023-10-04 5:25 ` Arseniy Krasnov
2023-10-04 16:22 ` Arseniy Krasnov
2023-10-04 16:42 ` Stefano Garzarella
2023-10-04 16:40 ` Arseniy Krasnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b7fa94a-3cee-8bec-ce43-b61d893e05d8@salutedevices.com \
--to=avkrasnov@salutedevices.com \
--cc=bobby.eshleman@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kernel@sberdevices.ru \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=oxffffaa@gmail.com \
--cc=pabeni@redhat.com \
--cc=sgarzare@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®