* [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion
@ 2023-10-06 14:19 Jerome Brunet
2023-10-06 14:46 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Jerome Brunet @ 2023-10-06 14:19 UTC (permalink / raw)
To: Neil Armstrong, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Jerome Brunet, Kevin Hilman, Da Xue, devicetree, linux-kernel,
linux-amlogic
While making the v2, blue and green LED pwms got inverted
This change fixes the problem
Fixes: 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
index ed826f673349..35e8f5bae990 100644
--- a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
@@ -70,7 +70,7 @@ led {
function = LED_FUNCTION_ACTIVITY;
linux,default-trigger = "heartbeat";
max-brightness = <255>;
- pwms = <&pwm_cd 1 1250 0>;
+ pwms = <&pwm_ab 1 1250 0>;
active-low;
};
};
@@ -83,7 +83,7 @@ led {
function = LED_FUNCTION_STATUS;
linux,default-trigger = "default-on";
max-brightness = <255>;
- pwms = <&pwm_ab 1 1250 0>;
+ pwms = <&pwm_cd 1 1250 0>;
active-low;
};
};
--
2.40.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion
2023-10-06 14:19 [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion Jerome Brunet
@ 2023-10-06 14:46 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2023-10-06 14:46 UTC (permalink / raw)
To: Jerome Brunet, Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Kevin Hilman, Da Xue, devicetree, linux-kernel, linux-amlogic
On 06/10/2023 16:19, Jerome Brunet wrote:
> While making the v2, blue and green LED pwms got inverted
> This change fixes the problem
>
> Fixes: 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> index ed826f673349..35e8f5bae990 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-libretech-cottonwood.dtsi
> @@ -70,7 +70,7 @@ led {
> function = LED_FUNCTION_ACTIVITY;
> linux,default-trigger = "heartbeat";
> max-brightness = <255>;
> - pwms = <&pwm_cd 1 1250 0>;
> + pwms = <&pwm_ab 1 1250 0>;
> active-low;
> };
> };
> @@ -83,7 +83,7 @@ led {
> function = LED_FUNCTION_STATUS;
> linux,default-trigger = "default-on";
> max-brightness = <255>;
> - pwms = <&pwm_ab 1 1250 0>;
> + pwms = <&pwm_cd 1 1250 0>;
> active-low;
> };
> };
Squashed into 9f841514c9c2 ("arm64: dts: amlogic: add libretech cottonwood support")
Thanks,
Neil
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-06 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-06 14:19 [PATCH] arm64: dts: amlogic: cottonwood: fix blue/green led inversion Jerome Brunet
2023-10-06 14:46 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®