mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hsiao Chien Sung <shawn.sung@mediatek.com>
To: AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Chun-Kuang Hu <chunkuang.hu@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Rob Herring <robh+dt@kernel.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>, Sean Paul <sean@poorly.run>,
	<dri-devel@lists.freedesktop.org>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	Singo Chang <singo.chang@mediatek.com>,
	Nancy Lin <nancy.lin@mediatek.com>,
	Jason-JH Lin <jason-jh.lin@mediatek.com>,
	Hsiao Chien Sung <shawn.sung@mediatek.com>
Subject: [PATCH v3 02/11] soc: mediatek: Disable 9-bit alpha in ETHDR
Date: Tue, 17 Oct 2023 14:47:08 +0800	[thread overview]
Message-ID: <20231017064717.21616-3-shawn.sung@mediatek.com> (raw)
In-Reply-To: <20231017064717.21616-1-shawn.sung@mediatek.com>

ETHDR 9-bit alpha should be disabled by default,
otherwise alpha blending will not work.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com>
---
 drivers/soc/mediatek/mtk-mmsys.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c
index a456c3e0aee7..e471be3bafc1 100644
--- a/drivers/soc/mediatek/mtk-mmsys.c
+++ b/drivers/soc/mediatek/mtk-mmsys.c
@@ -226,6 +226,7 @@ void mtk_mmsys_mixer_in_config(struct device *dev, int idx, bool alpha_sel, u16
 
 	mtk_mmsys_update_bits(mmsys, MT8195_VDO1_MIXER_IN1_ALPHA + (idx - 1) * 4, ~0,
 			      alpha << 16 | alpha, cmdq_pkt);
+	mtk_mmsys_update_bits(mmsys, MT8195_VDO1_HDR_TOP_CFG, BIT(15 + idx), 0, cmdq_pkt);
 	mtk_mmsys_update_bits(mmsys, MT8195_VDO1_HDR_TOP_CFG, BIT(19 + idx),
 			      alpha_sel << (19 + idx), cmdq_pkt);
 	mtk_mmsys_update_bits(mmsys, MT8195_VDO1_MIXER_IN1_PAD + (idx - 1) * 4,
-- 
2.18.0


  parent reply	other threads:[~2023-10-17  6:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-17  6:47 [PATCH v3 00/11] Support IGT in display driver Hsiao Chien Sung
2023-10-17  6:47 ` [PATCH v3 01/11] soc: mediatek: Add register definitions for GCE Hsiao Chien Sung
2023-10-17  6:47 ` Hsiao Chien Sung [this message]
2023-10-17  6:47 ` [PATCH v3 03/11] dt-bindings: display: mediatek: ovl: Modify rules for MT8195/MT8188 Hsiao Chien Sung
2023-10-17 20:19   ` Rob Herring
2023-10-17  6:47 ` [PATCH v3 04/11] drm/mediatek: Add OVL compatible name for MT8195 Hsiao Chien Sung
2023-10-17  6:47 ` [PATCH v3 05/11] drm/mediatek: Set DRM mode configs accordingly Hsiao Chien Sung
2023-11-22  5:50   ` CK Hu (胡俊光)
2023-10-17  6:47 ` [PATCH v3 06/11] drm/mediatek: Support alpha blending in display driver Hsiao Chien Sung
2023-10-17  6:47 ` [PATCH v3 07/11] drm/mediatek: Support alpha blending in VDOSYS0 Hsiao Chien Sung
2023-11-23  9:22   ` CK Hu (胡俊光)
2023-11-29  9:45     ` Shawn Sung (宋孝謙)
2023-10-17  6:47 ` [PATCH v3 08/11] drm/mediatek: Support alpha blending in VDOSYS1 Hsiao Chien Sung
2023-11-24  6:04   ` CK Hu (胡俊光)
2023-10-17  6:47 ` [PATCH v3 09/11] drm/mediatek: Support CRC in display driver Hsiao Chien Sung
2023-10-17  6:47 ` [PATCH v3 10/11] drm/mediatek: Support CRC in VDOSYS0 Hsiao Chien Sung
2023-11-30  1:19   ` CK Hu (胡俊光)
2023-10-17  6:47 ` [PATCH v3 11/11] drm/mediatek: Support CRC in VDOSYS1 Hsiao Chien Sung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231017064717.21616-3-shawn.sung@mediatek.com \
    --to=shawn.sung@mediatek.com \
    --cc=airlied@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=chunkuang.hu@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jason-jh.lin@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=nancy.lin@mediatek.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    --cc=singo.chang@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®