[PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Brenton Simpson]

The Legion Go has a 2560x1600 portrait screen, with the native "up" facing the right controller (90° CW from the rest of the device).

Signed-off-by: Brenton Simpson <appsforartists@google.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index d5c1529..3d92f66 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
 		},
 		.driver_data = (void *)&lcd1200x1920_rightside_up,
+	}, {	/* Lenovo Legion Go 8APU1 */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
+		},
+		.driver_data = (void *)&lcd1600x2560_leftside_up,
 	}, {	/* Lenovo Yoga Book X90F / X90L */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
-- 
2.43.0.rc0.421.g78406f8d94-goog

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Hans de Goede]

Hi Brenton,

On 11/15/23 00:38, Brenton Simpson wrote:
> The Legion Go has a 2560x1600 portrait screen, with the native "up" facing the right controller (90° CW from the rest of the device).
> 
> Signed-off-by: Brenton Simpson <appsforartists@google.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

But I cannot merge it because your "From:" which is <brentons+appsforartists@google.com> and the email address which you have used for your Signed-off-by: <appsforartists@google.com> do not match.

And I have no idea which one of those 2 addresses actually works / is yours. I suspect the From: is the right one though ?

Also you have forgotten to Cc: dri-devel@lists.freedesktop.org so this patch is not available in the drm patchwork instance.

Can you please send a v2 fixing both issues ?

Regards,

Hans




> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d5c1529..3d92f66 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
>  		},
>  		.driver_data = (void *)&lcd1200x1920_rightside_up,
> +	}, {	/* Lenovo Legion Go 8APU1 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
> +		},
> +		.driver_data = (void *)&lcd1600x2560_leftside_up,
>  	}, {	/* Lenovo Yoga Book X90F / X90L */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Brenton Simpson]

Resending from the email address linked to my GitHub account.

-- >8 --

The Legion Go has a 2560x1600 portrait screen, with the native "up" facing =
the right controller (90=C2=B0 CW from the rest of the device).

Signed-off-by: Brenton Simpson <appsforartists@google.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/d=
rm/drm_panel_orientation_quirks.c
index d5c1529..3d92f66 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] =
=3D {
 =09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
 =09=09},
 =09=09.driver_data =3D (void *)&lcd1200x1920_rightside_up,
+=09}, {=09/* Lenovo Legion Go 8APU1 */
+=09=09.matches =3D {
+=09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+=09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
+=09=09},
+=09=09.driver_data =3D (void *)&lcd1600x2560_leftside_up,
 =09}, {=09/* Lenovo Yoga Book X90F / X90L */
 =09=09.matches =3D {
 =09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
--=20
2.43.0.rc0.421.g78406f8d94-goog

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Brenton Simpson]

Arg - the special characters got mangled.  One last time.

-- >8 --

The Legion Go has a 2560x1600 portrait screen, with the native "up"
facing the right controller (90° CW from the rest of the device).

Signed-off-by: Brenton Simpson <appsforartists@google.com>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index d5c1529..3d92f66 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] = {
                  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
                },
                .driver_data = (void *)&lcd1200x1920_rightside_up,
+       }, {    /* Lenovo Legion Go 8APU1 */
+               .matches = {
+                 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+                 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
+               },
+               .driver_data = (void *)&lcd1600x2560_leftside_up,
        }, {    /* Lenovo Yoga Book X90F / X90L */
                .matches = {
                  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
--
2.43.0.rc0.421.g78406f8d94-goog

On Wed, Nov 15, 2023 at 7:48 AM Brenton Simpson
<appsforartists@google.com> wrote:
>
> Resending from the email address linked to my GitHub account.
>
> -- >8 --
>
> The Legion Go has a 2560x1600 portrait screen, with the native "up" facing =
> the right controller (90=C2=B0 CW from the rest of the device).
>
> Signed-off-by: Brenton Simpson <appsforartists@google.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/d=
> rm/drm_panel_orientation_quirks.c
> index d5c1529..3d92f66 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] =
> =3D {
>  =09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
>  =09=09},
>  =09=09.driver_data =3D (void *)&lcd1200x1920_rightside_up,
> +=09}, {=09/* Lenovo Legion Go 8APU1 */
> +=09=09.matches =3D {
> +=09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +=09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
> +=09=09},
> +=09=09.driver_data =3D (void *)&lcd1600x2560_leftside_up,
>  =09}, {=09/* Lenovo Yoga Book X90F / X90L */
>  =09=09.matches =3D {
>  =09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> --=20
> 2.43.0.rc0.421.g78406f8d94-goog

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Hans de Goede]

Hi,

On 11/15/23 16:48, Brenton Simpson wrote:
> Resending from the email address linked to my GitHub account.

Ok, this doesn't really help. I'll just fix-up the author
field of the original patch.

Do understand correctly that both the author and the Signed-off-by
should be set to:

Brenton Simpson <appsforartists@google.com>

?

Regards,

Hans



> 
> -- >8 --
> 
> The Legion Go has a 2560x1600 portrait screen, with the native "up" facing =
> the right controller (90=C2=B0 CW from the rest of the device).
> 
> Signed-off-by: Brenton Simpson <appsforartists@google.com>
> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/d=
> rm/drm_panel_orientation_quirks.c
> index d5c1529..3d92f66 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] =
> =3D {
>  =09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
>  =09=09},
>  =09=09.driver_data =3D (void *)&lcd1200x1920_rightside_up,
> +=09}, {=09/* Lenovo Legion Go 8APU1 */
> +=09=09.matches =3D {
> +=09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +=09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
> +=09=09},
> +=09=09.driver_data =3D (void *)&lcd1600x2560_leftside_up,
>  =09}, {=09/* Lenovo Yoga Book X90F / X90L */
>  =09=09.matches =3D {
>  =09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> --=20
> 2.43.0.rc0.421.g78406f8d94-goog
> 

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Brenton Simpson]

Yes, thanks!

That's the email attached to my public git work, so it should be the
one here as well.

Sorry for the hassle.  Very new to sending PRs over email, and still
working through the kinks.

On Wed, Nov 15, 2023 at 7:51 AM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 11/15/23 16:48, Brenton Simpson wrote:
> > Resending from the email address linked to my GitHub account.
>
> Ok, this doesn't really help. I'll just fix-up the author
> field of the original patch.
>
> Do understand correctly that both the author and the Signed-off-by
> should be set to:
>
> Brenton Simpson <appsforartists@google.com>
>
> ?
>
> Regards,
>
> Hans
>
>
>
> >
> > -- >8 --
> >
> > The Legion Go has a 2560x1600 portrait screen, with the native "up" facing =
> > the right controller (90=C2=B0 CW from the rest of the device).
> >
> > Signed-off-by: Brenton Simpson <appsforartists@google.com>
> > ---
> >  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/d=
> > rm/drm_panel_orientation_quirks.c
> > index d5c1529..3d92f66 100644
> > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> > @@ -336,6 +336,12 @@ static const struct dmi_system_id orientation_data[] =
> > =3D {
> >  =09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "IdeaPad Duet 3 10IGL5"),
> >  =09=09},
> >  =09=09.driver_data =3D (void *)&lcd1200x1920_rightside_up,
> > +=09}, {=09/* Lenovo Legion Go 8APU1 */
> > +=09=09.matches =3D {
> > +=09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +=09=09  DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Legion Go 8APU1"),
> > +=09=09},
> > +=09=09.driver_data =3D (void *)&lcd1600x2560_leftside_up,
> >  =09}, {=09/* Lenovo Yoga Book X90F / X90L */
> >  =09=09.matches =3D {
> >  =09=09  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
> > --=20
> > 2.43.0.rc0.421.g78406f8d94-goog
> >
>

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Hans de Goede]

Hi Brenton,

On 11/15/23 16:52, Brenton Simpson wrote:
> Yes, thanks!
> 
> That's the email attached to my public git work, so it should be the
> one here as well.

Ok, I've pushed this to drm-misc-fixes now, thank you for the patch.

> Sorry for the hassle.  Very new to sending PRs over email, and still
> working through the kinks.

Your initial submission was almost there. Just the weird thing
with the + in the From: email-address. What also threw me off
is that the From was: <brentons+appsforartists@google.com>

Normally the '+' + the part after it gets thrown away to get
the canonical email address, so that would make your canonical
email: <brentons@google.com> where I now know it should be:
<appsforartists@google.com> .

So next time you use a + address please do something like:

<appsforartists+brentons@google.com>

I also guess you never got any of the replies addressed to
<brentons+appsforartists@google.com> since the mail server
presumably has tried to deliver those to <brentons@google.com>,
but because your normal email was in the Cc things still
worked out.

Either way for future patches note that using "git send-email"
is the advised way to submit kernel patches.

Regards,

Hans

Re: [PATCH] drm/panel-orientation-quirks: add Lenovo Legion Go

[Brenton Simpson]

Oh believe me, I tried.  I spent like 2 hours fighting with the CLI to
send it.  There are restrictions on what addresses it can send from
that don't line up with the identity I use for git.  Our corp setup
can be…complicated.

My workflow for patching the kernel is actually a bit weird: I use the
GitHub web editor to make the patches, and then test them with Nix's
build system, which pulls them by URL.  Since it's a gaming console,
it's easier to use a real computer to write the patches, and then test
them by instigating a build over SSH.

Now that I know the format the email is supposed to take, it might be
easier for me to paste GitHub's .patch body into a plain text email
and add the Signed Off tag by hand.

I just CCed you on a patch created that way.  Does that look okay to
you (at least from a formatting point-of-view).

Thanks again for your patience and assistance.  Sorry for my weird setup.


  .matches = {
   DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),