* [PATCH] checkpatch: do not require an empty line before error injection
@ 2023-11-09 7:51 Sergey Senozhatsky
2023-11-17 1:40 ` Sergey Senozhatsky
2023-11-17 1:46 ` Joe Perches
0 siblings, 2 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-11-09 7:51 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches
Cc: Dwaipayan Ray, Lukas Bulwahn, linux-kernel, Sergey Senozhatsky
ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
follow a function it annotates.
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 25fdb7fda112..a94ed6c46a6d 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4054,7 +4054,7 @@ sub process {
if ($prevline =~ /^[\+ ]};?\s*$/ &&
$line =~ /^\+/ &&
!($line =~ /^\+\s*$/ ||
- $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
+ $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
$line =~ /^\+\s*MODULE_/i ||
$line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
$line =~ /^\+[a-z_]*init/ ||
--
2.42.0.869.gea05f2083d-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] checkpatch: do not require an empty line before error injection
2023-11-09 7:51 [PATCH] checkpatch: do not require an empty line before error injection Sergey Senozhatsky
@ 2023-11-17 1:40 ` Sergey Senozhatsky
2023-11-17 1:46 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Sergey Senozhatsky @ 2023-11-17 1:40 UTC (permalink / raw)
To: Andy Whitcroft, Joe Perches
Cc: Dwaipayan Ray, Lukas Bulwahn, linux-kernel, Sergey Senozhatsky
On (23/11/09 16:51), Sergey Senozhatsky wrote:
>
> ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
> follow a function it annotates.
Gentle ping.
[..]
> @@ -4054,7 +4054,7 @@ sub process {
> if ($prevline =~ /^[\+ ]};?\s*$/ &&
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> - $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> + $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
> --
> 2.42.0.869.gea05f2083d-goog
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] checkpatch: do not require an empty line before error injection
2023-11-09 7:51 [PATCH] checkpatch: do not require an empty line before error injection Sergey Senozhatsky
2023-11-17 1:40 ` Sergey Senozhatsky
@ 2023-11-17 1:46 ` Joe Perches
1 sibling, 0 replies; 3+ messages in thread
From: Joe Perches @ 2023-11-17 1:46 UTC (permalink / raw)
To: Sergey Senozhatsky, Andy Whitcroft, Andrew Morton
Cc: Dwaipayan Ray, Lukas Bulwahn, linux-kernel
On Thu, 2023-11-09 at 16:51 +0900, Sergey Senozhatsky wrote:
> ALLOW_ERROR_INJECTION macro (just like EXPORT_SYMBOL) can immediately
> follow a function it annotates.
>
> Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Acked-by: Joe Perches <joe@perches.com>
> ---
> scripts/checkpatch.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 25fdb7fda112..a94ed6c46a6d 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4054,7 +4054,7 @@ sub process {
> if ($prevline =~ /^[\+ ]};?\s*$/ &&
> $line =~ /^\+/ &&
> !($line =~ /^\+\s*$/ ||
> - $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param)/ ||
> + $line =~ /^\+\s*(?:EXPORT_SYMBOL|early_param|ALLOW_ERROR_INJECTION)/ ||
> $line =~ /^\+\s*MODULE_/i ||
> $line =~ /^\+\s*\#\s*(?:end|elif|else)/ ||
> $line =~ /^\+[a-z_]*init/ ||
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-17 1:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-09 7:51 [PATCH] checkpatch: do not require an empty line before error injection Sergey Senozhatsky
2023-11-17 1:40 ` Sergey Senozhatsky
2023-11-17 1:46 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®