From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "John W. Linville" <linville@tuxdriver.com>,
Kalle Valo <kvalo@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-wireless@vger.kernel.org, Ping-Ke Shih <pkshih@realtek.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v2 00/10] wifi: rtlwifi: PCI related fixes & cleanups
Date: Fri, 24 Nov 2023 10:47:15 +0200 [thread overview]
Message-ID: <20231124084725.12738-1-ilpo.jarvinen@linux.intel.com> (raw)
The rtlwifi driver has code fragments that are using old interface or
custom code to access PCIe capabilities which is buggy and messy.
First two patches are fixes to problems related to ASPM and LNKCTL
register RMW operations. The rest of the patches cleanup PCIe
capability related code.
Additional note: This series provides only a stop-gap solution to the
RMW concurrency issue, the overall plan is to migrate all ASPM related
handling into the ASPM service driver in order for it to accurately
track ASPM state [1].
[1] https://lore.kernel.org/linux-pci/20230918131103.24119-1-ilpo.jarvinen@linux.intel.com/
v2:
- Remove upstream bridge ASPM code which has never functioned
- Convert more bits to pci_regs.h
- Ensure _rtl_pci_switch_clk_req() only changes CLKREQ_EN
- wifi: prefix to all patches
- Add 2 more cleanup patches for unused stuff
Ilpo Järvinen (10):
wifi: rtlwifi: Remove bogus and dangerous ASPM disable/enable code
wifi: rtlwifi: Convert LNKCTL change to PCIe cap RMW accessors
wifi: rtlwifi: Convert to use PCIe capability accessors
wifi: rtlwifi: rtl8821ae: Remove unnecessary PME_Status bit set
wifi: rtlwifi: rtl8821ae: Reverse PM Capability exists check
wifi: rtlwifi: rtl8821ae: Use pci_find_capability()
wifi: rtlwifi: rtl8821ae: Add pdev into
_rtl8821ae_clear_pci_pme_status()
wifi: rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h
wifi: rtlwifi: Remove unused PCI related defines and struct
wifi: rtlwifi: Remove bridge vendor/device ids
drivers/net/wireless/realtek/rtlwifi/pci.c | 98 +++++--------------
drivers/net/wireless/realtek/rtlwifi/pci.h | 24 -----
.../wireless/realtek/rtlwifi/rtl8821ae/hw.c | 76 ++++----------
3 files changed, 43 insertions(+), 155 deletions(-)
--
2.30.2
next reply other threads:[~2023-11-24 8:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 8:47 Ilpo Järvinen [this message]
2023-11-24 8:47 ` [PATCH v2 01/10] wifi: rtlwifi: Remove bogus and dangerous ASPM disable/enable code Ilpo Järvinen
2023-12-01 12:41 ` Kalle Valo
2023-11-24 8:47 ` [PATCH v2 02/10] wifi: rtlwifi: Convert LNKCTL change to PCIe cap RMW accessors Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 03/10] wifi: rtlwifi: Convert to use PCIe capability accessors Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 04/10] wifi: rtlwifi: rtl8821ae: Remove unnecessary PME_Status bit set Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 05/10] wifi: rtlwifi: rtl8821ae: Reverse PM Capability exists check Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 06/10] wifi: rtlwifi: rtl8821ae: Use pci_find_capability() Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 07/10] wifi: rtlwifi: rtl8821ae: Add pdev into _rtl8821ae_clear_pci_pme_status() Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 08/10] wifi: rtlwifi: rtl8821ae: Access full PMCS reg and use pci_regs.h Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 09/10] wifi: rtlwifi: Remove unused PCI related defines and struct Ilpo Järvinen
2023-11-24 8:47 ` [PATCH v2 10/10] wifi: rtlwifi: Remove bridge vendor/device ids Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231124084725.12738-1-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Larry.Finger@lwfinger.net \
--cc=bhelgaas@google.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®