From: Tejun Heo <tj@kernel.org>
To: jiangshanlai@gmail.com
Cc: linux-kernel@vger.kernel.org, Naohiro.Aota@wdc.com,
kernel-team@meta.com, Tejun Heo <tj@kernel.org>
Subject: [PATCH 6/9] workqueue: Add first_possible_node and node_nr_cpus[]
Date: Fri, 12 Jan 2024 14:28:50 -1000 [thread overview]
Message-ID: <20240113002911.406791-7-tj@kernel.org> (raw)
In-Reply-To: <20240113002911.406791-1-tj@kernel.org>
To track the first possible NUMA node and the number of online CPUs in each
NUMA node, respectively. These will be used to implement system-wide
nr_active for unbound workqueues.
Signed-off-by: Tejun Heo <tj@kernel.org>
---
kernel/workqueue.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index f90f797e73a1..3f45baa96d51 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -53,6 +53,7 @@
#include <linux/nmi.h>
#include <linux/kvm_para.h>
#include <linux/delay.h>
+#include <linux/topology.h>
#include "workqueue_internal.h"
@@ -341,6 +342,8 @@ struct wq_pod_type {
int *cpu_pod; /* cpu -> pod */
};
+static int first_possible_node __read_mostly;
+static int node_nr_cpus[MAX_NUMNODES] __read_mostly;
static struct wq_pod_type wq_pod_types[WQ_AFFN_NR_TYPES];
static enum wq_affn_scope wq_affn_dfl = WQ_AFFN_CACHE;
@@ -5617,6 +5620,8 @@ int workqueue_online_cpu(unsigned int cpu)
struct workqueue_struct *wq;
int pi;
+ node_nr_cpus[cpu_to_node(cpu)]++;
+
mutex_lock(&wq_pool_mutex);
for_each_pool(pool, pi) {
@@ -5672,6 +5677,8 @@ int workqueue_offline_cpu(unsigned int cpu)
}
mutex_unlock(&wq_pool_mutex);
+ node_nr_cpus[cpu_to_node(cpu)]--;
+
return 0;
}
@@ -6687,6 +6694,9 @@ void __init workqueue_init_early(void)
BUILD_BUG_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));
+ first_possible_node = first_node(node_states[N_POSSIBLE]);
+ node_nr_cpus[cpu_to_node(0)]++;
+
BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL));
BUG_ON(!alloc_cpumask_var(&wq_requested_unbound_cpumask, GFP_KERNEL));
BUG_ON(!zalloc_cpumask_var(&wq_isolated_cpumask, GFP_KERNEL));
--
2.43.0
next prev parent reply other threads:[~2024-01-13 0:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 0:28 [PATCHSET v2 wq/for-6.8] workqueue: Implement system-wide max_active for unbound workqueues Tejun Heo
2024-01-13 0:28 ` [PATCH 1/9] workqueue: Move pwq->max_active to wq->max_active Tejun Heo
2024-01-13 0:28 ` [PATCH 2/9] workqueue: Factor out pwq_is_empty() Tejun Heo
2024-01-13 0:28 ` [PATCH 3/9] workqueue: Replace pwq_activate_inactive_work() with [__]pwq_activate_work() Tejun Heo
2024-01-13 0:28 ` [PATCH 4/9] workqueue: Move nr_active handling into helpers Tejun Heo
2024-01-13 0:28 ` [PATCH 5/9] workqueue: Make wq_adjust_max_active() round-robin pwqs while activating Tejun Heo
2024-01-13 0:28 ` Tejun Heo [this message]
2024-01-13 0:28 ` [PATCH 7/9] workqueue: Move pwq_dec_nr_in_flight() to the end of work item handling Tejun Heo
2024-01-13 0:28 ` [PATCH 8/9] workqueue: Introduce struct wq_node_nr_active Tejun Heo
2024-01-19 7:55 ` Lai Jiangshan
2024-01-24 0:13 ` Tejun Heo
2024-01-13 0:28 ` [PATCH 9/9] workqueue: Implement system-wide nr_active enforcement for unbound workqueues Tejun Heo
2024-01-19 7:54 ` Lai Jiangshan
2024-01-24 0:30 ` Tejun Heo
2024-01-24 2:54 ` Lai Jiangshan
2024-01-25 16:18 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240113002911.406791-7-tj@kernel.org \
--to=tj@kernel.org \
--cc=Naohiro.Aota@wdc.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®