From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongli Zhang <dongli.zhang@oracle.com>
Subject: [PATCH v2 2/3] KVM: VMX: return early if msr_bitmap is not supported
Date: Fri, 23 Feb 2024 12:21:03 -0800 [thread overview]
Message-ID: <20240223202104.3330974-3-seanjc@google.com> (raw)
In-Reply-To: <20240223202104.3330974-1-seanjc@google.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
The vmx_msr_filter_changed() may directly/indirectly calls only
vmx_enable_intercept_for_msr() or vmx_disable_intercept_for_msr(). Those
two functions may exit immediately if !cpu_has_vmx_msr_bitmap().
vmx_msr_filter_changed()
-> vmx_disable_intercept_for_msr()
-> pt_update_intercept_for_msr()
-> vmx_set_intercept_for_msr()
-> vmx_enable_intercept_for_msr()
-> vmx_disable_intercept_for_msr()
Therefore, we exit early if !cpu_has_vmx_msr_bitmap().
Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/vmx/vmx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
index 7470a7fb1014..014cf47dc66b 100644
--- a/arch/x86/kvm/vmx/vmx.c
+++ b/arch/x86/kvm/vmx/vmx.c
@@ -4127,6 +4127,9 @@ static void vmx_msr_filter_changed(struct kvm_vcpu *vcpu)
struct vcpu_vmx *vmx = to_vmx(vcpu);
u32 i;
+ if (!cpu_has_vmx_msr_bitmap())
+ return;
+
/*
* Redo intercept permissions for MSRs that KVM is passing through to
* the guest. Disabling interception will check the new MSR filter and
--
2.44.0.rc0.258.g7320e95886-goog
next prev parent reply other threads:[~2024-02-23 20:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 20:21 [PATCH v2 0/3] KVM: VMX: MSR intercept/passthrough cleanup and simplification Sean Christopherson
2024-02-23 20:21 ` [PATCH v2 1/3] KVM: VMX: fix comment to add LBR to passthrough MSRs Sean Christopherson
2024-02-23 20:21 ` Sean Christopherson [this message]
2024-02-23 20:21 ` [PATCH v2 3/3] KVM: VMX: Combine "check" and "get" APIs for passthrough MSR lookups Sean Christopherson
2024-02-24 3:14 ` Dongli Zhang
2024-02-24 3:18 ` Dongli Zhang
2024-02-27 21:28 ` [PATCH v2 0/3] KVM: VMX: MSR intercept/passthrough cleanup and simplification Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240223202104.3330974-3-seanjc@google.com \
--to=seanjc@google.com \
--cc=dongli.zhang@oracle.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®