From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Markus Reichl <m.reichl@fivetechno.de>,
Mark Brown <broonie@kernel.org>
Subject: [PATCH 1/8] regulator: mp8859: Specify register accessibility and enable caching
Date: Sun, 25 Feb 2024 14:59:27 +0000 [thread overview]
Message-ID: <20240225-regulator-mp8859-v1-1-68ee2c839ded@kernel.org> (raw)
In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org>
Avoid needless accesses to the hardware by caching register values that
we know, marking status registers as volatile as appropriate.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/mp8859.c | 38 +++++++++++++++++++++++++++++++++++++-
1 file changed, 37 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c
index b820bd6043e5..689b56680d93 100644
--- a/drivers/regulator/mp8859.c
+++ b/drivers/regulator/mp8859.c
@@ -77,11 +77,47 @@ static const struct linear_range mp8859_dcdc_ranges[] = {
REGULATOR_LINEAR_RANGE(0, VOL_MIN_IDX, VOL_MAX_IDX, 10000),
};
+static bool mp8859_readable(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case MP8859_VOUT_L_REG:
+ case MP8859_VOUT_H_REG:
+ case MP8859_VOUT_GO_REG:
+ case MP8859_IOUT_LIM_REG:
+ case MP8859_CTL1_REG:
+ case MP8859_CTL2_REG:
+ case MP8859_STATUS_REG:
+ case MP8859_INTERRUPT_REG:
+ case MP8859_MASK_REG:
+ case MP8859_ID1_REG:
+ case MP8859_MFR_ID_REG:
+ case MP8859_DEV_ID_REG:
+ case MP8859_IC_REV_REG:
+ return true;
+ default:
+ return false;
+ }
+}
+
+static bool mp8859_volatile(struct device *dev, unsigned int reg)
+{
+ switch (reg) {
+ case MP8859_VOUT_GO_REG:
+ case MP8859_STATUS_REG:
+ case MP8859_INTERRUPT_REG:
+ return true;
+ default:
+ return false;
+ }
+}
+
static const struct regmap_config mp8859_regmap = {
.reg_bits = 8,
.val_bits = 8,
.max_register = MP8859_MAX_REG,
- .cache_type = REGCACHE_RBTREE,
+ .cache_type = REGCACHE_MAPLE,
+ .readable_reg = mp8859_readable,
+ .volatile_reg = mp8859_volatile,
};
static const struct regulator_ops mp8859_ops = {
--
2.39.2
next prev parent reply other threads:[~2024-02-25 15:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 14:59 [PATCH 0/8] regulator: mp8859: Cleanups and enhancements Mark Brown
2024-02-25 14:59 ` Mark Brown [this message]
2024-02-25 14:59 ` [PATCH 2/8] regulator: mp8859: Validate and log device identifier information Mark Brown
2024-02-25 14:59 ` [PATCH 3/8] regulator: mp8859: Support enable control Mark Brown
2024-02-25 14:59 ` [PATCH 4/8] regulator: mp8859: Support mode operations Mark Brown
2024-02-25 14:59 ` [PATCH 5/8] regulator: mp8859: Support active discharge control Mark Brown
2024-02-25 14:59 ` [PATCH 6/8] regulator: mp8859: Support status and error readback Mark Brown
2024-02-25 14:59 ` [PATCH 7/8] regulator: mp8859: Report slew rate Mark Brown
2024-02-25 14:59 ` [PATCH 8/8] regulator: mp8859: Implement set_current_limit() Mark Brown
2024-02-26 8:14 ` [PATCH 0/8] regulator: mp8859: Cleanups and enhancements Markus Reichl
2024-02-27 11:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240225-regulator-mp8859-v1-1-68ee2c839ded@kernel.org \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®