mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Liam Girdwood <lgirdwood@gmail.com>
Cc: linux-kernel@vger.kernel.org,
	Markus Reichl <m.reichl@fivetechno.de>,
	 Mark Brown <broonie@kernel.org>
Subject: [PATCH 4/8] regulator: mp8859: Support mode operations
Date: Sun, 25 Feb 2024 14:59:30 +0000	[thread overview]
Message-ID: <20240225-regulator-mp8859-v1-4-68ee2c839ded@kernel.org> (raw)
In-Reply-To: <20240225-regulator-mp8859-v1-0-68ee2c839ded@kernel.org>

The MP8859 provides mode control, implement the relevant regulator API
operations.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/mp8859.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/drivers/regulator/mp8859.c b/drivers/regulator/mp8859.c
index a443ebe927c5..b97c00097148 100644
--- a/drivers/regulator/mp8859.c
+++ b/drivers/regulator/mp8859.c
@@ -36,6 +36,7 @@
 #define MP8859_GO_BIT			0x01
 
 #define MP8859_ENABLE_MASK		0x80
+#define MP8859_MODE_MASK		0x08
 
 static int mp8859_set_voltage_sel(struct regulator_dev *rdev, unsigned int sel)
 {
@@ -74,6 +75,42 @@ static int mp8859_get_voltage_sel(struct regulator_dev *rdev)
 	return val;
 }
 
+static unsigned int mp8859_get_mode(struct regulator_dev *rdev)
+{
+	unsigned int val;
+	int ret;
+
+	ret = regmap_read(rdev->regmap, MP8859_CTL1_REG, &val);
+	if (ret != 0) {
+		dev_err(&rdev->dev, "Failed to read mode: %d\n", ret);
+		return 0;
+	}
+
+	if (val & MP8859_MODE_MASK)
+		return REGULATOR_MODE_FAST;
+	else
+		return REGULATOR_MODE_NORMAL;
+}
+
+static int mp8859_set_mode(struct regulator_dev *rdev, unsigned int mode)
+{
+	unsigned int val;
+
+	switch (mode) {
+	case REGULATOR_MODE_FAST:
+		val = MP8859_MODE_MASK;
+		break;
+	case REGULATOR_MODE_NORMAL:
+		val = 0;
+		break;
+	default:
+		return -EINVAL;
+	}
+
+	return regmap_update_bits(rdev->regmap, MP8859_CTL1_REG,
+				  MP8859_MODE_MASK, val);
+}
+
 static const struct linear_range mp8859_dcdc_ranges[] = {
 	REGULATOR_LINEAR_RANGE(0, VOL_MIN_IDX, VOL_MAX_IDX, 10000),
 };
@@ -128,6 +165,8 @@ static const struct regulator_ops mp8859_ops = {
 	.enable = regulator_enable_regmap,
 	.disable = regulator_disable_regmap,
 	.is_enabled = regulator_is_enabled_regmap,
+	.set_mode = mp8859_set_mode,
+	.get_mode = mp8859_get_mode,
 };
 
 static const struct regulator_desc mp8859_regulators[] = {

-- 
2.39.2


  parent reply	other threads:[~2024-02-25 15:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-25 14:59 [PATCH 0/8] regulator: mp8859: Cleanups and enhancements Mark Brown
2024-02-25 14:59 ` [PATCH 1/8] regulator: mp8859: Specify register accessibility and enable caching Mark Brown
2024-02-25 14:59 ` [PATCH 2/8] regulator: mp8859: Validate and log device identifier information Mark Brown
2024-02-25 14:59 ` [PATCH 3/8] regulator: mp8859: Support enable control Mark Brown
2024-02-25 14:59 ` Mark Brown [this message]
2024-02-25 14:59 ` [PATCH 5/8] regulator: mp8859: Support active discharge control Mark Brown
2024-02-25 14:59 ` [PATCH 6/8] regulator: mp8859: Support status and error readback Mark Brown
2024-02-25 14:59 ` [PATCH 7/8] regulator: mp8859: Report slew rate Mark Brown
2024-02-25 14:59 ` [PATCH 8/8] regulator: mp8859: Implement set_current_limit() Mark Brown
2024-02-26  8:14 ` [PATCH 0/8] regulator: mp8859: Cleanups and enhancements Markus Reichl
2024-02-27 11:31 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240225-regulator-mp8859-v1-4-68ee2c839ded@kernel.org \
    --to=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.reichl@fivetechno.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®