From: Alexander Dahl <ada@thorsis.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: ojeda@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, andy.shevchenko@gmail.com,
geert@linux-m68k.org, pavel@ucw.cz, lee@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 0/3] auxdisplay: 7 segment LED display
Date: Mon, 26 Feb 2024 17:04:58 +0100 [thread overview]
Message-ID: <20240226-scabby-fiber-87d5d6e45028@thorsis.com> (raw)
In-Reply-To: <20240225213423.690561-1-chris.packham@alliedtelesis.co.nz>
Hello Chris,
Am Mon, Feb 26, 2024 at 10:34:20AM +1300 schrieb Chris Packham:
> This series adds a driver for a 7 segment LED display.
>
> I'd like to get some feedback on how this could be extended to support >1
> character. The driver as presented is sufficient for my hardware which only has
> a single character display but I can see that for this to be generically useful
> supporting more characters would be desireable.
>
> Earlier I posted an idea that the characters could be represended by
> sub-nodes[1] but there doesn't seem to be a way of having that and keeping the
> convenience of using devm_gpiod_get_array() (unless I've missed something).
>
> [1] - https://lore.kernel.org/lkml/2a8d19ee-b18b-4b7c-869f-7d601cea30b6@alliedtelesis.co.nz/
Read that thread out of curiosity and I'm sorry if I'm late to the
party, but I wondered why this is limited to LEDs connected to GPIOs?
Would it be possible to somehow stack this on top of some existing
LEDs? I mean you could wire a 7 segment device to almost any LED
driver IC with enough channels, couldn't you?
Greets
Alex
>
> Chris Packham (3):
> auxdisplay: Add 7 segment LED display driver
> dt-bindings: auxdisplay: Add bindings for generic 7 segment LED
> ARM: dts: marvell: Add 7 segment LED display on x530
>
> .../auxdisplay/generic,gpio-7seg.yaml | 40 +++++
> .../boot/dts/marvell/armada-385-atl-x530.dts | 13 +-
> drivers/auxdisplay/Kconfig | 7 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/seg-led.c | 152 ++++++++++++++++++
> 5 files changed, 212 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/auxdisplay/generic,gpio-7seg.yaml
> create mode 100644 drivers/auxdisplay/seg-led.c
>
> --
> 2.43.2
>
>
next prev parent reply other threads:[~2024-02-26 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-25 21:34 Chris Packham
2024-02-25 21:34 ` [PATCH 1/3] auxdisplay: Add 7 segment LED display driver Chris Packham
2024-02-26 2:32 ` Andy Shevchenko
2024-02-26 2:49 ` Randy Dunlap
2024-02-25 21:34 ` [PATCH 2/3] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED Chris Packham
2024-02-25 21:34 ` [PATCH 3/3] ARM: dts: marvell: Add 7 segment LED display on x530 Chris Packham
2024-02-26 2:23 ` [PATCH 0/3] auxdisplay: 7 segment LED display Andy Shevchenko
2024-02-26 16:40 ` Andy Shevchenko
2024-02-27 0:52 ` Chris Packham
2024-02-27 0:58 ` Andy Shevchenko
2024-02-26 16:04 ` Alexander Dahl [this message]
2024-02-26 20:10 ` Chris Packham
2024-02-27 8:43 ` Alexander Dahl
2024-02-27 13:00 ` Andy Shevchenko
2024-02-27 13:04 ` Pavel Machek
2024-02-26 16:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240226-scabby-fiber-87d5d6e45028@thorsis.com \
--to=ada@thorsis.com \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®