* [PATCH] selftests/clone3: Correct log message for waitpid() failures
@ 2024-04-09 20:40 Mark Brown
2024-04-11 21:03 ` Shuah Khan
0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2024-04-09 20:40 UTC (permalink / raw)
To: Christian Brauner, Shuah Khan; +Cc: linux-kernel, linux-kselftest, Mark Brown
When logging an error from calling waitpid() on the child we print a
misleading error message saying that the error we report was returned by
the chilld. Fix this to say the error is from waitpid().
Signed-off-by: Mark Brown <broonie@kernel.org>
---
tools/testing/selftests/clone3/clone3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
index 3c9bf0cd82a8..eb108727c35c 100644
--- a/tools/testing/selftests/clone3/clone3.c
+++ b/tools/testing/selftests/clone3/clone3.c
@@ -95,7 +95,7 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
getpid(), pid);
if (waitpid(-1, &status, __WALL) < 0) {
- ksft_print_msg("Child returned %s\n", strerror(errno));
+ ksft_print_msg("waitpid() returned %s\n", strerror(errno));
return -errno;
}
if (WEXITSTATUS(status))
---
base-commit: 8cb4a9a82b21623dbb4b3051dd30d98356cf95bc
change-id: 20240405-kselftest-clone3-waitpid-68c4833cf5ff
Best regards,
--
Mark Brown <broonie@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] selftests/clone3: Correct log message for waitpid() failures
2024-04-09 20:40 [PATCH] selftests/clone3: Correct log message for waitpid() failures Mark Brown
@ 2024-04-11 21:03 ` Shuah Khan
0 siblings, 0 replies; 2+ messages in thread
From: Shuah Khan @ 2024-04-11 21:03 UTC (permalink / raw)
To: Mark Brown, Christian Brauner, Shuah Khan
Cc: linux-kernel, linux-kselftest, Shuah Khan
On 4/9/24 14:40, Mark Brown wrote:
> When logging an error from calling waitpid() on the child we print a
> misleading error message saying that the error we report was returned by
> the chilld. Fix this to say the error is from waitpid().
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
> tools/testing/selftests/clone3/clone3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
> index 3c9bf0cd82a8..eb108727c35c 100644
> --- a/tools/testing/selftests/clone3/clone3.c
> +++ b/tools/testing/selftests/clone3/clone3.c
> @@ -95,7 +95,7 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
> getpid(), pid);
>
> if (waitpid(-1, &status, __WALL) < 0) {
> - ksft_print_msg("Child returned %s\n", strerror(errno));
> + ksft_print_msg("waitpid() returned %s\n", strerror(errno));
> return -errno;
> }
> if (WEXITSTATUS(status))
>
> ---
> base-commit: 8cb4a9a82b21623dbb4b3051dd30d98356cf95bc
> change-id: 20240405-kselftest-clone3-waitpid-68c4833cf5ff
>
> Best regards,
Applied to linux-kselftest next for Linux 6.10-rc1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-11 21:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-09 20:40 [PATCH] selftests/clone3: Correct log message for waitpid() failures Mark Brown
2024-04-11 21:03 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®