* [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER_MEMORY
@ 2024-04-12 8:53 JianChunfu
2024-04-12 14:20 ` Alex Williamson
0 siblings, 1 reply; 2+ messages in thread
From: JianChunfu @ 2024-04-12 8:53 UTC (permalink / raw)
To: alex.williamson, cohuck; +Cc: linux-kernel, JianChunfu
The type1 ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called
in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/
VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description.
Signed-off-by: JianChunfu <chunfu.jian@shingroup.cn>
---
include/uapi/linux/vfio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
index 2b68e6cdf..30efc8af4 100644
--- a/include/uapi/linux/vfio.h
+++ b/include/uapi/linux/vfio.h
@@ -1764,7 +1764,7 @@ struct vfio_eeh_pe_op {
*
* Registers user space memory where DMA is allowed. It pins
* user pages and does the locked memory accounting so
- * subsequent VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA calls
+ * subsequent VFIO_IOMMU_SPAPR_TCE_CREATE/VFIO_IOMMU_SPAPR_TCE_REMOVE calls
* get faster.
*/
struct vfio_iommu_spapr_register_memory {
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER_MEMORY
2024-04-12 8:53 [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER_MEMORY JianChunfu
@ 2024-04-12 14:20 ` Alex Williamson
0 siblings, 0 replies; 2+ messages in thread
From: Alex Williamson @ 2024-04-12 14:20 UTC (permalink / raw)
To: JianChunfu; +Cc: cohuck, linux-kernel, kvm, Alexey Kardashevskiy
On Fri, 12 Apr 2024 16:53:33 +0800
JianChunfu <chunfu.jian@shingroup.cn> wrote:
> The type1 ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called
> in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/
> VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description.
This does not match my understanding of SPAPR which is that memory is
registered for use by MAP_DMA/UNMAP_DMA calls, _CREATE and _REMOVE are
used for managing DMA window apertures. Thanks,
Alex
> Signed-off-by: JianChunfu <chunfu.jian@shingroup.cn>
> ---
> include/uapi/linux/vfio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 2b68e6cdf..30efc8af4 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -1764,7 +1764,7 @@ struct vfio_eeh_pe_op {
> *
> * Registers user space memory where DMA is allowed. It pins
> * user pages and does the locked memory accounting so
> - * subsequent VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA calls
> + * subsequent VFIO_IOMMU_SPAPR_TCE_CREATE/VFIO_IOMMU_SPAPR_TCE_REMOVE calls
> * get faster.
> */
> struct vfio_iommu_spapr_register_memory {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-12 14:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-12 8:53 [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER_MEMORY JianChunfu
2024-04-12 14:20 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®