mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH v2 22/31] Staging: rtl8192e: Rename variable IsDataFrame
Date: Mon, 20 May 2024 20:17:09 -0700	[thread overview]
Message-ID: <20240521031718.17852-23-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net>

Rename variable IsDataFrame to is_data_frame
to fix checkpatch warning Avoid CamelCase.

Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v2: No change.
 drivers/staging/rtl8192e/rtllib.h    | 4 ++--
 drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index f69f4ca39fd5..0914ba37f42f 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -338,8 +338,8 @@ enum rt_op_mode {
 #define RTLLIB_QCTL_TID	      0x000F
 
 #define	FC_QOS_BIT					BIT(7)
-#define IsDataFrame(pdu)	(((pdu[0] & 0x0C) == 0x08) ? true : false)
-#define	is_legacy_data_frame(pdu)	(IsDataFrame(pdu) && (!(pdu[0]&FC_QOS_BIT)))
+#define is_data_frame(pdu)	(((pdu[0] & 0x0C) == 0x08) ? true : false)
+#define	is_legacy_data_frame(pdu)	(is_data_frame(pdu) && (!(pdu[0]&FC_QOS_BIT)))
 #define IsQoSDataFrame(pframe)			\
 	((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) ==	\
 	(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA))
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 50687f3dce47..9741d351363e 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -878,7 +878,7 @@ static int rtllib_rx_check_duplicate(struct rtllib_device *ieee,
 
 	if (!ieee->ht_info->cur_rx_reorder_enable ||
 		!ieee->current_network.qos_data.active ||
-		!IsDataFrame(skb->data) ||
+		!is_data_frame(skb->data) ||
 		is_legacy_data_frame(skb->data)) {
 		if (!ieee80211_is_beacon(hdr->frame_control)) {
 			if (is_duplicate_packet(ieee, hdr))
-- 
2.30.2


  parent reply	other threads:[~2024-05-21  3:17 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-21  3:16 [PATCH v2 00/31] Staging: rtl8192e: rtllib_rx.c Rename camelcase variables Tree Davies
2024-05-21  3:16 ` [PATCH v2 01/31] Staging: rtl8192e: Rename variable IsPassiveChannel Tree Davies
2024-05-21  3:16 ` [PATCH v2 02/31] Staging: rtl8192e: Rename variable CountryIeBuf Tree Davies
2024-05-21  3:16 ` [PATCH v2 03/31] Staging: rtl8192e: Rename variable CountryIeLen Tree Davies
2024-05-21  3:16 ` [PATCH v2 04/31] Staging: rtl8192e: Rename variable bWithAironetIE Tree Davies
2024-05-21  3:16 ` [PATCH v2 05/31] Staging: rtl8192e: Rename variable bContainHTC Tree Davies
2024-05-21  3:16 ` [PATCH v2 06/31] Staging: rtl8192e: Rename variable MBssid Tree Davies
2024-05-21  3:16 ` [PATCH v2 07/31] Staging: rtl8192e: Rename variable MBssidMask Tree Davies
2024-05-21  3:16 ` [PATCH v2 08/31] Staging: rtl8192e: Rename variable elementID Tree Davies
2024-05-21  3:16 ` [PATCH v2 09/31] Staging: rtl8192e: Rename variable rtllib_rx_Monitor Tree Davies
2024-05-21  3:16 ` [PATCH v2 10/31] Staging: rtl8192e: Rename variable rtllib_rx_InfraAdhoc Tree Davies
2024-05-21  3:16 ` [PATCH v2 11/31] Staging: rtl8192e: Rename variable IsLegacyDataFrame Tree Davies
2024-05-21  3:16 ` [PATCH v2 12/31] Staging: rtl8192e: Rename variable RxReorderIndicatePacket Tree Davies
2024-05-21  3:17 ` [PATCH v2 13/31] Staging: rtl8192e: Rename variable RfdArray Tree Davies
2024-05-21  3:17 ` [PATCH v2 14/31] Staging: rtl8192e: Rename variable Decrypted Tree Davies
2024-05-21  3:17 ` [PATCH v2 15/31] Staging: rtl8192e: Rename variable AddReorderEntry Tree Davies
2024-05-21  3:17 ` [PATCH v2 16/31] Staging: rtl8192e: Rename variable pList Tree Davies
2024-05-21  3:17 ` [PATCH v2 17/31] Staging: rtl8192e: Rename variable nPadding_Length Tree Davies
2024-05-21  3:17 ` [PATCH v2 18/31] Staging: rtl8192e: Rename variable LLCOffset Tree Davies
2024-05-21  3:17 ` [PATCH v2 19/31] Staging: rtl8192e: Remove variable ChkLength Tree Davies
2024-05-21  3:17 ` [PATCH v2 20/31] Staging: rtl8192e: Rename variable WinEnd Tree Davies
2024-05-21  3:17 ` [PATCH v2 21/31] Staging: rtl8192e: Rename variable WinSize Tree Davies
2024-05-21  3:17 ` Tree Davies [this message]
2024-05-21  3:17 ` [PATCH v2 23/31] Staging: rtl8192e: Rename variable bMatchWinStart Tree Davies
2024-05-21  3:17 ` [PATCH v2 24/31] Staging: rtl8192e: Rename variable bMBssidValid Tree Davies
2024-05-21  3:17 ` [PATCH v2 25/31] Staging: rtl8192e: Rename variable bWithCcxVerNum Tree Davies
2024-05-21  3:17 ` [PATCH v2 26/31] Staging: rtl8192e: Rename variable Frame_QoSTID Tree Davies
2024-05-21  3:17 ` [PATCH v2 27/31] Staging: rtl8192e: Rename variable CcxRmState Tree Davies
2024-05-21  3:17 ` [PATCH v2 28/31] Staging: rtl8192e: Rename variable IsQoSDataFrame Tree Davies
2024-05-21  3:17 ` [PATCH v2 29/31] Staging: rtl8192e: Rename variable RfdCnt Tree Davies
2024-05-21  3:17 ` [PATCH v2 30/31] Staging: rtl8192e: Rename variable prxbIndicateArray Tree Davies
2024-05-21  3:17 ` [PATCH v2 31/31] Staging: rtl8192e: Rename variable bPktInBuf Tree Davies
2024-05-21 20:01 ` [PATCH v2 00/31] Staging: rtl8192e: rtllib_rx.c Rename camelcase variables Philipp Hortmann
2024-05-23 14:44 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240521031718.17852-23-tdavies@darkphysics.net \
    --to=tdavies@darkphysics.net \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®