From: Tree Davies <tdavies@darkphysics.net>
To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com
Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Tree Davies <tdavies@darkphysics.net>
Subject: [PATCH v2 28/31] Staging: rtl8192e: Rename variable IsQoSDataFrame
Date: Mon, 20 May 2024 20:17:15 -0700 [thread overview]
Message-ID: <20240521031718.17852-29-tdavies@darkphysics.net> (raw)
In-Reply-To: <20240521031718.17852-1-tdavies@darkphysics.net>
Rename variable IsQoSDataFrame to is_qos_data_frame
to fix checkpatch warning Avoid CamelCase.
Signed-off-by: Tree Davies <tdavies@darkphysics.net>
---
v2: No change.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +-
drivers/staging/rtl8192e/rtllib.h | 2 +-
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
index 9b0a981f6f22..36a734ded7dc 100644
--- a/drivers/staging/rtl8192e/rtl819x_HTProc.c
+++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c
@@ -625,7 +625,7 @@ EXPORT_SYMBOL(HT_update_self_and_peer_setting);
u8 ht_c_check(struct rtllib_device *ieee, u8 *pFrame)
{
if (ieee->ht_info->current_ht_support) {
- if ((IsQoSDataFrame(pFrame) && frame_order(pFrame)) == 1) {
+ if ((is_qos_data_frame(pFrame) && frame_order(pFrame)) == 1) {
netdev_dbg(ieee->dev, "HT CONTROL FILED EXIST!!\n");
return true;
}
diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/rtllib.h
index ca69bb0965ba..e2695beaf582 100644
--- a/drivers/staging/rtl8192e/rtllib.h
+++ b/drivers/staging/rtl8192e/rtllib.h
@@ -340,7 +340,7 @@ enum rt_op_mode {
#define FC_QOS_BIT BIT(7)
#define is_data_frame(pdu) (((pdu[0] & 0x0C) == 0x08) ? true : false)
#define is_legacy_data_frame(pdu) (is_data_frame(pdu) && (!(pdu[0]&FC_QOS_BIT)))
-#define IsQoSDataFrame(pframe) \
+#define is_qos_data_frame(pframe) \
((*(u16 *)pframe&(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA)) == \
(IEEE80211_STYPE_QOS_DATA|RTLLIB_FTYPE_DATA))
#define frame_order(pframe) (*(u16 *)pframe&IEEE80211_FCTL_ORDER)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192e/rtllib_rx.c
index 3e8ee1335c24..4d4a4a830470 100644
--- a/drivers/staging/rtl8192e/rtllib_rx.c
+++ b/drivers/staging/rtl8192e/rtllib_rx.c
@@ -1319,7 +1319,7 @@ static int rtllib_rx_infra_adhoc(struct rtllib_device *ieee, struct sk_buff *skb
/* Get TS for Rx Reorder */
hdr = (struct ieee80211_hdr *)skb->data;
- if (ieee->current_network.qos_data.active && IsQoSDataFrame(skb->data)
+ if (ieee->current_network.qos_data.active && is_qos_data_frame(skb->data)
&& !is_multicast_ether_addr(hdr->addr1)) {
TID = frame_qos_tid(skb->data);
SeqNum = WLAN_GET_SEQ_SEQ(sc);
diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192e/rtllib_tx.c
index 1aeb207a3fee..b1bde5c0050a 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -275,7 +275,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device *ieee,
if (!ht_info->current_ht_support || !ht_info->enable_ht)
return;
- if (!IsQoSDataFrame(skb->data))
+ if (!is_qos_data_frame(skb->data))
return;
if (is_multicast_ether_addr(hdr->addr1))
return;
@@ -472,7 +472,7 @@ static u16 rtllib_query_seqnum(struct rtllib_device *ieee, struct sk_buff *skb,
if (is_multicast_ether_addr(dst))
return 0;
- if (IsQoSDataFrame(skb->data)) {
+ if (is_qos_data_frame(skb->data)) {
struct tx_ts_record *ts = NULL;
if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), dst,
--
2.30.2
next prev parent reply other threads:[~2024-05-21 3:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-21 3:16 [PATCH v2 00/31] Staging: rtl8192e: rtllib_rx.c Rename camelcase variables Tree Davies
2024-05-21 3:16 ` [PATCH v2 01/31] Staging: rtl8192e: Rename variable IsPassiveChannel Tree Davies
2024-05-21 3:16 ` [PATCH v2 02/31] Staging: rtl8192e: Rename variable CountryIeBuf Tree Davies
2024-05-21 3:16 ` [PATCH v2 03/31] Staging: rtl8192e: Rename variable CountryIeLen Tree Davies
2024-05-21 3:16 ` [PATCH v2 04/31] Staging: rtl8192e: Rename variable bWithAironetIE Tree Davies
2024-05-21 3:16 ` [PATCH v2 05/31] Staging: rtl8192e: Rename variable bContainHTC Tree Davies
2024-05-21 3:16 ` [PATCH v2 06/31] Staging: rtl8192e: Rename variable MBssid Tree Davies
2024-05-21 3:16 ` [PATCH v2 07/31] Staging: rtl8192e: Rename variable MBssidMask Tree Davies
2024-05-21 3:16 ` [PATCH v2 08/31] Staging: rtl8192e: Rename variable elementID Tree Davies
2024-05-21 3:16 ` [PATCH v2 09/31] Staging: rtl8192e: Rename variable rtllib_rx_Monitor Tree Davies
2024-05-21 3:16 ` [PATCH v2 10/31] Staging: rtl8192e: Rename variable rtllib_rx_InfraAdhoc Tree Davies
2024-05-21 3:16 ` [PATCH v2 11/31] Staging: rtl8192e: Rename variable IsLegacyDataFrame Tree Davies
2024-05-21 3:16 ` [PATCH v2 12/31] Staging: rtl8192e: Rename variable RxReorderIndicatePacket Tree Davies
2024-05-21 3:17 ` [PATCH v2 13/31] Staging: rtl8192e: Rename variable RfdArray Tree Davies
2024-05-21 3:17 ` [PATCH v2 14/31] Staging: rtl8192e: Rename variable Decrypted Tree Davies
2024-05-21 3:17 ` [PATCH v2 15/31] Staging: rtl8192e: Rename variable AddReorderEntry Tree Davies
2024-05-21 3:17 ` [PATCH v2 16/31] Staging: rtl8192e: Rename variable pList Tree Davies
2024-05-21 3:17 ` [PATCH v2 17/31] Staging: rtl8192e: Rename variable nPadding_Length Tree Davies
2024-05-21 3:17 ` [PATCH v2 18/31] Staging: rtl8192e: Rename variable LLCOffset Tree Davies
2024-05-21 3:17 ` [PATCH v2 19/31] Staging: rtl8192e: Remove variable ChkLength Tree Davies
2024-05-21 3:17 ` [PATCH v2 20/31] Staging: rtl8192e: Rename variable WinEnd Tree Davies
2024-05-21 3:17 ` [PATCH v2 21/31] Staging: rtl8192e: Rename variable WinSize Tree Davies
2024-05-21 3:17 ` [PATCH v2 22/31] Staging: rtl8192e: Rename variable IsDataFrame Tree Davies
2024-05-21 3:17 ` [PATCH v2 23/31] Staging: rtl8192e: Rename variable bMatchWinStart Tree Davies
2024-05-21 3:17 ` [PATCH v2 24/31] Staging: rtl8192e: Rename variable bMBssidValid Tree Davies
2024-05-21 3:17 ` [PATCH v2 25/31] Staging: rtl8192e: Rename variable bWithCcxVerNum Tree Davies
2024-05-21 3:17 ` [PATCH v2 26/31] Staging: rtl8192e: Rename variable Frame_QoSTID Tree Davies
2024-05-21 3:17 ` [PATCH v2 27/31] Staging: rtl8192e: Rename variable CcxRmState Tree Davies
2024-05-21 3:17 ` Tree Davies [this message]
2024-05-21 3:17 ` [PATCH v2 29/31] Staging: rtl8192e: Rename variable RfdCnt Tree Davies
2024-05-21 3:17 ` [PATCH v2 30/31] Staging: rtl8192e: Rename variable prxbIndicateArray Tree Davies
2024-05-21 3:17 ` [PATCH v2 31/31] Staging: rtl8192e: Rename variable bPktInBuf Tree Davies
2024-05-21 20:01 ` [PATCH v2 00/31] Staging: rtl8192e: rtllib_rx.c Rename camelcase variables Philipp Hortmann
2024-05-23 14:44 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240521031718.17852-29-tdavies@darkphysics.net \
--to=tdavies@darkphysics.net \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®