* [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros
@ 2024-05-31 16:03 Jeff Johnson
2024-06-01 3:08 ` Yury Norov
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Johnson @ 2024-05-31 16:03 UTC (permalink / raw)
To: Yury Norov, Rasmus Villemoes, Andrew Morton
Cc: linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
This is the subset of "missing MODULE_DESCRIPTION()" which fall under
the scope of the BITMAP API entry in the MAINTAINERS file.
---
lib/cpumask_kunit.c | 1 +
lib/find_bit_benchmark.c | 1 +
lib/test_bitmap.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
index a105e6369efc..6b62a6bdd50e 100644
--- a/lib/cpumask_kunit.c
+++ b/lib/cpumask_kunit.c
@@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
};
kunit_test_suite(test_cpumask_suite);
+MODULE_DESCRIPTION("KUnit tests for cpumask");
MODULE_LICENSE("GPL");
diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
index d3fb09e6eff1..402e160e7186 100644
--- a/lib/find_bit_benchmark.c
+++ b/lib/find_bit_benchmark.c
@@ -194,4 +194,5 @@ static int __init find_bit_test(void)
}
module_init(find_bit_test);
+MODULE_DESCRIPTION("Test for find_*_bit functions");
MODULE_LICENSE("GPL");
diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
index 6dfb8d46a4ff..65a75d58ed9e 100644
--- a/lib/test_bitmap.c
+++ b/lib/test_bitmap.c
@@ -1486,4 +1486,5 @@ static void __init selftest(void)
KSTM_MODULE_LOADERS(test_bitmap);
MODULE_AUTHOR("david decotigny <david.decotigny@googlers.com>");
+MODULE_DESCRIPTION("Test cases for bitmap API");
MODULE_LICENSE("GPL");
---
base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
change-id: 20240531-lib-bitmap-7ce67db2d173
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros
2024-05-31 16:03 [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros Jeff Johnson
@ 2024-06-01 3:08 ` Yury Norov
2024-07-23 18:47 ` Jeff Johnson
0 siblings, 1 reply; 3+ messages in thread
From: Yury Norov @ 2024-06-01 3:08 UTC (permalink / raw)
To: Jeff Johnson
Cc: Rasmus Villemoes, Andrew Morton, linux-kernel, kernel-janitors
On Fri, May 31, 2024 at 09:03:11AM -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> This is the subset of "missing MODULE_DESCRIPTION()" which fall under
> the scope of the BITMAP API entry in the MAINTAINERS file.
> ---
> lib/cpumask_kunit.c | 1 +
> lib/find_bit_benchmark.c | 1 +
> lib/test_bitmap.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
> index a105e6369efc..6b62a6bdd50e 100644
> --- a/lib/cpumask_kunit.c
> +++ b/lib/cpumask_kunit.c
> @@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
> };
> kunit_test_suite(test_cpumask_suite);
>
> +MODULE_DESCRIPTION("KUnit tests for cpumask");
> MODULE_LICENSE("GPL");
> diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
> index d3fb09e6eff1..402e160e7186 100644
> --- a/lib/find_bit_benchmark.c
> +++ b/lib/find_bit_benchmark.c
> @@ -194,4 +194,5 @@ static int __init find_bit_test(void)
> }
> module_init(find_bit_test);
>
> +MODULE_DESCRIPTION("Test for find_*_bit functions");
> MODULE_LICENSE("GPL");
> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> index 6dfb8d46a4ff..65a75d58ed9e 100644
> --- a/lib/test_bitmap.c
> +++ b/lib/test_bitmap.c
> @@ -1486,4 +1486,5 @@ static void __init selftest(void)
>
> KSTM_MODULE_LOADERS(test_bitmap);
> MODULE_AUTHOR("david decotigny <david.decotigny@googlers.com>");
> +MODULE_DESCRIPTION("Test cases for bitmap API");
> MODULE_LICENSE("GPL");
>
> ---
> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
> change-id: 20240531-lib-bitmap-7ce67db2d173
Applied in bitmap-for-next.
Thansk,
Yury
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros
2024-06-01 3:08 ` Yury Norov
@ 2024-07-23 18:47 ` Jeff Johnson
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Johnson @ 2024-07-23 18:47 UTC (permalink / raw)
To: Yury Norov; +Cc: Rasmus Villemoes, Andrew Morton, linux-kernel, kernel-janitors
On 5/31/2024 8:08 PM, Yury Norov wrote:
> On Fri, May 31, 2024 at 09:03:11AM -0700, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/find_bit_benchmark.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/cpumask_kunit.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in lib/test_bitmap.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> This is the subset of "missing MODULE_DESCRIPTION()" which fall under
>> the scope of the BITMAP API entry in the MAINTAINERS file.
>> ---
>> lib/cpumask_kunit.c | 1 +
>> lib/find_bit_benchmark.c | 1 +
>> lib/test_bitmap.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/lib/cpumask_kunit.c b/lib/cpumask_kunit.c
>> index a105e6369efc..6b62a6bdd50e 100644
>> --- a/lib/cpumask_kunit.c
>> +++ b/lib/cpumask_kunit.c
>> @@ -152,4 +152,5 @@ static struct kunit_suite test_cpumask_suite = {
>> };
>> kunit_test_suite(test_cpumask_suite);
>>
>> +MODULE_DESCRIPTION("KUnit tests for cpumask");
>> MODULE_LICENSE("GPL");
>> diff --git a/lib/find_bit_benchmark.c b/lib/find_bit_benchmark.c
>> index d3fb09e6eff1..402e160e7186 100644
>> --- a/lib/find_bit_benchmark.c
>> +++ b/lib/find_bit_benchmark.c
>> @@ -194,4 +194,5 @@ static int __init find_bit_test(void)
>> }
>> module_init(find_bit_test);
>>
>> +MODULE_DESCRIPTION("Test for find_*_bit functions");
>> MODULE_LICENSE("GPL");
>> diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
>> index 6dfb8d46a4ff..65a75d58ed9e 100644
>> --- a/lib/test_bitmap.c
>> +++ b/lib/test_bitmap.c
>> @@ -1486,4 +1486,5 @@ static void __init selftest(void)
>>
>> KSTM_MODULE_LOADERS(test_bitmap);
>> MODULE_AUTHOR("david decotigny <david.decotigny@googlers.com>");
>> +MODULE_DESCRIPTION("Test cases for bitmap API");
>> MODULE_LICENSE("GPL");
>>
>> ---
>> base-commit: 4a4be1ad3a6efea16c56615f31117590fd881358
>> change-id: 20240531-lib-bitmap-7ce67db2d173
>
> Applied in bitmap-for-next.
Hi,
I see this landed in linux-next, but is not currently in Linus' tree for 6.11.
Will you be able to have this pulled during the merge window?
I'm trying to eradicate all of these warnings before 6.11 rc-final.
Thanks!
/jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-23 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-31 16:03 [PATCH] lib: bitmap: add missing MODULE_DESCRIPTION() macros Jeff Johnson
2024-06-01 3:08 ` Yury Norov
2024-07-23 18:47 ` Jeff Johnson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®