* [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
@ 2024-05-31 0:08 linux
2024-05-31 10:09 ` Jeff Layton
2024-05-31 13:20 ` Chuck Lever
0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-05-31 0:08 UTC (permalink / raw)
To: chuck.lever, jlayton, neilb
Cc: linux-nfs, linux-kernel, Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <linux@treblig.org>
'nfsd3_voidargs' in nfs[23]acl.c is unused since
commit 788f7183fba8 ("NFSD: Add common helpers to decode void args and
encode void results").
Remove them.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
fs/nfsd/nfs2acl.c | 2 --
fs/nfsd/nfs3acl.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
index 12b2b9bc07bf..4e3be7201b1c 100644
--- a/fs/nfsd/nfs2acl.c
+++ b/fs/nfsd/nfs2acl.c
@@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct svc_rqst *rqstp)
fh_put(&resp->fh);
}
-struct nfsd3_voidargs { int dummy; };
-
#define ST 1 /* status*/
#define AT 21 /* attributes */
#define pAT (1+AT) /* post attributes - conditional */
diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
index 73adca47d373..5e34e98db969 100644
--- a/fs/nfsd/nfs3acl.c
+++ b/fs/nfsd/nfs3acl.c
@@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct svc_rqst *rqstp)
posix_acl_release(resp->acl_default);
}
-struct nfsd3_voidargs { int dummy; };
-
#define ST 1 /* status*/
#define AT 21 /* attributes */
#define pAT (1+AT) /* post attributes - conditional */
--
2.45.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
2024-05-31 0:08 [PATCH] NFSD: remove unused structs 'nfsd3_voidargs' linux
@ 2024-05-31 10:09 ` Jeff Layton
2024-05-31 13:20 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2024-05-31 10:09 UTC (permalink / raw)
To: linux, chuck.lever, neilb; +Cc: linux-nfs, linux-kernel
On Fri, 2024-05-31 at 01:08 +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args
> and
> encode void results").
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> fs/nfsd/nfs2acl.c | 2 --
> fs/nfsd/nfs3acl.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct
> svc_rqst *rqstp)
> fh_put(&resp->fh);
> }
>
> -struct nfsd3_voidargs { int dummy; };
> -
> #define ST 1 /* status*/
> #define AT 21 /* attributes */
> #define pAT (1+AT) /* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct
> svc_rqst *rqstp)
> posix_acl_release(resp->acl_default);
> }
>
> -struct nfsd3_voidargs { int dummy; };
> -
> #define ST 1 /* status*/
> #define AT 21 /* attributes */
> #define pAT (1+AT) /* post attributes - conditional */
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
2024-05-31 0:08 [PATCH] NFSD: remove unused structs 'nfsd3_voidargs' linux
2024-05-31 10:09 ` Jeff Layton
@ 2024-05-31 13:20 ` Chuck Lever
1 sibling, 0 replies; 3+ messages in thread
From: Chuck Lever @ 2024-05-31 13:20 UTC (permalink / raw)
To: linux; +Cc: jlayton, neilb, linux-nfs, linux-kernel
On Thu, May 30, 2024 at 08:08:38PM -0400, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args and
> encode void results").
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
> fs/nfsd/nfs2acl.c | 2 --
> fs/nfsd/nfs3acl.c | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct svc_rqst *rqstp)
> fh_put(&resp->fh);
> }
>
> -struct nfsd3_voidargs { int dummy; };
> -
> #define ST 1 /* status*/
> #define AT 21 /* attributes */
> #define pAT (1+AT) /* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct svc_rqst *rqstp)
> posix_acl_release(resp->acl_default);
> }
>
> -struct nfsd3_voidargs { int dummy; };
> -
> #define ST 1 /* status*/
> #define AT 21 /* attributes */
> #define pAT (1+AT) /* post attributes - conditional */
> --
> 2.45.1
>
Applied to nfsd-next (for v6.11). Thank you!
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-31 13:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-31 0:08 [PATCH] NFSD: remove unused structs 'nfsd3_voidargs' linux
2024-05-31 10:09 ` Jeff Layton
2024-05-31 13:20 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®