[PATCH v2 0/2] media: rockchip: rga: Add rk3588 support

[PATCH v2 0/2] media: rockchip: rga: Add rk3588 support

[Jianfeng Liu]

The RGA2 on the Rockchip rk3588 is the same core as the RGA2 on the
Rockchip rk3288 and rk3568.

This series adds the necessary device tree binding and node in the device
tree to enable the RGA2 on the Rockchip rk3588.

Tested on rock5b with gstreamer command:
gst-launch-1.0 videotestsrc ! video/x-raw,format=BGRx ! v4l2convert ! xvimagesink

Changes in v2:
- Sort node by bus-address based on next-20240604

Jianfeng Liu (2):
  dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga
  arm64: dts: rockchip: Add RGA2 support to rk3588

 .../devicetree/bindings/media/rockchip-rga.yaml       |  1 +
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi             | 11 +++++++++++
 2 files changed, 12 insertions(+)

-- 
2.34.1

[PATCH v2 1/2] dt-bindings: media: rockchip-rga: add rockchip,rk3588-rga

[Jianfeng Liu]

Add a new compatible for the rk3588 Rockchip SoC, which also features an
RGA, which is called RGA2 in the TRM Part2. It is the same core as used
on the rk3288 and rk3568, which documents the same RGA2.

Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---

(no changes since v1)

 Documentation/devicetree/bindings/media/rockchip-rga.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip-rga.yaml b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
index ea234222240..ac17cda6519 100644
--- a/Documentation/devicetree/bindings/media/rockchip-rga.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip-rga.yaml
@@ -24,6 +24,7 @@ properties:
           - enum:
               - rockchip,rk3228-rga
               - rockchip,rk3568-rga
+              - rockchip,rk3588-rga
           - const: rockchip,rk3288-rga
 
   reg:
-- 
2.34.1

[PATCH v2 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588

[Jianfeng Liu]

RK3588 also features a RGA2 block. Add the necessary device tree
node.

Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>

---

Changes in v2:
- Sort node by bus-address based on next-20240604

 arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 6ac5ac8b48a..beebc4dc0e7 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -1159,6 +1159,17 @@ power-domain@RK3588_PD_SDMMC {
 		};
 	};
 
+	rga: rga@fdb80000 {
+		compatible = "rockchip,rk3588-rga", "rockchip,rk3288-rga";
+		reg = <0x0 0xfdb80000 0x0 0x180>;
+		interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>;
+		clocks = <&cru ACLK_RGA2>, <&cru HCLK_RGA2>, <&cru CLK_RGA2_CORE>;
+		clock-names = "aclk", "hclk", "sclk";
+		resets = <&cru SRST_RGA2_CORE>, <&cru SRST_A_RGA2>, <&cru SRST_H_RGA2>;
+		reset-names = "core", "axi", "ahb";
+		power-domains = <&power RK3588_PD_VDPU>;
+	};
+
 	av1d: video-codec@fdc70000 {
 		compatible = "rockchip,rk3588-av1-vpu";
 		reg = <0x0 0xfdc70000 0x0 0x800>;
-- 
2.34.1

Re: [PATCH v2 2/2] arm64: dts: rockchip: Add RGA2 support to rk3588

[Tim Surber]

Hi Jianfeng,

I've tested RGA2 now for a while on a RK3588 board and it works correctly.

Of course it has to be updated and moved to probably rk3588-base.dtsi now.

With this done:

Tested-by: Tim Surber <me@timsurber.de>

Best regards,

Tim Surber

On 04.06.24 18:34, Jianfeng Liu wrote:
> RK3588 also features a RGA2 block. Add the necessary device tree
> node.
>
> Signed-off-by: Jianfeng Liu <liujianfeng1994@gmail.com>
>
> ---
>
> Changes in v2:
> - Sort node by bus-address based on next-20240604
>
>   arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> index 6ac5ac8b48a..beebc4dc0e7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
> @@ -1159,6 +1159,17 @@ power-domain@RK3588_PD_SDMMC {
>   		};
>   	};
>   
> +	rga: rga@fdb80000 {
> +		compatible = "rockchip,rk3588-rga", "rockchip,rk3288-rga";
> +		reg = <0x0 0xfdb80000 0x0 0x180>;
> +		interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH 0>;
> +		clocks = <&cru ACLK_RGA2>, <&cru HCLK_RGA2>, <&cru CLK_RGA2_CORE>;
> +		clock-names = "aclk", "hclk", "sclk";
> +		resets = <&cru SRST_RGA2_CORE>, <&cru SRST_A_RGA2>, <&cru SRST_H_RGA2>;
> +		reset-names = "core", "axi", "ahb";
> +		power-domains = <&power RK3588_PD_VDPU>;
> +	};
> +
>   	av1d: video-codec@fdc70000 {
>   		compatible = "rockchip,rk3588-av1-vpu";
>   		reg = <0x0 0xfdc70000 0x0 0x800>;