* RE: pwm: Fix double shift bug [not found] <2024052146-CVE-2023-52756-f694@gregkh> @ 2024-06-05 14:43 ` Ivan T. Ivanov 2024-06-08 11:37 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Ivan T. Ivanov @ 2024-06-05 14:43 UTC (permalink / raw) To: gregkh; +Cc: cve, linux-cve-announce, linux-kernel Hi, I could argue that this is not CVE at all. It changes just bit positions. - PWMF_REQUESTED = 1 << 0, - PWMF_EXPORTED = 1 << 1, + PWMF_REQUESTED = 0, + PWMF_EXPORTED = 1, ie. before fix they 1 and 2 and after the fix 0, 1. All call sites are using set/test_bit() on unsigned long flags. Yes, double shift do not look right, but I don't see how this could lead to malfunction, let alone a CVE. Regards, Ivan ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: pwm: Fix double shift bug 2024-06-05 14:43 ` pwm: Fix double shift bug Ivan T. Ivanov @ 2024-06-08 11:37 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2024-06-08 11:37 UTC (permalink / raw) To: Ivan T. Ivanov; +Cc: cve, linux-cve-announce, linux-kernel On Wed, Jun 05, 2024 at 05:43:05PM +0300, Ivan T. Ivanov wrote: > Hi, > > I could argue that this is not CVE at all. It changes just bit positions. > > - PWMF_REQUESTED = 1 << 0, > - PWMF_EXPORTED = 1 << 1, > + PWMF_REQUESTED = 0, > + PWMF_EXPORTED = 1, > > ie. before fix they 1 and 2 and after the fix 0, 1. > > All call sites are using set/test_bit() on unsigned long flags. > > Yes, double shift do not look right, but I don't see how > this could lead to malfunction, let alone a CVE. It could be an issue if the values were larger than 5 as the commit says, but that's not the case here, so you are correct and this has now been rejected as a cve. Thanks for the review! greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-08 11:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <2024052146-CVE-2023-52756-f694@gregkh>
2024-06-05 14:43 ` pwm: Fix double shift bug Ivan T. Ivanov
2024-06-08 11:37 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®