mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xuewen Yan <xuewen.yan@unisoc.com>
To: <vincent.guittot@linaro.org>, <mingo@redhat.com>,
	<peterz@infradead.org>, <juri.lelli@redhat.com>,
	<dietmar.eggemann@arm.com>
Cc: <rostedt@goodmis.org>, <bsegall@google.com>, <mgorman@suse.de>,
	<bristot@redhat.com>, <vschneid@redhat.com>,
	<vincent.donnefort@arm.com>, <qyousef@layalina.io>,
	<ke.wang@unisoc.com>, <xuewen.yan94@gmail.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] sched/fair: Prevent cpu_busy_time from exceeding actual_cpu_capacity
Date: Thu, 6 Jun 2024 15:06:45 +0800	[thread overview]
Message-ID: <20240606070645.3295-1-xuewen.yan@unisoc.com> (raw)

Because the effective_cpu_util() would return a util which
maybe bigger than the actual_cpu_capacity, this could cause
the pd_busy_time calculation errors.
So clamp the cpu_busy_time with the eenv->cpu_cap, which is
the actual_cpu_capacity.

Fixes: 3e8c6c9aac42 ("sched/fair: Remove task_util from effective utilization in feec()")
Signed-off-by: Xuewen Yan <xuewen.yan@unisoc.com>
---
 kernel/sched/fair.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 8a5b1ae0aa55..8939d725023a 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7870,7 +7870,9 @@ static inline void eenv_pd_busy_time(struct energy_env *eenv,
 	for_each_cpu(cpu, pd_cpus) {
 		unsigned long util = cpu_util(cpu, p, -1, 0);
 
-		busy_time += effective_cpu_util(cpu, util, NULL, NULL);
+		util = effective_cpu_util(cpu, util, NULL, NULL);
+		util = min(eenv->cpu_cap, util);
+		busy_time += util;
 	}
 
 	eenv->pd_busy_time = min(eenv->pd_cap, busy_time);
-- 
2.25.1


             reply	other threads:[~2024-06-06  7:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-06  7:06 Xuewen Yan [this message]
2024-06-07  7:19 ` Dietmar Eggemann
2024-06-07  8:20   ` Xuewen Yan
2024-06-07 10:30     ` Dietmar Eggemann
2024-06-07 10:37       ` Xuewen Yan
2024-06-21 10:22         ` Dietmar Eggemann
2024-06-24  2:27           ` Xuewen Yan
2024-06-09 22:55 ` Qais Yousef
2024-06-12  8:11   ` Xuewen Yan
2024-06-16 22:20     ` Qais Yousef
2024-06-17  7:27       ` Xuewen Yan
2024-06-17 11:03         ` Qais Yousef
2024-06-18 14:58           ` Qais Yousef
2024-06-19  2:46             ` Xuewen Yan
2024-06-19 18:03               ` Qais Yousef
2024-06-20  3:08                 ` Xuewen Yan
2024-06-21 10:40               ` Dietmar Eggemann
2024-06-21 13:00                 ` Vincent Guittot
2024-06-24  2:35                   ` Xuewen Yan
2024-06-18 15:20           ` Vincent Guittot
2024-06-18 15:26             ` Qais Yousef
2024-06-17  9:07       ` Vincent Guittot
2024-06-17 10:53         ` Qais Yousef
2024-06-18 15:23           ` Vincent Guittot
2024-06-18 15:39             ` Qais Yousef
2024-06-18 21:05               ` Vincent Guittot
2024-06-19 18:01                 ` Qais Yousef
2024-06-19  3:05               ` Xuewen Yan
2024-06-19 18:10                 ` Qais Yousef
2024-06-20  7:45                   ` Vincent Guittot
2024-06-20 11:37                     ` Qais Yousef
2024-06-21  8:22                       ` Dietmar Eggemann
2024-06-11  9:08 ` Christian Loehle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240606070645.3295-1-xuewen.yan@unisoc.com \
    --to=xuewen.yan@unisoc.com \
    --cc=bristot@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=juri.lelli@redhat.com \
    --cc=ke.wang@unisoc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qyousef@layalina.io \
    --cc=rostedt@goodmis.org \
    --cc=vincent.donnefort@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    --cc=xuewen.yan94@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®