mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Baochen Qiang <quic_bqiang@quicinc.com>,
	miriam.rachel.korenblit@intel.com, kvalo@kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32
Date: Mon, 17 Jun 2024 13:08:04 +0100	[thread overview]
Message-ID: <20240617120804.GA861@willie-the-truck> (raw)
In-Reply-To: <CAOMZO5CN_kbPcEYsN9SqqfUyrJdq9yaDisfJKL+CnENVTPuq3g@mail.gmail.com>

Hi Fabio,

On Thu, Jun 13, 2024 at 05:15:03PM -0300, Fabio Estevam wrote:
> On Thu, Jun 13, 2024 at 7:37 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> 
> > Oh. So I guess try to pick up commit 14cebf689a78 ("swiotlb: Reinstate
> > page-alignment for mappings >= PAGE_SIZE").
> 
> Good catch, thanks!
> 
> After applying 14cebf689a78 ("swiotlb: Reinstate> page-alignment for
> mappings >= PAGE_SIZE")
> on top of 6.6.33 I no longer have the flood of alignment warnings and
> iwlwifi can be used again:
> 
> # dmesg | grep iwlwifi
> [    4.295064] iwlwifi 0000:01:00.0: enabling device (0000 -> 0002)
> [    4.305459] iwlwifi 0000:01:00.0: Detected crf-id 0x3617, cnv-id
> 0x100530 wfpm id 0x80000000
> [    4.315440] iwlwifi 0000:01:00.0: PCI dev 2723/0084, rev=0x340, rfid=0x10a100
> [    4.346029] iwlwifi 0000:01:00.0: api flags index 2 larger than
> supported by driver
> [    4.353816] iwlwifi 0000:01:00.0: TLV_FW_FSEQ_VERSION: FSEQ
> Version: 89.3.35.37
> [    4.363135] iwlwifi 0000:01:00.0: loaded firmware version
> 77.ad46c98b.0 cc-a0-77.ucode op_mode iwlmvm
> [    4.444427] iwlwifi 0000:01:00.0: Detected Intel(R) Wi-Fi 6 AX200
> 160MHz, REV=0x340
> [    4.604918] iwlwifi 0000:01:00.0: Detected RF HR B3, rfid=0x10a100
> [    4.676138] iwlwifi 0000:01:00.0: base HW address: 3c:21:9c:4e:16:6x
> [    5.339929] iwlwifi 0000:01:00.0 wlp1s0: renamed from wlan0
> [    9.840136] iwlwifi 0000:01:00.0: Registered PHC clock:
> iwlwifi-PTP, with index: 1
> 
> Will, is it OK for me to ask the stable folks to backport 14cebf689a78
> ("swiotlb: Reinstate> page-alignment for mappings >= PAGE_SIZE")
> to 6.6 stable?

If you want to backport that change, then I think you should probably
take the whole series:

https://lore.kernel.org/all/20240308152829.25754-1-will@kernel.org/

(and there were some follow-ups from Michael iirc; you're best off
checking the git history for kernel/dma/swiotlb.c).

FWIW: we have this series backported to 6.6 in the android15-6.6 tree.

Will

  reply	other threads:[~2024-06-17 12:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 11:46 Fabio Estevam
2024-06-11 12:52 ` Johannes Berg
2024-06-11 13:43   ` Fabio Estevam
2024-06-11 13:54     ` Johannes Berg
2024-06-11 14:32       ` Fabio Estevam
2024-06-11 14:50         ` Johannes Berg
2024-06-11 14:59           ` Fabio Estevam
2024-06-12 19:10             ` Johannes Berg
2024-06-12 19:15               ` Fabio Estevam
2024-06-13  6:58                 ` Johannes Berg
2024-06-13  7:10                 ` Baochen Qiang
2024-06-13  7:40                   ` Johannes Berg
2024-06-13  9:51                     ` Baochen Qiang
2024-06-13 10:36                       ` Johannes Berg
2024-06-13 20:15                         ` Fabio Estevam
2024-06-17 12:08                           ` Will Deacon [this message]
2024-06-17 14:08                             ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240617120804.GA861@willie-the-truck \
    --to=will@kernel.org \
    --cc=festevam@gmail.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=quic_bqiang@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®