mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Fabio Estevam <festevam@gmail.com>
Cc: miriam.rachel.korenblit@intel.com, kvalo@kernel.org,
	Jakub Kicinski <kuba@kernel.org>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	 linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32
Date: Tue, 11 Jun 2024 15:54:16 +0200	[thread overview]
Message-ID: <95163ee547da95964c16f87a38d3326ae4da3253.camel@sipsolutions.net> (raw)
In-Reply-To: <CAOMZO5Aufe7zAE7TFVprvRreamYd9=RHjybjaEz2O9WaPksV=Q@mail.gmail.com>

Hi Fabio,

> 
> I did as suggested:
> 
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -266,7 +266,8 @@ static void iwl_pcie_rxmq_restock(struct iwl_trans *trans,
>                 list_del(&rxb->list);
>                 rxb->invalid = false;
>                 /* some low bits are expected to be unset (depending on hw) */
> -               WARN_ON(rxb->page_dma & trans_pcie->supported_dma_mask);
> +               WARN_ONCE(rxb->page_dma & trans_pcie->supported_dma_mask,
> +                         "rxb->offset is %d trans_pcie->rx_buf_bytes
> is %d\n", rxb->offset, trans_pcie->rx_buf_bytes);
> 

> [    5.038174] rxb->offset is 0 trans_pcie->rx_buf_bytes is 4096

so that looks pretty normal?

Might be useful to see rx->page_dma too, supported_dma_mask should be
4095 or 2047 depending on the device, but I'm not sure how you could end
up with a DMA mapping for a page that's not at least 11 bit aligned?

johannes

  reply	other threads:[~2024-06-11 13:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11 11:46 Fabio Estevam
2024-06-11 12:52 ` Johannes Berg
2024-06-11 13:43   ` Fabio Estevam
2024-06-11 13:54     ` Johannes Berg [this message]
2024-06-11 14:32       ` Fabio Estevam
2024-06-11 14:50         ` Johannes Berg
2024-06-11 14:59           ` Fabio Estevam
2024-06-12 19:10             ` Johannes Berg
2024-06-12 19:15               ` Fabio Estevam
2024-06-13  6:58                 ` Johannes Berg
2024-06-13  7:10                 ` Baochen Qiang
2024-06-13  7:40                   ` Johannes Berg
2024-06-13  9:51                     ` Baochen Qiang
2024-06-13 10:36                       ` Johannes Berg
2024-06-13 20:15                         ` Fabio Estevam
2024-06-17 12:08                           ` Will Deacon
2024-06-17 14:08                             ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95163ee547da95964c16f87a38d3326ae4da3253.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=festevam@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®