mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: chandan.babu@oracle.com, djwong@kernel.org, dchinner@redhat.com,
	hch@lst.de
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
	linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, catherine.hoang@oracle.com,
	martin.petersen@oracle.com, John Garry <john.g.garry@oracle.com>
Subject: [PATCH 10/13] xfs: Unmap blocks according to forcealign
Date: Fri, 21 Jun 2024 10:05:37 +0000	[thread overview]
Message-ID: <20240621100540.2976618-11-john.g.garry@oracle.com> (raw)
In-Reply-To: <20240621100540.2976618-1-john.g.garry@oracle.com>

For when forcealign is enabled, blocks in an inode need to be unmapped
according to extent alignment, like what is already done for rtvol.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 38 +++++++++++++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 5 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index c9cf138e13c4..ebeb2969b289 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -5380,6 +5380,25 @@ xfs_bmap_del_extent_real(
 	return 0;
 }
 
+static xfs_extlen_t
+xfs_bunmapi_align(
+	struct xfs_inode	*ip,
+	xfs_fsblock_t		bno)
+{
+	struct xfs_mount	*mp = ip->i_mount;
+	xfs_agblock_t		agbno;
+
+	if (xfs_inode_has_forcealign(ip)) {
+		if (is_power_of_2(ip->i_extsize))
+			return bno & (ip->i_extsize - 1);
+
+		agbno = XFS_FSB_TO_AGBNO(mp, bno);
+		return do_div(agbno, ip->i_extsize);
+	}
+	ASSERT(XFS_IS_REALTIME_INODE(ip));
+	return xfs_rtb_to_rtxoff(ip->i_mount, bno);
+}
+
 /*
  * Unmap (remove) blocks from a file.
  * If nexts is nonzero then the number of extents to remove is limited to
@@ -5402,6 +5421,7 @@ __xfs_bunmapi(
 	struct xfs_bmbt_irec	got;		/* current extent record */
 	struct xfs_ifork	*ifp;		/* inode fork pointer */
 	int			isrt;		/* freeing in rt area */
+	int			isforcealign;	/* freeing for inode with forcealign */
 	int			logflags;	/* transaction logging flags */
 	xfs_extlen_t		mod;		/* rt extent offset */
 	struct xfs_mount	*mp = ip->i_mount;
@@ -5439,6 +5459,8 @@ __xfs_bunmapi(
 	}
 	XFS_STATS_INC(mp, xs_blk_unmap);
 	isrt = xfs_ifork_is_realtime(ip, whichfork);
+	isforcealign = (whichfork != XFS_ATTR_FORK) &&
+			xfs_inode_has_forcealign(ip);
 	end = start + len;
 
 	if (!xfs_iext_lookup_extent_before(ip, ifp, &end, &icur, &got)) {
@@ -5490,11 +5512,10 @@ __xfs_bunmapi(
 		if (del.br_startoff + del.br_blockcount > end + 1)
 			del.br_blockcount = end + 1 - del.br_startoff;
 
-		if (!isrt || (flags & XFS_BMAPI_REMAP))
+		if ((!isrt && !isforcealign) || (flags & XFS_BMAPI_REMAP))
 			goto delete;
 
-		mod = xfs_rtb_to_rtxoff(mp,
-				del.br_startblock + del.br_blockcount);
+		mod = xfs_bunmapi_align(ip, del.br_startblock + del.br_blockcount);
 		if (mod) {
 			/*
 			 * Realtime extent not lined up at the end.
@@ -5542,9 +5563,16 @@ __xfs_bunmapi(
 			goto nodelete;
 		}
 
-		mod = xfs_rtb_to_rtxoff(mp, del.br_startblock);
+		mod = xfs_bunmapi_align(ip, del.br_startblock);
 		if (mod) {
-			xfs_extlen_t off = mp->m_sb.sb_rextsize - mod;
+			xfs_extlen_t off;
+
+			if (isforcealign) {
+				off = ip->i_extsize - mod;
+			} else {
+				ASSERT(isrt);
+				off = mp->m_sb.sb_rextsize - mod;
+			}
 
 			/*
 			 * Realtime extent is lined up at the end but not
-- 
2.31.1


  parent reply	other threads:[~2024-06-21 10:07 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 10:05 [PATCH 00/13] forcealign for xfs John Garry
2024-06-21 10:05 ` [PATCH 01/13] xfs: only allow minlen allocations when near ENOSPC John Garry
2024-06-21 19:42   ` Darrick J. Wong
2024-06-21 20:04     ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 02/13] xfs: always tail align maxlen allocations John Garry
2024-06-21 19:50   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 03/13] xfs: simplify extent allocation alignment John Garry
2024-06-21 20:29   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 04/13] xfs: make EOF allocation simpler John Garry
2024-06-21 20:35   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 05/13] xfs: introduce forced allocation alignment John Garry
2024-06-21 20:37   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 06/13] xfs: align args->minlen for " John Garry
2024-06-21 20:38   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 07/13] xfs: Introduce FORCEALIGN inode flag John Garry
2024-06-21 19:07   ` Darrick J. Wong
2024-06-24 14:36     ` John Garry
2024-06-21 10:05 ` [PATCH 08/13] xfs: Do not free EOF blocks for forcealign John Garry
2024-06-21 19:08   ` Darrick J. Wong
2024-06-24 15:04     ` John Garry
2024-06-21 10:05 ` [PATCH 09/13] xfs: Update xfs_inode_alloc_unitsize_fsb() " John Garry
2024-06-21 18:38   ` Darrick J. Wong
2024-06-24  7:34     ` John Garry
2024-06-21 10:05 ` John Garry [this message]
2024-06-21 19:12   ` [PATCH 10/13] xfs: Unmap blocks according to forcealign Darrick J. Wong
2024-06-24 15:12     ` John Garry
2024-06-21 10:05 ` [PATCH 11/13] xfs: Only free full extents for forcealign John Garry
2024-06-21 19:13   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 12/13] xfs: Don't revert allocated offset " John Garry
2024-06-21 19:13   ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 13/13] xfs: Enable file data forcealign feature John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240621100540.2976618-11-john.g.garry@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=brauner@kernel.org \
    --cc=catherine.hoang@oracle.com \
    --cc=chandan.babu@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=djwong@kernel.org \
    --cc=hch@lst.de \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®