From: John Garry <john.g.garry@oracle.com>
To: chandan.babu@oracle.com, djwong@kernel.org, dchinner@redhat.com,
hch@lst.de
Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, catherine.hoang@oracle.com,
martin.petersen@oracle.com, John Garry <john.g.garry@oracle.com>
Subject: [PATCH 12/13] xfs: Don't revert allocated offset for forcealign
Date: Fri, 21 Jun 2024 10:05:39 +0000 [thread overview]
Message-ID: <20240621100540.2976618-13-john.g.garry@oracle.com> (raw)
In-Reply-To: <20240621100540.2976618-1-john.g.garry@oracle.com>
In xfs_bmap_process_allocated_extent(), for when we found that we could not
provide the requested length completely, the mapping is moved so that we
can provide as much as possible for the original request.
For forcealign, this would mean ignoring alignment guaranteed, so don't do
this.
Signed-off-by: John Garry <john.g.garry@oracle.com>
---
fs/xfs/libxfs/xfs_bmap.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index ebeb2969b289..42f3582c1574 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -3492,11 +3492,15 @@ xfs_bmap_process_allocated_extent(
* original request as possible. Free space is apparently
* very fragmented so we're unlikely to be able to satisfy the
* hints anyway.
+ * However, for an inode with forcealign, continue with the
+ * found offset as we need to honour the alignment hint.
*/
- if (ap->length <= orig_length)
- ap->offset = orig_offset;
- else if (ap->offset + ap->length < orig_offset + orig_length)
- ap->offset = orig_offset + orig_length - ap->length;
+ if (!xfs_inode_has_forcealign(ap->ip)) {
+ if (ap->length <= orig_length)
+ ap->offset = orig_offset;
+ else if (ap->offset + ap->length < orig_offset + orig_length)
+ ap->offset = orig_offset + orig_length - ap->length;
+ }
xfs_bmap_alloc_account(ap);
}
--
2.31.1
next prev parent reply other threads:[~2024-06-21 10:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 10:05 [PATCH 00/13] forcealign for xfs John Garry
2024-06-21 10:05 ` [PATCH 01/13] xfs: only allow minlen allocations when near ENOSPC John Garry
2024-06-21 19:42 ` Darrick J. Wong
2024-06-21 20:04 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 02/13] xfs: always tail align maxlen allocations John Garry
2024-06-21 19:50 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 03/13] xfs: simplify extent allocation alignment John Garry
2024-06-21 20:29 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 04/13] xfs: make EOF allocation simpler John Garry
2024-06-21 20:35 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 05/13] xfs: introduce forced allocation alignment John Garry
2024-06-21 20:37 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 06/13] xfs: align args->minlen for " John Garry
2024-06-21 20:38 ` Darrick J. Wong
2024-06-21 10:05 ` [PATCH 07/13] xfs: Introduce FORCEALIGN inode flag John Garry
2024-06-21 19:07 ` Darrick J. Wong
2024-06-24 14:36 ` John Garry
2024-06-21 10:05 ` [PATCH 08/13] xfs: Do not free EOF blocks for forcealign John Garry
2024-06-21 19:08 ` Darrick J. Wong
2024-06-24 15:04 ` John Garry
2024-06-21 10:05 ` [PATCH 09/13] xfs: Update xfs_inode_alloc_unitsize_fsb() " John Garry
2024-06-21 18:38 ` Darrick J. Wong
2024-06-24 7:34 ` John Garry
2024-06-21 10:05 ` [PATCH 10/13] xfs: Unmap blocks according to forcealign John Garry
2024-06-21 19:12 ` Darrick J. Wong
2024-06-24 15:12 ` John Garry
2024-06-21 10:05 ` [PATCH 11/13] xfs: Only free full extents for forcealign John Garry
2024-06-21 19:13 ` Darrick J. Wong
2024-06-21 10:05 ` John Garry [this message]
2024-06-21 19:13 ` [PATCH 12/13] xfs: Don't revert allocated offset " Darrick J. Wong
2024-06-21 10:05 ` [PATCH 13/13] xfs: Enable file data forcealign feature John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240621100540.2976618-13-john.g.garry@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=chandan.babu@oracle.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®