mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: linux-kernel@vger.kernel.org
Cc: linux-tip-commits@vger.kernel.org,
	kernel test robot <lkp@intel.com>,
	Alexandre Chartre <alexandre.chartre@oracle.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	x86@kernel.org
Subject: Re: [tip: objtool/core] objtool/x86: objtool can confuse memory and stack access
Date: Mon, 8 Jul 2024 18:48:46 +0200	[thread overview]
Message-ID: <20240708164846.GFZowYbmQpBu2Y4GeL@fat_crate.local> (raw)
In-Reply-To: <172043936454.2215.16620277258416300859.tip-bot2@tip-bot2>

On Mon, Jul 08, 2024 at 11:49:24AM -0000, tip-bot2 for Alexandre Chartre wrote:
>  4c 8b 24 25 e0 ff ff    mov    0xffffffffffffffe0,%r12

Right, this is missing a "ff" which is the 4th byte of a disp32.

I.e., ModRM=0, SIB=5 simply means that what follows is a disp32 field:

 REX:                   0x4c { 4 [w]: 1 [r]: 1 [x]: 0 [b]: 0 }
Opcode:                 0x8b
ModRM:                  0x24  [mod:0b][.R:1b,reg:1100b][.B:0b,r/m:100b]
                        register-indirect mode, offset 0
SIB:                    0x25 [.B:0b,base:101b][.X:0b,idx:100b][scale: 0]

 MOV Gv,Ev; MOV reg{16,32,64} reg/mem{16,32,64}
               0:       4c 8b 24 25 e0 ff ff    mov 0xffffffffffffffe0,%r12
               7:       ff
-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2024-07-08 16:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-20 14:47 [PATCH V2 RESEND] " Alexandre Chartre
2024-07-03  6:43 ` Josh Poimboeuf
2024-07-08 11:49 ` [tip: objtool/core] " tip-bot2 for Alexandre Chartre
2024-07-08 16:48   ` Borislav Petkov [this message]
2024-07-09  8:00     ` Alexandre Chartre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240708164846.GFZowYbmQpBu2Y4GeL@fat_crate.local \
    --to=bp@alien8.de \
    --cc=alexandre.chartre@oracle.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®