From: Luke Parkin <luke.parkin@arm.com>
To: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org
Cc: sudeep.holla@arm.com, cristian.marussi@arm.com,
Luke Parkin <luke.parkin@arm.com>
Subject: [PATCH v3 5/5] firmware: arm_scmi: Reset statistics
Date: Mon, 15 Jul 2024 14:37:51 +0100 [thread overview]
Message-ID: <20240715133751.2877197-6-luke.parkin@arm.com> (raw)
In-Reply-To: <20240715133751.2877197-1-luke.parkin@arm.com>
Create write function to reset individual statistics on write
Create reset_all stats debugfs file to reset all statistics
Signed-off-by: Luke Parkin <luke.parkin@arm.com>
---
drivers/firmware/arm_scmi/driver.c | 104 +++++++++++++++++++++--------
1 file changed, 78 insertions(+), 26 deletions(-)
diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index 9378e2d8af4f..6a90311f764d 100644
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -2865,6 +2865,47 @@ static int scmi_device_request_notifier(struct notifier_block *nb,
return NOTIFY_OK;
}
+static int read_atomic(void *atomic, u64 *val)
+{
+ atomic_t *atm = (atomic_t *)atomic;
+
+ *val = atomic_read(atm);
+ return 0;
+}
+
+static int reset_single(void *atomic, u64 val)
+{
+ atomic_t *atm = (atomic_t *)atomic;
+
+ atomic_set(atm, 0);
+ return 0;
+}
+
+static void reset_all_stats(struct scmi_info *info)
+{
+ for (int i = 0; i < LAST; i++)
+ atomic_set(&info->dbg_stats[i], 0);
+}
+
+static ssize_t reset_all_on_write(struct file *filp,
+ const char __user *buf,
+ size_t count, loff_t *ppos)
+{
+ struct scmi_info *info = filp->private_data;
+
+ reset_all_stats(info);
+ return count;
+}
+
+DEFINE_DEBUGFS_ATTRIBUTE(fops_reset_on_write, read_atomic, reset_single, "%llu\n");
+
+static const struct file_operations fops_reset_stats = {
+ .owner = THIS_MODULE,
+ .open = simple_open,
+ .llseek = no_llseek,
+ .write = reset_all_on_write,
+};
+
static void scmi_debugfs_stats_setup(struct scmi_info *info,
struct dentry *trans)
{
@@ -2872,32 +2913,43 @@ static void scmi_debugfs_stats_setup(struct scmi_info *info,
stats = debugfs_create_dir("stats", trans);
- debugfs_create_atomic_t("sent_ok", 0400, stats,
- &info->dbg_stats[SENT_OK]);
- debugfs_create_atomic_t("sent_fail", 0400, stats,
- &info->dbg_stats[SENT_FAIL]);
- debugfs_create_atomic_t("sent_fail_polling_unsupported", 0400, stats,
- &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED]);
- debugfs_create_atomic_t("sent_fail_channel_not_found", 0400, stats,
- &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND]);
- debugfs_create_atomic_t("response_ok", 0400, stats,
- &info->dbg_stats[RESPONSE_OK]);
- debugfs_create_atomic_t("notif_ok", 0400, stats,
- &info->dbg_stats[NOTIF_OK]);
- debugfs_create_atomic_t("dlyd_resp_ok", 0400, stats,
- &info->dbg_stats[DLYD_RESPONSE_OK]);
- debugfs_create_atomic_t("xfers_resp_timeout", 0400, stats,
- &info->dbg_stats[XFERS_RESPONSE_TIMEOUT]);
- debugfs_create_atomic_t("response_polled_ok", 0400, stats,
- &info->dbg_stats[RESPONSE_POLLED_OK]);
- debugfs_create_atomic_t("err_msg_unexpected", 0400, stats,
- &info->dbg_stats[ERR_MSG_UNEXPECTED]);
- debugfs_create_atomic_t("err_msg_invalid", 0400, stats,
- &info->dbg_stats[ERR_MSG_INVALID]);
- debugfs_create_atomic_t("err_msg_nomem", 0400, stats,
- &info->dbg_stats[ERR_MSG_NOMEM]);
- debugfs_create_atomic_t("err_protocol", 0400, stats,
- &info->dbg_stats[ERR_PROTOCOL]);
+ debugfs_create_file("sent_ok", 0400, stats, &info->dbg_stats[SENT_OK],
+ &fops_reset_on_write);
+ debugfs_create_file("sent_fail", 0400, stats,
+ &info->dbg_stats[SENT_FAIL], &fops_reset_on_write);
+ debugfs_create_file("sent_fail_polling_unsupported", 0400, stats,
+ &info->dbg_stats[SENT_FAIL_POLLING_UNSUPPORTED],
+ &fops_reset_on_write);
+ debugfs_create_file("sent_fail_channel_not_found", 0400, stats,
+ &info->dbg_stats[SENT_FAIL_CHANNEL_NOT_FOUND],
+ &fops_reset_on_write);
+ debugfs_create_file("response_ok", 0400, stats,
+ &info->dbg_stats[RESPONSE_OK],
+ &fops_reset_on_write);
+ debugfs_create_file("notif_ok", 0400, stats, &info->dbg_stats[NOTIF_OK],
+ &fops_reset_on_write);
+ debugfs_create_file("dlyd_resp_ok", 0400, stats,
+ &info->dbg_stats[DLYD_RESPONSE_OK],
+ &fops_reset_on_write);
+ debugfs_create_file("xfers_resp_timeout", 0400, stats,
+ &info->dbg_stats[XFERS_RESPONSE_TIMEOUT],
+ &fops_reset_on_write);
+ debugfs_create_file("response_polled_ok", 0400, stats,
+ &info->dbg_stats[RESPONSE_POLLED_OK],
+ &fops_reset_on_write);
+ debugfs_create_file("err_msg_unexpected", 0400, stats,
+ &info->dbg_stats[ERR_MSG_UNEXPECTED],
+ &fops_reset_on_write);
+ debugfs_create_file("err_msg_invalid", 0400, stats,
+ &info->dbg_stats[ERR_MSG_INVALID],
+ &fops_reset_on_write);
+ debugfs_create_file("err_msg_nomem", 0400, stats,
+ &info->dbg_stats[ERR_MSG_NOMEM],
+ &fops_reset_on_write);
+ debugfs_create_file("err_protocol", 0400, stats,
+ &info->dbg_stats[ERR_PROTOCOL],
+ &fops_reset_on_write);
+ debugfs_create_file("reset", 0200, stats, info, &fops_reset_stats);
}
static void scmi_debugfs_common_cleanup(void *d)
--
2.34.1
next prev parent reply other threads:[~2024-07-15 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 13:37 [PATCH v3 0/5] Add Per-transport SCMI debug statistics Luke Parkin
2024-07-15 13:37 ` [PATCH v3 1/5] firmware: arm_scmi: Remove superfluous handle_to_scmi_info Luke Parkin
2024-07-24 13:07 ` Cristian Marussi
2024-07-15 13:37 ` [PATCH v3 2/5] firmware: arm_scmi: Add support for tracking statistics Luke Parkin
2024-07-24 13:40 ` Cristian Marussi
2024-07-15 13:37 ` [PATCH v3 3/5] firmware: arm_scmi: Track basic SCMI statistics Luke Parkin
2024-07-16 12:29 ` Peng Fan
2024-07-22 12:21 ` Luke Parkin
2024-07-24 14:24 ` Cristian Marussi
2024-07-24 14:21 ` Cristian Marussi
2024-07-24 14:39 ` Luke Parkin
2024-07-15 13:37 ` [PATCH v3 4/5] firmware: arm_scmi: Create debugfs files for statistics Luke Parkin
2024-07-24 14:26 ` Cristian Marussi
2024-07-15 13:37 ` Luke Parkin [this message]
2024-07-24 14:41 ` [PATCH v3 5/5] firmware: arm_scmi: Reset statistics Cristian Marussi
2024-07-24 14:46 ` [PATCH v3 0/5] Add Per-transport SCMI debug statistics Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240715133751.2877197-6-luke.parkin@arm.com \
--to=luke.parkin@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®