* [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
@ 2024-07-17 16:37 Vamsi Attunuru
2024-07-17 17:50 ` Jeff Johnson
2024-07-17 18:52 ` Arnd Bergmann
0 siblings, 2 replies; 5+ messages in thread
From: Vamsi Attunuru @ 2024-07-17 16:37 UTC (permalink / raw)
To: arnd, gregkh; +Cc: linux-kernel, nathan, quic_jjohnson, vattunuru
Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
compilation errors arise on 32-bit ARM with writeq() & readq() calls
which are used for accessing 64-bit values.
Since DPI hardware only works with 64-bit register accesses, using
CONFIG_64BIT dependency to skip compilation on 32-bit systems.
Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/misc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index f3bb75384627..41c3d2821a78 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -588,7 +588,7 @@ config NSM
config MARVELL_CN10K_DPI
tristate "Octeon CN10K DPI driver"
depends on PCI
- depends on ARCH_THUNDER || COMPILE_TEST
+ depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
help
Enables Octeon CN10K DMA packet interface (DPI) driver which
intializes DPI hardware's physical function (PF) device's
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
2024-07-17 16:37 [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems Vamsi Attunuru
@ 2024-07-17 17:50 ` Jeff Johnson
2024-07-18 5:05 ` Greg KH
2024-07-17 18:52 ` Arnd Bergmann
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Johnson @ 2024-07-17 17:50 UTC (permalink / raw)
To: Vamsi Attunuru, arnd, gregkh; +Cc: linux-kernel, nathan
On 7/17/24 09:37, Vamsi Attunuru wrote:
> Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> compilation errors arise on 32-bit ARM with writeq() & readq() calls
> which are used for accessing 64-bit values.
>
> Since DPI hardware only works with 64-bit register accesses, using
> CONFIG_64BIT dependency to skip compilation on 32-bit systems.
>
> Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Tested-by: Nathan Chancellor <nathan@kernel.org>
> Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/misc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index f3bb75384627..41c3d2821a78 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -588,7 +588,7 @@ config NSM
> config MARVELL_CN10K_DPI
> tristate "Octeon CN10K DPI driver"
> depends on PCI
> - depends on ARCH_THUNDER || COMPILE_TEST
> + depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> help
> Enables Octeon CN10K DMA packet interface (DPI) driver which
> intializes DPI hardware's physical function (PF) device's
BTW it looks like you accidentally submitted Makefile.rej, can you
submit a patch to remove it?
commit 5f67eef6dff39421215e9134f1eaae51b67a73b7
Author: Vamsi Attunuru <vattunuru@marvell.com>
Date: Sat Jul 6 08:30:09 2024 -0700
misc: mrvl-cn10k-dpi: add Octeon CN10K DPI administrative driver
...
diff --git a/drivers/misc/Makefile.rej b/drivers/misc/Makefile.rej
new file mode 100644
index 000000000000..a6aaed13f950
--- /dev/null
+++ b/drivers/misc/Makefile.rej
@@ -0,0 +1,7 @@
+--- drivers/misc/Makefile
++++ drivers/misc/Makefile
+@@ -69,3 +69,4 @@ obj-$(CONFIG_TMR_INJECT) += xilinx_tmr_inject.o
+ obj-$(CONFIG_TPS6594_ESM) += tps6594-esm.o
+ obj-$(CONFIG_TPS6594_PFSM) += tps6594-pfsm.o
+ obj-$(CONFIG_NSM) += nsm.o
++obj-$(CONFIG_MARVELL_CN10K_DPI) += mrvl_cn10k_dpi.o
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
2024-07-17 16:37 [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems Vamsi Attunuru
2024-07-17 17:50 ` Jeff Johnson
@ 2024-07-17 18:52 ` Arnd Bergmann
1 sibling, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2024-07-17 18:52 UTC (permalink / raw)
To: Vamsi Attunuru, Greg Kroah-Hartman
Cc: linux-kernel, Nathan Chancellor, Jeff Johnson
On Wed, Jul 17, 2024, at 18:37, Vamsi Attunuru wrote:
> Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> compilation errors arise on 32-bit ARM with writeq() & readq() calls
> which are used for accessing 64-bit values.
>
> Since DPI hardware only works with 64-bit register accesses, using
> CONFIG_64BIT dependency to skip compilation on 32-bit systems.
>
> Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for
> MARVELL_CN10K_DPI")
> Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> Tested-by: Nathan Chancellor <nathan@kernel.org>
> Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
2024-07-17 17:50 ` Jeff Johnson
@ 2024-07-18 5:05 ` Greg KH
2024-07-18 5:07 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2024-07-18 5:05 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Vamsi Attunuru, arnd, linux-kernel, nathan
On Wed, Jul 17, 2024 at 10:50:25AM -0700, Jeff Johnson wrote:
> On 7/17/24 09:37, Vamsi Attunuru wrote:
> > Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> > compilation errors arise on 32-bit ARM with writeq() & readq() calls
> > which are used for accessing 64-bit values.
> >
> > Since DPI hardware only works with 64-bit register accesses, using
> > CONFIG_64BIT dependency to skip compilation on 32-bit systems.
> >
> > Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Tested-by: Nathan Chancellor <nathan@kernel.org>
> > Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > ---
> > drivers/misc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > index f3bb75384627..41c3d2821a78 100644
> > --- a/drivers/misc/Kconfig
> > +++ b/drivers/misc/Kconfig
> > @@ -588,7 +588,7 @@ config NSM
> > config MARVELL_CN10K_DPI
> > tristate "Octeon CN10K DPI driver"
> > depends on PCI
> > - depends on ARCH_THUNDER || COMPILE_TEST
> > + depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> > help
> > Enables Octeon CN10K DMA packet interface (DPI) driver which
> > intializes DPI hardware's physical function (PF) device's
>
>
> BTW it looks like you accidentally submitted Makefile.rej, can you submit a
> patch to remove it?
That was me, not Vamsi, and should now be gone from the tree, sorry
about that.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems
2024-07-18 5:05 ` Greg KH
@ 2024-07-18 5:07 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2024-07-18 5:07 UTC (permalink / raw)
To: Jeff Johnson; +Cc: Vamsi Attunuru, arnd, linux-kernel, nathan
On Thu, Jul 18, 2024 at 07:05:37AM +0200, Greg KH wrote:
> On Wed, Jul 17, 2024 at 10:50:25AM -0700, Jeff Johnson wrote:
> > On 7/17/24 09:37, Vamsi Attunuru wrote:
> > > Upon adding CONFIG_ARCH_THUNDER & CONFIG_COMPILE_TEST dependency,
> > > compilation errors arise on 32-bit ARM with writeq() & readq() calls
> > > which are used for accessing 64-bit values.
> > >
> > > Since DPI hardware only works with 64-bit register accesses, using
> > > CONFIG_64BIT dependency to skip compilation on 32-bit systems.
> > >
> > > Fixes: a5e43e2d202d ("misc: Kconfig: add a new dependency for MARVELL_CN10K_DPI")
> > > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > > Tested-by: Nathan Chancellor <nathan@kernel.org>
> > > Tested-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> > > ---
> > > drivers/misc/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> > > index f3bb75384627..41c3d2821a78 100644
> > > --- a/drivers/misc/Kconfig
> > > +++ b/drivers/misc/Kconfig
> > > @@ -588,7 +588,7 @@ config NSM
> > > config MARVELL_CN10K_DPI
> > > tristate "Octeon CN10K DPI driver"
> > > depends on PCI
> > > - depends on ARCH_THUNDER || COMPILE_TEST
> > > + depends on ARCH_THUNDER || (COMPILE_TEST && 64BIT)
> > > help
> > > Enables Octeon CN10K DMA packet interface (DPI) driver which
> > > intializes DPI hardware's physical function (PF) device's
> >
> >
> > BTW it looks like you accidentally submitted Makefile.rej, can you submit a
> > patch to remove it?
>
> That was me, not Vamsi, and should now be gone from the tree, sorry
> about that.
Oops, forgot to push out my local tree, should show up now, sorry about
that.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-18 5:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-17 16:37 [PATCH] misc: Kconfig: exclude mrvl-cn10k-dpi compilation for 32-bit systems Vamsi Attunuru
2024-07-17 17:50 ` Jeff Johnson
2024-07-18 5:05 ` Greg KH
2024-07-18 5:07 ` Greg KH
2024-07-17 18:52 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®