* [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0
2024-07-30 14:33 [PATCH 0/3] arm64: dts: ti: k3-am62p/j722s: Fix gpio-ranges Jared McArthur
@ 2024-07-30 14:33 ` Jared McArthur
2024-07-30 14:59 ` Nishanth Menon
2024-07-30 14:33 ` [PATCH 2/3] arm64: dts: ti: k3-am62p: Fix gpio-range for main_pmx0 Jared McArthur
2024-07-30 14:33 ` [PATCH 3/3] arm64: dts: ti: k3-j722s: " Jared McArthur
2 siblings, 1 reply; 6+ messages in thread
From: Jared McArthur @ 2024-07-30 14:33 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring
Cc: linux-kernel, devicetree, linux-arm-kernel, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon, Jared McArthur
Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
properties") introduced pinmux range definition for gpio-ranges,
however missed introducing the range description for the mcu_gpio0
node. As a result, automatic mapping of GPIO to pin control for mcu
gpios is broken. Fix this by introducing the proper ranges.
Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
index e65db6ce02bf..c0bdbd00dc23 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
@@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 {
power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
clocks = <&k3_clks 79 0>;
clock-names = "gpio";
+ gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>,
+ <&mcu_pmx0 22 32 2>;
+ ti,ngpio = <24>;
};
mcu_rti0: watchdog@4880000 {
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0
2024-07-30 14:33 ` [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0 Jared McArthur
@ 2024-07-30 14:59 ` Nishanth Menon
2024-07-30 21:04 ` Jared McArthur
0 siblings, 1 reply; 6+ messages in thread
From: Nishanth Menon @ 2024-07-30 14:59 UTC (permalink / raw)
To: Jared McArthur
Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, linux-kernel,
devicetree, linux-arm-kernel, Tero Kristo, Vignesh Raghavendra
On 09:33-20240730, Jared McArthur wrote:
> Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
> properties") introduced pinmux range definition for gpio-ranges,
> however missed introducing the range description for the mcu_gpio0
> node. As a result, automatic mapping of GPIO to pin control for mcu
> gpios is broken. Fix this by introducing the proper ranges.
>
> Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
> Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> index e65db6ce02bf..c0bdbd00dc23 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
> @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 {
> power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
> clocks = <&k3_clks 79 0>;
> clock-names = "gpio";
> + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>,
> + <&mcu_pmx0 22 32 2>;
> + ti,ngpio = <24>;
we already have ti,ngpio - please drop
> };
>
> mcu_rti0: watchdog@4880000 {
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0
2024-07-30 14:59 ` Nishanth Menon
@ 2024-07-30 21:04 ` Jared McArthur
0 siblings, 0 replies; 6+ messages in thread
From: Jared McArthur @ 2024-07-30 21:04 UTC (permalink / raw)
To: Nishanth Menon
Cc: Conor Dooley, Krzysztof Kozlowski, Rob Herring, linux-kernel,
devicetree, linux-arm-kernel, Tero Kristo, Vignesh Raghavendra
On 7/30/24 09:59, Nishanth Menon wrote:
> On 09:33-20240730, Jared McArthur wrote:
>> Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
>> properties") introduced pinmux range definition for gpio-ranges,
>> however missed introducing the range description for the mcu_gpio0
>> node. As a result, automatic mapping of GPIO to pin control for mcu
>> gpios is broken. Fix this by introducing the proper ranges.
>>
>> Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
>> Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> index e65db6ce02bf..c0bdbd00dc23 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-j722s-common-mcu.dtsi
>> @@ -146,6 +146,9 @@ mcu_gpio0: gpio@4201000 {
>> power-domains = <&k3_pds 79 TI_SCI_PD_EXCLUSIVE>;
>> clocks = <&k3_clks 79 0>;
>> clock-names = "gpio";
>> + gpio-ranges = <&mcu_pmx0 0 0 21>, <&mcu_pmx0 21 23 1>,
>> + <&mcu_pmx0 22 32 2>;
>> + ti,ngpio = <24>;
> we already have ti,ngpio - please drop
Sorry, missed that. I will fix it and resend the patch.
>> };
>>
>> mcu_rti0: watchdog@4880000 {
>> --
>> 2.34.1
>>
--
Best,
Jared McArthur
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/3] arm64: dts: ti: k3-am62p: Fix gpio-range for main_pmx0
2024-07-30 14:33 [PATCH 0/3] arm64: dts: ti: k3-am62p/j722s: Fix gpio-ranges Jared McArthur
2024-07-30 14:33 ` [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0 Jared McArthur
@ 2024-07-30 14:33 ` Jared McArthur
2024-07-30 14:33 ` [PATCH 3/3] arm64: dts: ti: k3-j722s: " Jared McArthur
2 siblings, 0 replies; 6+ messages in thread
From: Jared McArthur @ 2024-07-30 14:33 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring
Cc: linux-kernel, devicetree, linux-arm-kernel, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon, Jared McArthur
Commit d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges
properties") introduced pinmux range definition for gpio-ranges,
however missed a hole within gpio-range for main_pmx0. As a result,
automatic mapping of GPIO to pin control for gpios within the
main_pmx0 domain is broken. Fix this by correcting the gpio-range.
Fixes: d72d73a44c3c ("arm64: dts: ti: k3-am62p: Add gpio-ranges properties")
Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62p-main.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
index 57383bd2eaeb..0ce9721b4176 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62p-main.dtsi
@@ -45,7 +45,8 @@ &inta_main_dmss {
&main_pmx0 {
pinctrl-single,gpio-range =
<&main_pmx0_range 0 32 PIN_GPIO_RANGE_IOPAD>,
- <&main_pmx0_range 33 92 PIN_GPIO_RANGE_IOPAD>,
+ <&main_pmx0_range 33 38 PIN_GPIO_RANGE_IOPAD>,
+ <&main_pmx0_range 72 22 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 137 5 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 143 3 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 149 2 PIN_GPIO_RANGE_IOPAD>;
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 3/3] arm64: dts: ti: k3-j722s: Fix gpio-range for main_pmx0
2024-07-30 14:33 [PATCH 0/3] arm64: dts: ti: k3-am62p/j722s: Fix gpio-ranges Jared McArthur
2024-07-30 14:33 ` [PATCH 1/3] arm64: dts: ti: k3-am62p: Add gpio-ranges for mcu_gpio0 Jared McArthur
2024-07-30 14:33 ` [PATCH 2/3] arm64: dts: ti: k3-am62p: Fix gpio-range for main_pmx0 Jared McArthur
@ 2024-07-30 14:33 ` Jared McArthur
2 siblings, 0 replies; 6+ messages in thread
From: Jared McArthur @ 2024-07-30 14:33 UTC (permalink / raw)
To: Conor Dooley, Krzysztof Kozlowski, Rob Herring
Cc: linux-kernel, devicetree, linux-arm-kernel, Tero Kristo,
Vignesh Raghavendra, Nishanth Menon, Jared McArthur
Commit 5e5c50964e2e ("arm64: dts: ti: k3-j722s: Add gpio-ranges
properties") introduced pinmux range definition for gpio-ranges,
however missed a hole within gpio-range for main_pmx0. As a result,
automatic mapping of GPIO to pin control for gpios within the
main_pmx0 domain is broken. Fix this by correcting the gpio-range.
Fixes: 5e5c50964e2e ("arm64: dts: ti: k3-j722s: Add gpio-ranges properties")
Signed-off-by: Jared McArthur <j-mcarthur@ti.com>
---
arch/arm64/boot/dts/ti/k3-j722s-main.dtsi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
index c797980528ec..dde4bd5c6645 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j722s-main.dtsi
@@ -193,7 +193,8 @@ &inta_main_dmss {
&main_pmx0 {
pinctrl-single,gpio-range =
<&main_pmx0_range 0 32 PIN_GPIO_RANGE_IOPAD>,
- <&main_pmx0_range 33 55 PIN_GPIO_RANGE_IOPAD>,
+ <&main_pmx0_range 33 38 PIN_GPIO_RANGE_IOPAD>,
+ <&main_pmx0_range 72 17 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 101 25 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 137 5 PIN_GPIO_RANGE_IOPAD>,
<&main_pmx0_range 143 3 PIN_GPIO_RANGE_IOPAD>,
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread