* [PATCH v19 0/2] Add i2c-mux and eeprom devices for Meta Yosemite4
@ 2024-09-20 7:04 Delphine CC Chiu
2024-09-20 7:04 ` [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-09-20 7:04 ` [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu
0 siblings, 2 replies; 6+ messages in thread
From: Delphine CC Chiu @ 2024-09-20 7:04 UTC (permalink / raw)
To: patrick
Cc: Delphine CC Chiu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
Changelog:
- v19
- Remove led_gpio pca9552 since there is no binding document.
- Add gpio devices on i2c mux 34.
- v18
- Fix warnings for reg_format reporting by dts checking tool.
- v17
- Add SoB for the patches.
- v16
- Reorganized the patches.
- Add i2c-mux and resolve the dt-validate errors.
- Revise Yosemite 4 devicetree for devices behind i2c-mux.
- Add mctp config and sensors for NIC after i2c-mux on bus 15.
- Add fan led config for BMC to control according the status of fan.
- v15
- Add ISL28022 support
- v14
- Add SQ52205 support
- Add GPIO I6 pin
- v13
- Add RTQ6056-support-on-bus-11
- v12
- Fix GPIO linename typo and add missing GPIO pin initial state.
- v11
- Revise all GPIO line name with bottom line
- v10
- adjust mgm cpld ioexp bus
- add GPIOO7 name
- remove mctp driver
- v9
- add XDP710 support
- add RTQ6056 support
- add MP5990 support
- v8
- add fan led config
- v7
- Revise pca9506 i2c address
- v6
- Revise i2c duty-cycle for meeting 400khz spec
- v5
- Support medusa board adc sensors
- support NIC eeprom
- v4
- Re-format gpio linename
- Revise i2c device node names
- Split patches by logic changes
- v3
- Correct patch for revising gpio name
- v2
- Revise mx31790 fan tach config
- Add mctp config for NIC
- Support mux to cpld
- Revise gpio name
- v1
- Add gpio and eeprom behind i2c-mux
- Remove redundant idle-state setting for i2c-mux
- Enable adc 15, wdt2,spi gpio for yosemite4 use
- Revise quad mode to dual mode to avoid WP pin influnece the SPI
- Revise power sensor adm1281 for yosemite4 schematic change
- Add gpio pca9506 I/O expander for yosemite4 use
- remove space for adm1272 compatible
- enable interrupt setting for pca9555
- add eeprom for yosemite4 medusa board/BSM use
- remove temperature sensor for yosemite4 schematic change
- add power sensor for power module reading
- Revise adc128d818 adc mode for yosemite4 schematic change
- Revise ina233 for yosemite4 schematic change
- Remove idle state setting for yosemite4 NIC connection
- Initialize bmc gpio state
- Revise mx31790 fan tach config
- Add mctp config for NIC
- Support mux to cpld
- Revise gpio name
Ricky CX Wu (2):
ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
.../aspeed/aspeed-bmc-facebook-yosemite4.dts | 567 +++++++++++++++---
1 file changed, 493 insertions(+), 74 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices 2024-09-20 7:04 [PATCH v19 0/2] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu @ 2024-09-20 7:04 ` Delphine CC Chiu 2024-09-23 1:01 ` Andrew Jeffery 2024-09-20 7:04 ` [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu 1 sibling, 1 reply; 6+ messages in thread From: Delphine CC Chiu @ 2024-09-20 7:04 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Ricky CX Wu, Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> Revise Yosemite 4 devicetree for devices behind i2c-mux - Add gpio and eeprom behind i2c-mux - Remove redundant idle-state setting for i2c-mux - Revise address of max31790 devices after i2c-mux. - Fix warnings reporting by dts checking tool. - Remove led_gpio pca9552 since there is no binding document. Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 539 +++++++++++++++--- 1 file changed, 466 insertions(+), 73 deletions(-) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 98477792aa00..6b4efb5fbd83 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -17,6 +17,29 @@ aliases { serial6 = &uart7; serial7 = &uart8; serial8 = &uart9; + + i2c16 = &imux16; + i2c17 = &imux17; + i2c18 = &imux18; + i2c19 = &imux19; + i2c20 = &imux20; + i2c21 = &imux21; + i2c22 = &imux22; + i2c23 = &imux23; + i2c24 = &imux24; + i2c25 = &imux25; + i2c26 = &imux26; + i2c27 = &imux27; + i2c28 = &imux28; + i2c29 = &imux29; + i2c30 = &imux30; + i2c31 = &imux31; + i2c32 = &imux32; + i2c33 = &imux33; + i2c34 = &imux34; + i2c35 = &imux35; + i2c36 = &imux36; + i2c37 = &imux37; }; chosen { @@ -255,41 +278,327 @@ power-sensor@40 { }; &i2c8 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; bus-frequency = <400000>; i2c-mux@70 { compatible = "nxp,pca9544"; - idle-state = <0>; - i2c-mux-idle-disconnect; reg = <0x70>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + imux16: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux17: i2c@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux18: i2c@2 { + reg = <2>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux19: i2c@3 { + reg = <3>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; }; }; &i2c9 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; bus-frequency = <400000>; i2c-mux@71 { compatible = "nxp,pca9544"; - idle-state = <0>; - i2c-mux-idle-disconnect; reg = <0x71>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + imux20: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux21: i2c@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux22: i2c@2 { + reg = <2>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; + + imux23: i2c@3 { + reg = <3>; + #address-cells = <1>; + #size-cells = <0>; + gpio@49 { + compatible = "nxp,pca9537"; + reg = <0x49>; + gpio-controller; + #gpio-cells = <2>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@51 { + compatible = "atmel,24c128"; + reg = <0x51>; + }; + + eeprom@54 { + compatible = "atmel,24c128"; + reg = <0x54>; + }; + }; }; }; &i2c10 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; bus-frequency = <400000>; + i2c-mux@74 { + compatible = "nxp,pca9544"; + reg = <0x74>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + imux28: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + gpio@20 { + compatible = "nxp,pca9506"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@21 { + compatible = "nxp,pca9506"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@22 { + compatible = "nxp,pca9506"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@23 { + compatible = "nxp,pca9506"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@24 { + compatible = "nxp,pca9506"; + reg = <0x24>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = "","","","", + "NIC0_MAIN_PWR_EN", + "NIC1_MAIN_PWR_EN", + "NIC2_MAIN_PWR_EN", + "NIC3_MAIN_PWR_EN", + "","","","","","","","", + "","","","","","","","", + "","","","","","","",""; + }; + }; + + imux29: i2c@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + }; + }; }; &i2c11 { status = "okay"; power-sensor@10 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x10>; }; power-sensor@12 { - compatible = "adi, adm1272"; + compatible = "adi,adm1272"; reg = <0x12>; }; @@ -348,22 +657,89 @@ eeprom@54 { }; &i2c12 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; bus-frequency = <400000>; - temperature-sensor@48 { - compatible = "ti,tmp75"; - reg = <0x48>; - }; + i2c-mux@70 { + compatible = "nxp,pca9544"; + reg = <0x70>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; - eeprom@50 { - compatible = "atmel,24c128"; - reg = <0x50>; - }; + imux34: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + + temperature-sensor@48 { + compatible = "ti,tmp75"; + reg = <0x48>; + }; + + eeprom@50 { + compatible = "atmel,24c128"; + reg = <0x50>; + }; + + eeprom@54 { + compatible = "atmel,24c64"; + reg = <0x54>; + }; + + rtc@6f { + compatible = "nuvoton,nct3018y"; + reg = <0x6f>; + }; + + gpio@20 { + compatible = "nxp,pca9506"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@21 { + compatible = "nxp,pca9506"; + reg = <0x21>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@22 { + compatible = "nxp,pca9506"; + reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; + }; + + gpio@23 { + compatible = "nxp,pca9506"; + reg = <0x23>; + gpio-controller; + #gpio-cells = <2>; + }; + }; + + imux35: i2c@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + }; + + imux36: i2c@2 { + reg = <2>; + #address-cells = <1>; + #size-cells = <0>; + }; - rtc@6f { - compatible = "nuvoton,nct3018y"; - reg = <0x6f>; + imux37: i2c@3 { + reg = <3>; + #address-cells = <1>; + #size-cells = <0>; + }; }; }; @@ -380,6 +756,8 @@ ipmb@10 { }; &i2c14 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; bus-frequency = <400000>; adc@1d { @@ -440,43 +818,39 @@ eeprom@51 { reg = <0x51>; }; - i2c-mux@71 { - compatible = "nxp,pca9846"; + i2c-mux@74 { + compatible = "nxp,pca9546"; + reg = <0x74>; #address-cells = <1>; #size-cells = <0>; - - idle-state = <0>; i2c-mux-idle-disconnect; - reg = <0x71>; - i2c@0 { + imux30: i2c@0 { + reg = <0>; #address-cells = <1>; #size-cells = <0>; - reg = <0>; adc@1f { compatible = "ti,adc128d818"; reg = <0x1f>; - ti,mode = /bits/ 8 <2>; + ti,mode = /bits/ 8 <1>; }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ compatible = "ti,tca6424"; reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; }; - pwm@23{ - compatible = "max31790"; - reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; + pwm@2f{ + compatible = "maxim,max31790"; + reg = <0x2f>; }; adc@33 { @@ -488,45 +862,34 @@ eeprom@52 { compatible = "atmel,24c128"; reg = <0x52>; }; - - gpio@61 { - compatible = "nxp,pca9552"; - reg = <0x61>; - #address-cells = <1>; - #size-cells = <0>; - gpio-controller; - #gpio-cells = <2>; - }; }; - i2c@1 { + imux31: i2c@1 { + reg = <1>; #address-cells = <1>; #size-cells = <0>; - reg = <0>; adc@1f { compatible = "ti,adc128d818"; reg = <0x1f>; - ti,mode = /bits/ 8 <2>; + ti,mode = /bits/ 8 <1>; }; pwm@20{ - compatible = "max31790"; + compatible = "maxim,max31790"; reg = <0x20>; - #address-cells = <1>; - #size-cells = <0>; }; gpio@22{ compatible = "ti,tca6424"; reg = <0x22>; + gpio-controller; + #gpio-cells = <2>; }; - pwm@23{ - compatible = "max31790"; - reg = <0x23>; - #address-cells = <1>; - #size-cells = <0>; + pwm@2f{ + compatible = "maxim,max31790"; + reg = <0x2f>; }; adc@33 { @@ -538,43 +901,30 @@ eeprom@52 { compatible = "atmel,24c128"; reg = <0x52>; }; - - gpio@61 { - compatible = "nxp,pca9552"; - reg = <0x61>; - #address-cells = <1>; - #size-cells = <0>; - gpio-controller; - #gpio-cells = <2>; - }; }; }; i2c-mux@73 { compatible = "nxp,pca9544"; + reg = <0x73>; #address-cells = <1>; #size-cells = <0>; - - idle-state = <0>; i2c-mux-idle-disconnect; - reg = <0x73>; - i2c@0 { + imux32: i2c@0 { + reg = <0>; #address-cells = <1>; #size-cells = <0>; - reg = <0>; - adc@35 { compatible = "maxim,max11617"; reg = <0x35>; }; }; - i2c@1 { + imux33: i2c@1 { + reg = <1>; #address-cells = <1>; #size-cells = <0>; - reg = <0>; - adc@35 { compatible = "maxim,max11617"; reg = <0x35>; @@ -584,6 +934,8 @@ adc@35 { }; &i2c15 { + #address-cells = <1>; + #size-cells = <0>; status = "okay"; mctp-controller; multi-master; @@ -596,9 +948,50 @@ mctp@10 { i2c-mux@72 { compatible = "nxp,pca9544"; - idle-state = <0>; - i2c-mux-idle-disconnect; reg = <0x72>; + #address-cells = <1>; + #size-cells = <0>; + i2c-mux-idle-disconnect; + + imux24: i2c@0 { + reg = <0>; + #address-cells = <1>; + #size-cells = <0>; + temperature-sensor@1f { + compatible = "ti,tmp421"; + reg = <0x1f>; + }; + }; + + imux25: i2c@1 { + reg = <1>; + #address-cells = <1>; + #size-cells = <0>; + temperature-sensor@1f { + compatible = "ti,tmp421"; + reg = <0x1f>; + }; + }; + + imux26: i2c@2 { + reg = <2>; + #address-cells = <1>; + #size-cells = <0>; + temperature-sensor@1f { + compatible = "ti,tmp421"; + reg = <0x1f>; + }; + }; + + imux27: i2c@3 { + reg = <3>; + #address-cells = <1>; + #size-cells = <0>; + temperature-sensor@1f { + compatible = "ti,tmp421"; + reg = <0x1f>; + }; + }; }; }; -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices 2024-09-20 7:04 ` [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu @ 2024-09-23 1:01 ` Andrew Jeffery 2024-09-26 1:42 ` Delphine_CC_Chiu/WYHQ/Wiwynn 0 siblings, 1 reply; 6+ messages in thread From: Andrew Jeffery @ 2024-09-23 1:01 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley Cc: Ricky CX Wu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Fri, 2024-09-20 at 15:04 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Revise Yosemite 4 devicetree for devices behind i2c-mux > - Add gpio and eeprom behind i2c-mux > - Remove redundant idle-state setting for i2c-mux > - Revise address of max31790 devices after i2c-mux. > - Fix warnings reporting by dts checking tool. Can you be more specific here? If you've had to fix existing warnings that the devicetree produces you should split those out into commits separate from adding further nodes. Instead, if you're just fixing warnings that this patch itself introduced then you should drop this comment as it's just a process issue. Process issues are better described in the patch notes or series cover letter, not in the commit message. Generally if you feel you have to list the changes you're making in the commit message for a single patch, it's a sign that you patch should be split into multiple commits anyway. > - Remove led_gpio pca9552 since there is no binding document. > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 539 +++++++++++++++--- > 1 file changed, 466 insertions(+), 73 deletions(-) > > diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > index 98477792aa00..6b4efb5fbd83 100644 > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > ... > > &i2c11 { > status = "okay"; > power-sensor@10 { > - compatible = "adi, adm1272"; > + compatible = "adi,adm1272"; > reg = <0x10>; > }; > > power-sensor@12 { > - compatible = "adi, adm1272"; > + compatible = "adi,adm1272"; > reg = <0x12>; > }; Can you please split the adm1272 compatible changes out to a separate patch and include an appropriate Fixes: tag? Andrew ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices 2024-09-23 1:01 ` Andrew Jeffery @ 2024-09-26 1:42 ` Delphine_CC_Chiu/WYHQ/Wiwynn 0 siblings, 0 replies; 6+ messages in thread From: Delphine_CC_Chiu/WYHQ/Wiwynn @ 2024-09-26 1:42 UTC (permalink / raw) To: Andrew Jeffery, Delphine_CC_Chiu/WYHQ/Wiwynn, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley Cc: Ricky CX Wu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel > -----Original Message----- > From: Andrew Jeffery <andrew@codeconstruct.com.au> > Sent: Monday, September 23, 2024 9:02 AM > To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>; > patrick@stwcx.xyz; Rob Herring <robh@kernel.org>; Krzysztof Kozlowski > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Joel Stanley > <joel@jms.id.au> > Cc: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>; > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux > devices > > [External Sender] > > [External Sender] > > On Fri, 2024-09-20 at 15:04 +0800, Delphine CC Chiu wrote: > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > > > Revise Yosemite 4 devicetree for devices behind i2c-mux > > - Add gpio and eeprom behind i2c-mux > > - Remove redundant idle-state setting for i2c-mux > > - Revise address of max31790 devices after i2c-mux. > > - Fix warnings reporting by dts checking tool. > > Can you be more specific here? If you've had to fix existing warnings that the > devicetree produces you should split those out into commits separate from > adding further nodes. Instead, if you're just fixing warnings that this patch > itself introduced then you should drop this comment as it's just a process issue. > Process issues are better described in the patch notes or series cover letter, not > in the commit message. > > Generally if you feel you have to list the changes you're making in the commit > message for a single patch, it's a sign that you patch should be split into > multiple commits anyway. > Hi Andrew, I'll split the patch to multiple patches according to the I2C bus. > > - Remove led_gpio pca9552 since there is no binding document. > > > > Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > > --- > > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 539 > > +++++++++++++++--- > > 1 file changed, 466 insertions(+), 73 deletions(-) > > > > diff --git > > a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > index 98477792aa00..6b4efb5fbd83 100644 > > --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts > > > > ... > > > > > &i2c11 { > > status = "okay"; > > power-sensor@10 { > > - compatible = "adi, adm1272"; > > + compatible = "adi,adm1272"; > > reg = <0x10>; > > }; > > > > power-sensor@12 { > > - compatible = "adi, adm1272"; > > + compatible = "adi,adm1272"; > > reg = <0x12>; > > }; > > Can you please split the adm1272 compatible changes out to a separate patch > and include an appropriate Fixes: tag? > > Andrew Sure, I sent another patch to correct the compatible string of adm1272. ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC 2024-09-20 7:04 [PATCH v19 0/2] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu 2024-09-20 7:04 ` [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu @ 2024-09-20 7:04 ` Delphine CC Chiu 2024-09-23 1:02 ` Andrew Jeffery 1 sibling, 1 reply; 6+ messages in thread From: Delphine CC Chiu @ 2024-09-20 7:04 UTC (permalink / raw) To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley, Andrew Jeffery Cc: Ricky CX Wu, Delphine CC Chiu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> - Add MCTP config for NIC and remove the unnecessary MCTP config on bus 15. - Add eeprom for NIC. Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> --- .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 30 +++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts index 6b4efb5fbd83..621e4e970790 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts @@ -937,7 +937,6 @@ &i2c15 { #address-cells = <1>; #size-cells = <0>; status = "okay"; - mctp-controller; multi-master; bus-frequency = <400000>; @@ -951,46 +950,73 @@ i2c-mux@72 { reg = <0x72>; #address-cells = <1>; #size-cells = <0>; - i2c-mux-idle-disconnect; imux24: i2c@0 { reg = <0>; #address-cells = <1>; #size-cells = <0>; + mctp-controller; + temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; }; imux25: i2c@1 { reg = <1>; #address-cells = <1>; #size-cells = <0>; + mctp-controller; + temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; }; imux26: i2c@2 { reg = <2>; #address-cells = <1>; #size-cells = <0>; + mctp-controller; + temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; }; imux27: i2c@3 { reg = <3>; #address-cells = <1>; #size-cells = <0>; + mctp-controller; + temperature-sensor@1f { compatible = "ti,tmp421"; reg = <0x1f>; }; + + eeprom@50 { + compatible = "atmel,24c64"; + reg = <0x50>; + }; }; }; }; -- 2.25.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC 2024-09-20 7:04 ` [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu @ 2024-09-23 1:02 ` Andrew Jeffery 0 siblings, 0 replies; 6+ messages in thread From: Andrew Jeffery @ 2024-09-23 1:02 UTC (permalink / raw) To: Delphine CC Chiu, patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley Cc: Ricky CX Wu, devicetree, linux-arm-kernel, linux-aspeed, linux-kernel On Fri, 2024-09-20 at 15:04 +0800, Delphine CC Chiu wrote: > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com> > > - Add MCTP config for NIC and remove the unnecessary MCTP config on bus > 15. > - Add eeprom for NIC. There's no suggestion that these are related. Why are they done in the same commit? Andrew ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-09-26 1:43 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2024-09-20 7:04 [PATCH v19 0/2] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu 2024-09-20 7:04 ` [PATCH v19 1/2] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu 2024-09-23 1:01 ` Andrew Jeffery 2024-09-26 1:42 ` Delphine_CC_Chiu/WYHQ/Wiwynn 2024-09-20 7:04 ` [PATCH v19 2/2] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu 2024-09-23 1:02 ` Andrew Jeffery
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®