mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xingquan Liu <b1n@b1n.io>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: Xingquan Liu <b1n@b1n.io>
Subject: [PATCH 2/7] staging: vt6655: Rename variable iTDUsed
Date: Sat, 21 Sep 2024 00:20:20 +0800	[thread overview]
Message-ID: <20240920162025.31465-2-b1n@b1n.io> (raw)
In-Reply-To: <20240920162025.31465-1-b1n@b1n.io>

Rename variable iTDUsed to i_td_used to fix checkpatch warning
Avoid CamelCase.

Signed-off-by: Xingquan Liu <b1n@b1n.io>
---
 drivers/staging/vt6655/card.c        | 2 +-
 drivers/staging/vt6655/device.h      | 4 ++--
 drivers/staging/vt6655/device_main.c | 6 +++---
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index 3b7284a23479..cda8ad4b3513 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -395,7 +395,7 @@ void card_safe_reset_tx(struct vnt_private *priv)
 	priv->ap_curr_td[1] = &priv->ap_td1_rings[0];
 
 	for (uu = 0; uu < TYPE_MAXTD; uu++)
-		priv->iTDUsed[uu] = 0;
+		priv->i_td_used[uu] = 0;
 
 	for (uu = 0; uu < priv->opts.tx_descs[0]; uu++) {
 		curr_td = &priv->ap_td0_rings[uu];
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index f4e14c65b1a8..57a396ad4d72 100644
--- a/drivers/staging/vt6655/device.h
+++ b/drivers/staging/vt6655/device.h
@@ -70,7 +70,7 @@
 
 /* BUILD OBJ mode */
 
-#define	AVAIL_TD(p, q)	((p)->opts.tx_descs[(q)] - ((p)->iTDUsed[(q)]))
+#define	AVAIL_TD(p, q)	((p)->opts.tx_descs[(q)] - ((p)->i_td_used[(q)]))
 
 /* 0:11A 1:11B 2:11G */
 #define BB_TYPE_11A    0
@@ -130,7 +130,7 @@ struct vnt_private {
 
 	spinlock_t                  lock;
 
-	volatile int                iTDUsed[TYPE_MAXTD];
+	volatile int                i_td_used[TYPE_MAXTD];
 
 	struct vnt_tx_desc *ap_curr_td[TYPE_MAXTD];
 	struct vnt_tx_desc *tail_td[TYPE_MAXTD];
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 052ebe0095a5..53e3aae29a59 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -969,7 +969,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
 	unsigned char byTsr0;
 	unsigned char byTsr1;
 
-	for (desc = priv->tail_td[idx]; priv->iTDUsed[idx] > 0; desc = desc->next) {
+	for (desc = priv->tail_td[idx]; priv->i_td_used[idx] > 0; desc = desc->next) {
 		if (desc->td0.owner == OWNED_BY_NIC)
 			break;
 		if (works++ > 15)
@@ -1003,7 +1003,7 @@ static int device_tx_srv(struct vnt_private *priv, unsigned int idx)
 			vnt_int_report_rate(priv, desc->td_info, byTsr0, byTsr1);
 
 			device_free_tx_buf(priv, desc);
-			priv->iTDUsed[idx]--;
+			priv->i_td_used[idx]--;
 		}
 	}
 
@@ -1270,7 +1270,7 @@ static int vnt_tx_packet(struct vnt_private *priv, struct sk_buff *skb)
 	else
 		vt6655_mac_dma_ctl(priv->port_offset, MAC_REG_TXDMACTL0);
 
-	priv->iTDUsed[dma_idx]++;
+	priv->i_td_used[dma_idx]++;
 
 	spin_unlock_irqrestore(&priv->lock, flags);
 
-- 
Xingquan Liu


  reply	other threads:[~2024-09-20 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 16:20 [PATCH 1/7] staging: vt6655: Rename variable apCurrTD Xingquan Liu
2024-09-20 16:20 ` Xingquan Liu [this message]
2024-09-21 14:10   ` [PATCH 2/7] staging: vt6655: Rename variable iTDUsed Philipp Hortmann
2024-09-22  4:46     ` Xingquan Liu
2024-09-23 12:09     ` Xingquan Liu
2024-09-24  7:29       ` Philipp Hortmann
2024-09-24 13:09         ` Xingquan Liu
2024-09-20 16:20 ` [PATCH 3/7] staging: vt6655: Rename function CARDvSafeResetRx Xingquan Liu
2024-09-20 16:20 ` [PATCH 4/7] staging: vt6655: Rename variable pDesc Xingquan Liu
2024-09-20 16:20 ` [PATCH 5/7] staging: vt6655: Rename variable pCurrRD Xingquan Liu
2024-09-20 16:20 ` [PATCH 6/7] staging: vt6655: Rename variable aRD0Ring Xingquan Liu
2024-09-20 16:20 ` [PATCH 7/7] staging: vt6655: Rename variable aRD1Ring Xingquan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240920162025.31465-2-b1n@b1n.io \
    --to=b1n@b1n.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®