mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Xingquan Liu <b1n@b1n.io>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] staging: vt6655: Rename variable iTDUsed
Date: Sat, 21 Sep 2024 16:10:09 +0200	[thread overview]
Message-ID: <e7bfce0c-74a4-4c0a-9930-a3fe9d5ea5fb@gmail.com> (raw)
In-Reply-To: <20240920162025.31465-2-b1n@b1n.io>

On 9/20/24 18:20, Xingquan Liu wrote:
> Rename variable iTDUsed to i_td_used to fix checkpatch warning
> Avoid CamelCase.


Hi Xingquan,

please do not take the first letter when it is "hungarian notation". On 
a first look it seems that the p is for pointer, i is for integer, a is 
for array.

If you send in a second version of this patch please use a change 
history. Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp

  reply	other threads:[~2024-09-21 14:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-20 16:20 [PATCH 1/7] staging: vt6655: Rename variable apCurrTD Xingquan Liu
2024-09-20 16:20 ` [PATCH 2/7] staging: vt6655: Rename variable iTDUsed Xingquan Liu
2024-09-21 14:10   ` Philipp Hortmann [this message]
2024-09-22  4:46     ` Xingquan Liu
2024-09-23 12:09     ` Xingquan Liu
2024-09-24  7:29       ` Philipp Hortmann
2024-09-24 13:09         ` Xingquan Liu
2024-09-20 16:20 ` [PATCH 3/7] staging: vt6655: Rename function CARDvSafeResetRx Xingquan Liu
2024-09-20 16:20 ` [PATCH 4/7] staging: vt6655: Rename variable pDesc Xingquan Liu
2024-09-20 16:20 ` [PATCH 5/7] staging: vt6655: Rename variable pCurrRD Xingquan Liu
2024-09-20 16:20 ` [PATCH 6/7] staging: vt6655: Rename variable aRD0Ring Xingquan Liu
2024-09-20 16:20 ` [PATCH 7/7] staging: vt6655: Rename variable aRD1Ring Xingquan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e7bfce0c-74a4-4c0a-9930-a3fe9d5ea5fb@gmail.com \
    --to=philipp.g.hortmann@gmail.com \
    --cc=b1n@b1n.io \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome