* [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check
@ 2024-09-09 6:33 Ma Ke
2024-09-10 17:26 ` Alain Volmat
2024-09-24 7:46 ` Alain Volmat
0 siblings, 2 replies; 3+ messages in thread
From: Ma Ke @ 2024-09-09 6:33 UTC (permalink / raw)
To: alain.volmat, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, benjamin.gaignard, vincent.abriou, akpm
Cc: dri-devel, linux-kernel, Ma Ke, stable
The return value of drm_atomic_get_crtc_state() needs to be
checked. To avoid use of error pointer 'crtc_state' in case
of the failure.
Cc: stable@vger.kernel.org
Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/gpu/drm/sti/sti_gdp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
index 43c72c2604a0..f046f5f7ad25 100644
--- a/drivers/gpu/drm/sti/sti_gdp.c
+++ b/drivers/gpu/drm/sti/sti_gdp.c
@@ -638,6 +638,9 @@ static int sti_gdp_atomic_check(struct drm_plane *drm_plane,
mixer = to_sti_mixer(crtc);
crtc_state = drm_atomic_get_crtc_state(state, crtc);
+ if (IS_ERR(crtc_state))
+ return PTR_ERR(crtc_state);
+
mode = &crtc_state->mode;
dst_x = new_plane_state->crtc_x;
dst_y = new_plane_state->crtc_y;
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check
2024-09-09 6:33 [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check Ma Ke
@ 2024-09-10 17:26 ` Alain Volmat
2024-09-24 7:46 ` Alain Volmat
1 sibling, 0 replies; 3+ messages in thread
From: Alain Volmat @ 2024-09-10 17:26 UTC (permalink / raw)
To: Ma Ke
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
benjamin.gaignard, vincent.abriou, akpm, dri-devel, linux-kernel,
stable, alain.volmat
Hi,
Thank you for your patch.
Acked-by: Alain Volmat <alain.volmat@foss.st.com>
Regards,
Alain
On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote:
> The return value of drm_atomic_get_crtc_state() needs to be
> checked. To avoid use of error pointer 'crtc_state' in case
> of the failure.
>
> Cc: stable@vger.kernel.org
> Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/gpu/drm/sti/sti_gdp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
> index 43c72c2604a0..f046f5f7ad25 100644
> --- a/drivers/gpu/drm/sti/sti_gdp.c
> +++ b/drivers/gpu/drm/sti/sti_gdp.c
> @@ -638,6 +638,9 @@ static int sti_gdp_atomic_check(struct drm_plane *drm_plane,
>
> mixer = to_sti_mixer(crtc);
> crtc_state = drm_atomic_get_crtc_state(state, crtc);
> + if (IS_ERR(crtc_state))
> + return PTR_ERR(crtc_state);
> +
> mode = &crtc_state->mode;
> dst_x = new_plane_state->crtc_x;
> dst_y = new_plane_state->crtc_y;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check
2024-09-09 6:33 [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check Ma Ke
2024-09-10 17:26 ` Alain Volmat
@ 2024-09-24 7:46 ` Alain Volmat
1 sibling, 0 replies; 3+ messages in thread
From: Alain Volmat @ 2024-09-24 7:46 UTC (permalink / raw)
To: Ma Ke
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
benjamin.gaignard, vincent.abriou, akpm, dri-devel, linux-kernel,
stable, alain.volmat
Hi,
On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote:
> The return value of drm_atomic_get_crtc_state() needs to be
> checked. To avoid use of error pointer 'crtc_state' in case
> of the failure.
>
> Cc: stable@vger.kernel.org
> Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/gpu/drm/sti/sti_gdp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_gdp.c b/drivers/gpu/drm/sti/sti_gdp.c
> index 43c72c2604a0..f046f5f7ad25 100644
> --- a/drivers/gpu/drm/sti/sti_gdp.c
> +++ b/drivers/gpu/drm/sti/sti_gdp.c
> @@ -638,6 +638,9 @@ static int sti_gdp_atomic_check(struct drm_plane *drm_plane,
>
> mixer = to_sti_mixer(crtc);
> crtc_state = drm_atomic_get_crtc_state(state, crtc);
> + if (IS_ERR(crtc_state))
> + return PTR_ERR(crtc_state);
> +
> mode = &crtc_state->mode;
> dst_x = new_plane_state->crtc_x;
> dst_y = new_plane_state->crtc_y;
> --
> 2.25.1
>
Thanks, patch applied.
Regards,
Alain
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-24 7:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-09 6:33 [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check Ma Ke
2024-09-10 17:26 ` Alain Volmat
2024-09-24 7:46 ` Alain Volmat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®