* [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check
@ 2024-09-13 9:09 Ma Ke
2024-09-24 7:48 ` Alain Volmat
0 siblings, 1 reply; 2+ messages in thread
From: Ma Ke @ 2024-09-13 9:09 UTC (permalink / raw)
To: alain.volmat, maarten.lankhorst, mripard, tzimmermann, airlied,
daniel, vincent.abriou, benjamin.gaignard
Cc: dri-devel, linux-kernel, Ma Ke, stable
The return value of drm_atomic_get_crtc_state() needs to be
checked. To avoid use of error pointer 'crtc_state' in case
of the failure.
Cc: stable@vger.kernel.org
Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
drivers/gpu/drm/sti/sti_hqvdp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index 0fb48ac044d8..abab92df78bd 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -1037,6 +1037,9 @@ static int sti_hqvdp_atomic_check(struct drm_plane *drm_plane,
return 0;
crtc_state = drm_atomic_get_crtc_state(state, crtc);
+ if (IS_ERR(crtc_state))
+ return PTR_ERR(crtc_state);
+
mode = &crtc_state->mode;
dst_x = new_plane_state->crtc_x;
dst_y = new_plane_state->crtc_y;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check
2024-09-13 9:09 [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check Ma Ke
@ 2024-09-24 7:48 ` Alain Volmat
0 siblings, 0 replies; 2+ messages in thread
From: Alain Volmat @ 2024-09-24 7:48 UTC (permalink / raw)
To: Ma Ke
Cc: maarten.lankhorst, mripard, tzimmermann, airlied, daniel,
vincent.abriou, benjamin.gaignard, dri-devel, linux-kernel,
stable, alain.volmat
Hi,
On Fri, Sep 13, 2024 at 05:09:26PM +0800, Ma Ke wrote:
> The return value of drm_atomic_get_crtc_state() needs to be
> checked. To avoid use of error pointer 'crtc_state' in case
> of the failure.
>
> Cc: stable@vger.kernel.org
> Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>
> ---
> drivers/gpu/drm/sti/sti_hqvdp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
> index 0fb48ac044d8..abab92df78bd 100644
> --- a/drivers/gpu/drm/sti/sti_hqvdp.c
> +++ b/drivers/gpu/drm/sti/sti_hqvdp.c
> @@ -1037,6 +1037,9 @@ static int sti_hqvdp_atomic_check(struct drm_plane *drm_plane,
> return 0;
>
> crtc_state = drm_atomic_get_crtc_state(state, crtc);
> + if (IS_ERR(crtc_state))
> + return PTR_ERR(crtc_state);
> +
> mode = &crtc_state->mode;
> dst_x = new_plane_state->crtc_x;
> dst_y = new_plane_state->crtc_y;
> --
> 2.25.1
>
Thanks, patch applied.
Regards,
Alain
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-24 8:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-13 9:09 [PATCH] drm/sti: avoid potential dereference of error pointers in sti_hqvdp_atomic_check Ma Ke
2024-09-24 7:48 ` Alain Volmat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®