* [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values
@ 2024-09-24 19:53 Judith Mendez
2024-10-08 11:12 ` Bhavya Kapoor
2024-10-30 4:50 ` Vignesh Raghavendra
0 siblings, 2 replies; 3+ messages in thread
From: Judith Mendez @ 2024-09-24 19:53 UTC (permalink / raw)
To: Vignesh Raghavendra, Nishanth Menon
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel, linux-arm-kernel, Bhavya Kapoor, Judith Mendez
Update itap/itap values according to device datasheet [0].
Now that we have fixed timing issues for am62x [1], lets
change the otap/itap values back according to the device
datasheet.
[0] https://www.ti.com/lit/ds/symlink/am625.pdf
[1] https://lore.kernel.org/linux-mmc/20240913185403.1339115-1-jm@ti.com/
Signed-off-by: Judith Mendez <jm@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 47 ++++++++++++------------
1 file changed, 23 insertions(+), 24 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
index 5b92aef5b284..7194603fd3bc 100644
--- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
@@ -561,10 +561,9 @@ sdhci0: mmc@fa10000 {
ti,clkbuf-sel = <0x7>;
ti,otap-del-sel-legacy = <0x0>;
ti,otap-del-sel-mmc-hs = <0x0>;
- ti,otap-del-sel-ddr52 = <0x5>;
- ti,otap-del-sel-hs200 = <0x5>;
- ti,itap-del-sel-legacy = <0xa>;
- ti,itap-del-sel-mmc-hs = <0x1>;
+ ti,otap-del-sel-hs200 = <0x6>;
+ ti,itap-del-sel-legacy = <0x0>;
+ ti,itap-del-sel-mmc-hs = <0x0>;
status = "disabled";
};
@@ -577,17 +576,17 @@ sdhci1: mmc@fa00000 {
clock-names = "clk_ahb", "clk_xin";
bus-width = <4>;
ti,clkbuf-sel = <0x7>;
- ti,otap-del-sel-legacy = <0x8>;
+ ti,otap-del-sel-legacy = <0x0>;
ti,otap-del-sel-sd-hs = <0x0>;
- ti,otap-del-sel-sdr12 = <0x0>;
- ti,otap-del-sel-sdr25 = <0x0>;
- ti,otap-del-sel-sdr50 = <0x8>;
- ti,otap-del-sel-sdr104 = <0x7>;
- ti,otap-del-sel-ddr50 = <0x4>;
- ti,itap-del-sel-legacy = <0xa>;
- ti,itap-del-sel-sd-hs = <0x1>;
- ti,itap-del-sel-sdr12 = <0xa>;
- ti,itap-del-sel-sdr25 = <0x1>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-sdr104 = <0x6>;
+ ti,otap-del-sel-ddr50 = <0x9>;
+ ti,itap-del-sel-legacy = <0x0>;
+ ti,itap-del-sel-sd-hs = <0x0>;
+ ti,itap-del-sel-sdr12 = <0x0>;
+ ti,itap-del-sel-sdr25 = <0x0>;
status = "disabled";
};
@@ -600,17 +599,17 @@ sdhci2: mmc@fa20000 {
clock-names = "clk_ahb", "clk_xin";
bus-width = <4>;
ti,clkbuf-sel = <0x7>;
- ti,otap-del-sel-legacy = <0x8>;
+ ti,otap-del-sel-legacy = <0x0>;
ti,otap-del-sel-sd-hs = <0x0>;
- ti,otap-del-sel-sdr12 = <0x0>;
- ti,otap-del-sel-sdr25 = <0x0>;
- ti,otap-del-sel-sdr50 = <0x8>;
- ti,otap-del-sel-sdr104 = <0x7>;
- ti,otap-del-sel-ddr50 = <0x8>;
- ti,itap-del-sel-legacy = <0xa>;
- ti,itap-del-sel-sd-hs = <0xa>;
- ti,itap-del-sel-sdr12 = <0xa>;
- ti,itap-del-sel-sdr25 = <0x1>;
+ ti,otap-del-sel-sdr12 = <0xf>;
+ ti,otap-del-sel-sdr25 = <0xf>;
+ ti,otap-del-sel-sdr50 = <0xc>;
+ ti,otap-del-sel-sdr104 = <0x6>;
+ ti,otap-del-sel-ddr50 = <0x9>;
+ ti,itap-del-sel-legacy = <0x0>;
+ ti,itap-del-sel-sd-hs = <0x0>;
+ ti,itap-del-sel-sdr12 = <0x0>;
+ ti,itap-del-sel-sdr25 = <0x0>;
status = "disabled";
};
--
2.46.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values
2024-09-24 19:53 [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values Judith Mendez
@ 2024-10-08 11:12 ` Bhavya Kapoor
2024-10-30 4:50 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Bhavya Kapoor @ 2024-10-08 11:12 UTC (permalink / raw)
To: Judith Mendez, Vignesh Raghavendra, Nishanth Menon
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, devicetree,
linux-kernel, linux-arm-kernel
Looks good to me !
On 25/09/24 01:23, Judith Mendez wrote:
> Update itap/itap values according to device datasheet [0].
>
> Now that we have fixed timing issues for am62x [1], lets
> change the otap/itap values back according to the device
> datasheet.
>
> [0] https://www.ti.com/lit/ds/symlink/am625.pdf
> [1] https://lore.kernel.org/linux-mmc/20240913185403.1339115-1-jm@ti.com/
>
> Signed-off-by: Judith Mendez <jm@ti.com>
Reviewed-by: Bhavya Kapoor<b-kapoor@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 47 ++++++++++++------------
> 1 file changed, 23 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 5b92aef5b284..7194603fd3bc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -561,10 +561,9 @@ sdhci0: mmc@fa10000 {
> ti,clkbuf-sel = <0x7>;
> ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-mmc-hs = <0x0>;
> - ti,otap-del-sel-ddr52 = <0x5>;
> - ti,otap-del-sel-hs200 = <0x5>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-mmc-hs = <0x1>;
> + ti,otap-del-sel-hs200 = <0x6>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-mmc-hs = <0x0>;
> status = "disabled";
> };
>
> @@ -577,17 +576,17 @@ sdhci1: mmc@fa00000 {
> clock-names = "clk_ahb", "clk_xin";
> bus-width = <4>;
> ti,clkbuf-sel = <0x7>;
> - ti,otap-del-sel-legacy = <0x8>;
> + ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-sd-hs = <0x0>;
> - ti,otap-del-sel-sdr12 = <0x0>;
> - ti,otap-del-sel-sdr25 = <0x0>;
> - ti,otap-del-sel-sdr50 = <0x8>;
> - ti,otap-del-sel-sdr104 = <0x7>;
> - ti,otap-del-sel-ddr50 = <0x4>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-sd-hs = <0x1>;
> - ti,itap-del-sel-sdr12 = <0xa>;
> - ti,itap-del-sel-sdr25 = <0x1>;
> + ti,otap-del-sel-sdr12 = <0xf>;
> + ti,otap-del-sel-sdr25 = <0xf>;
> + ti,otap-del-sel-sdr50 = <0xc>;
> + ti,otap-del-sel-sdr104 = <0x6>;
> + ti,otap-del-sel-ddr50 = <0x9>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-sd-hs = <0x0>;
> + ti,itap-del-sel-sdr12 = <0x0>;
> + ti,itap-del-sel-sdr25 = <0x0>;
> status = "disabled";
> };
>
> @@ -600,17 +599,17 @@ sdhci2: mmc@fa20000 {
> clock-names = "clk_ahb", "clk_xin";
> bus-width = <4>;
> ti,clkbuf-sel = <0x7>;
> - ti,otap-del-sel-legacy = <0x8>;
> + ti,otap-del-sel-legacy = <0x0>;
> ti,otap-del-sel-sd-hs = <0x0>;
> - ti,otap-del-sel-sdr12 = <0x0>;
> - ti,otap-del-sel-sdr25 = <0x0>;
> - ti,otap-del-sel-sdr50 = <0x8>;
> - ti,otap-del-sel-sdr104 = <0x7>;
> - ti,otap-del-sel-ddr50 = <0x8>;
> - ti,itap-del-sel-legacy = <0xa>;
> - ti,itap-del-sel-sd-hs = <0xa>;
> - ti,itap-del-sel-sdr12 = <0xa>;
> - ti,itap-del-sel-sdr25 = <0x1>;
> + ti,otap-del-sel-sdr12 = <0xf>;
> + ti,otap-del-sel-sdr25 = <0xf>;
> + ti,otap-del-sel-sdr50 = <0xc>;
> + ti,otap-del-sel-sdr104 = <0x6>;
> + ti,otap-del-sel-ddr50 = <0x9>;
> + ti,itap-del-sel-legacy = <0x0>;
> + ti,itap-del-sel-sd-hs = <0x0>;
> + ti,itap-del-sel-sdr12 = <0x0>;
> + ti,itap-del-sel-sdr25 = <0x0>;
> status = "disabled";
> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values
2024-09-24 19:53 [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values Judith Mendez
2024-10-08 11:12 ` Bhavya Kapoor
@ 2024-10-30 4:50 ` Vignesh Raghavendra
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh Raghavendra @ 2024-10-30 4:50 UTC (permalink / raw)
To: Nishanth Menon, Judith Mendez
Cc: Vignesh Raghavendra, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, devicetree, linux-kernel, linux-arm-kernel,
Bhavya Kapoor
Hi Judith Mendez,
On Tue, 24 Sep 2024 14:53:35 -0500, Judith Mendez wrote:
> Update itap/itap values according to device datasheet [0].
>
> Now that we have fixed timing issues for am62x [1], lets
> change the otap/itap values back according to the device
> datasheet.
>
> [0] https://www.ti.com/lit/ds/symlink/am625.pdf
> [1] https://lore.kernel.org/linux-mmc/20240913185403.1339115-1-jm@ti.com/
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am62-main: Update otap/itap values
commit: 14afef2333af526f975160e71889b2625c309068
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-30 4:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-24 19:53 [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values Judith Mendez
2024-10-08 11:12 ` Bhavya Kapoor
2024-10-30 4:50 ` Vignesh Raghavendra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®