* [PATCH] driver core: constify devlink class
@ 2024-10-14 12:28 Bartosz Golaszewski
2024-10-24 19:08 ` Bartosz Golaszewski
2024-10-24 19:45 ` Rafael J. Wysocki
0 siblings, 2 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2024-10-14 12:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J . Wysocki, Saravana Kannan
Cc: linux-kernel, Bartosz Golaszewski
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
The devlink class object is never modified and can be made constant.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/base/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index a84a7b952cfd..0e618d675792 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -553,7 +553,7 @@ void device_link_wait_removal(void)
}
EXPORT_SYMBOL_GPL(device_link_wait_removal);
-static struct class devlink_class = {
+static const struct class devlink_class = {
.name = "devlink",
.dev_groups = devlink_groups,
.dev_release = devlink_dev_release,
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] driver core: constify devlink class
2024-10-14 12:28 [PATCH] driver core: constify devlink class Bartosz Golaszewski
@ 2024-10-24 19:08 ` Bartosz Golaszewski
2024-10-24 19:45 ` Rafael J. Wysocki
1 sibling, 0 replies; 6+ messages in thread
From: Bartosz Golaszewski @ 2024-10-24 19:08 UTC (permalink / raw)
To: Greg Kroah-Hartman, Rafael J . Wysocki, Saravana Kannan
Cc: linux-kernel, Bartosz Golaszewski
On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The devlink class object is never modified and can be made constant.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index a84a7b952cfd..0e618d675792 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> }
> EXPORT_SYMBOL_GPL(device_link_wait_removal);
>
> -static struct class devlink_class = {
> +static const struct class devlink_class = {
> .name = "devlink",
> .dev_groups = devlink_groups,
> .dev_release = devlink_dev_release,
> --
> 2.43.0
>
Gentle ping.
Bart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] driver core: constify devlink class
2024-10-14 12:28 [PATCH] driver core: constify devlink class Bartosz Golaszewski
2024-10-24 19:08 ` Bartosz Golaszewski
@ 2024-10-24 19:45 ` Rafael J. Wysocki
2024-10-24 19:54 ` Saravana Kannan
1 sibling, 1 reply; 6+ messages in thread
From: Rafael J. Wysocki @ 2024-10-24 19:45 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Greg Kroah-Hartman, Rafael J . Wysocki, Saravana Kannan,
linux-kernel, Bartosz Golaszewski
On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The devlink class object is never modified and can be made constant.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> ---
> drivers/base/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index a84a7b952cfd..0e618d675792 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> }
> EXPORT_SYMBOL_GPL(device_link_wait_removal);
>
> -static struct class devlink_class = {
> +static const struct class devlink_class = {
> .name = "devlink",
> .dev_groups = devlink_groups,
> .dev_release = devlink_dev_release,
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] driver core: constify devlink class
2024-10-24 19:45 ` Rafael J. Wysocki
@ 2024-10-24 19:54 ` Saravana Kannan
2024-10-31 12:31 ` Bartosz Golaszewski
0 siblings, 1 reply; 6+ messages in thread
From: Saravana Kannan @ 2024-10-24 19:54 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Bartosz Golaszewski, Greg Kroah-Hartman, linux-kernel,
Bartosz Golaszewski
On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > The devlink class object is never modified and can be made constant.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Acked-by: Rafael J. Wysocki <rafael@kernel.org>
Acked-by: Saravana Kannan <saravanak@google.com>
-Saravana
>
> > ---
> > drivers/base/core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > index a84a7b952cfd..0e618d675792 100644
> > --- a/drivers/base/core.c
> > +++ b/drivers/base/core.c
> > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > }
> > EXPORT_SYMBOL_GPL(device_link_wait_removal);
> >
> > -static struct class devlink_class = {
> > +static const struct class devlink_class = {
> > .name = "devlink",
> > .dev_groups = devlink_groups,
> > .dev_release = devlink_dev_release,
> > --
> > 2.43.0
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] driver core: constify devlink class
2024-10-24 19:54 ` Saravana Kannan
@ 2024-10-31 12:31 ` Bartosz Golaszewski
2024-11-01 0:39 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Bartosz Golaszewski @ 2024-10-31 12:31 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, linux-kernel, Bartosz Golaszewski, Saravana Kannan
On Thu, Oct 24, 2024 at 9:54 PM Saravana Kannan <saravanak@google.com> wrote:
>
> On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> >
> > On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > The devlink class object is never modified and can be made constant.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
>
> Acked-by: Saravana Kannan <saravanak@google.com>
>
> -Saravana
>
> >
> > > ---
> > > drivers/base/core.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > index a84a7b952cfd..0e618d675792 100644
> > > --- a/drivers/base/core.c
> > > +++ b/drivers/base/core.c
> > > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > > }
> > > EXPORT_SYMBOL_GPL(device_link_wait_removal);
> > >
> > > -static struct class devlink_class = {
> > > +static const struct class devlink_class = {
> > > .name = "devlink",
> > > .dev_groups = devlink_groups,
> > > .dev_release = devlink_dev_release,
> > > --
> > > 2.43.0
> > >
Greg, can you pick this one up please?
Bart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] driver core: constify devlink class
2024-10-31 12:31 ` Bartosz Golaszewski
@ 2024-11-01 0:39 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2024-11-01 0:39 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Rafael J. Wysocki, linux-kernel, Bartosz Golaszewski, Saravana Kannan
On Thu, Oct 31, 2024 at 01:31:43PM +0100, Bartosz Golaszewski wrote:
> On Thu, Oct 24, 2024 at 9:54 PM Saravana Kannan <saravanak@google.com> wrote:
> >
> > On Thu, Oct 24, 2024 at 12:45 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> > >
> > > On Mon, Oct 14, 2024 at 2:28 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > > >
> > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > > >
> > > > The devlink class object is never modified and can be made constant.
> > > >
> > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > >
> > > Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> >
> > Acked-by: Saravana Kannan <saravanak@google.com>
> >
> > -Saravana
> >
> > >
> > > > ---
> > > > drivers/base/core.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/base/core.c b/drivers/base/core.c
> > > > index a84a7b952cfd..0e618d675792 100644
> > > > --- a/drivers/base/core.c
> > > > +++ b/drivers/base/core.c
> > > > @@ -553,7 +553,7 @@ void device_link_wait_removal(void)
> > > > }
> > > > EXPORT_SYMBOL_GPL(device_link_wait_removal);
> > > >
> > > > -static struct class devlink_class = {
> > > > +static const struct class devlink_class = {
> > > > .name = "devlink",
> > > > .dev_groups = devlink_groups,
> > > > .dev_release = devlink_dev_release,
> > > > --
> > > > 2.43.0
> > > >
>
> Greg, can you pick this one up please?
I will, give me time for trivial stuff like this please, lots of travel
and "other" things happening right now (i.e. my INBOX is trashed.)
Will be able to hopefully catch up by the end of next week if all goes
well...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-11-01 0:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-14 12:28 [PATCH] driver core: constify devlink class Bartosz Golaszewski
2024-10-24 19:08 ` Bartosz Golaszewski
2024-10-24 19:45 ` Rafael J. Wysocki
2024-10-24 19:54 ` Saravana Kannan
2024-10-31 12:31 ` Bartosz Golaszewski
2024-11-01 0:39 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®