From: Charlie Jenkins <charlie@rivosinc.com>
To: "Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Clément Léger" <cleger@rivosinc.com>,
"Evan Green" <evan@rivosinc.com>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: Palmer Dabbelt <palmer@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Charlie Jenkins <charlie@rivosinc.com>,
Jesse Taube <jesse@rivosinc.com>,
stable@vger.kernel.org
Subject: [PATCH v10 2/6] RISC-V: Scalar unaligned access emulated on hotplug CPUs
Date: Thu, 17 Oct 2024 12:00:19 -0700 [thread overview]
Message-ID: <20241017-jesse_unaligned_vector-v10-2-5b33500160f8@rivosinc.com> (raw)
In-Reply-To: <20241017-jesse_unaligned_vector-v10-0-5b33500160f8@rivosinc.com>
From: Jesse Taube <jesse@rivosinc.com>
The check_unaligned_access_emulated() function should have been called
during CPU hotplug to ensure that if all CPUs had emulated unaligned
accesses, the new CPU also does.
This patch adds the call to check_unaligned_access_emulated() in
the hotplug path.
Fixes: 55e0bf49a0d0 ("RISC-V: Probe misaligned access speed in parallel")
Signed-off-by: Jesse Taube <jesse@rivosinc.com>
Reviewed-by: Evan Green <evan@rivosinc.com>
Cc: stable@vger.kernel.org
---
arch/riscv/kernel/unaligned_access_speed.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c
index 160628a2116d..f3508cc54f91 100644
--- a/arch/riscv/kernel/unaligned_access_speed.c
+++ b/arch/riscv/kernel/unaligned_access_speed.c
@@ -191,6 +191,7 @@ static int riscv_online_cpu(unsigned int cpu)
if (per_cpu(misaligned_access_speed, cpu) != RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN)
goto exit;
+ check_unaligned_access_emulated(NULL);
buf = alloc_pages(GFP_KERNEL, MISALIGNED_BUFFER_ORDER);
if (!buf) {
pr_warn("Allocation failure, not measuring misaligned performance\n");
--
2.45.0
next prev parent reply other threads:[~2024-10-17 19:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 19:00 [PATCH v10 0/6] RISC-V: Detect and report speed of unaligned vector accesses Charlie Jenkins
2024-10-17 19:00 ` [PATCH v10 1/6] RISC-V: Check scalar unaligned access on all CPUs Charlie Jenkins
2024-10-17 19:00 ` Charlie Jenkins [this message]
2024-10-17 19:00 ` [PATCH v10 3/6] RISC-V: Replace RISCV_MISALIGNED with RISCV_SCALAR_MISALIGNED Charlie Jenkins
2024-10-17 19:00 ` [PATCH v10 4/6] RISC-V: Detect unaligned vector accesses supported Charlie Jenkins
2024-10-18 23:48 ` Jesse T
2024-10-17 19:00 ` [PATCH v10 5/6] RISC-V: Report vector unaligned access speed hwprobe Charlie Jenkins
2024-10-17 19:00 ` [PATCH v10 6/6] RISC-V: hwprobe: Document unaligned vector perf key Charlie Jenkins
2024-10-24 17:50 ` [PATCH v10 0/6] RISC-V: Detect and report speed of unaligned vector accesses patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241017-jesse_unaligned_vector-v10-2-5b33500160f8@rivosinc.com \
--to=charlie@rivosinc.com \
--cc=aou@eecs.berkeley.edu \
--cc=cleger@rivosinc.com \
--cc=corbet@lwn.net \
--cc=evan@rivosinc.com \
--cc=jesse@rivosinc.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®