* [PATCH] drivers: iio: adc: ad777x depends on CRC8
@ 2024-10-28 16:29 Arnd Bergmann
2024-10-28 20:04 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-10-28 16:29 UTC (permalink / raw)
To: Jonathan Cameron, Ramona Alexandra Nechita
Cc: Arnd Bergmann, Lars-Peter Clausen, Nuno Sa, linux-iio, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added driver fails to link when CONFIG_CRC8 is not set:
ld.lld-20: error: undefined symbol: crc8_populate_msb
ld.lld-20: error: undefined symbol: crc8
>>> vmlinux.o:(ad7779_spi_read)
Select this from Kconfig as we do for other drivers like it.
Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d8abe28eec89..849c90203071 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -290,6 +290,7 @@ config AD7768_1
config AD7779
tristate "Analog Devices AD7779 ADC driver"
depends on SPI
+ select CRC8
select IIO_BUFFER
help
Say yes here to build support for Analog Devices AD777X family
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers: iio: adc: ad777x depends on CRC8
2024-10-28 16:29 [PATCH] drivers: iio: adc: ad777x depends on CRC8 Arnd Bergmann
@ 2024-10-28 20:04 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2024-10-28 20:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Ramona Alexandra Nechita, Arnd Bergmann, Lars-Peter Clausen,
Nuno Sa, linux-iio, linux-kernel
On Mon, 28 Oct 2024 16:29:15 +0000
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added driver fails to link when CONFIG_CRC8 is not set:
>
> ld.lld-20: error: undefined symbol: crc8_populate_msb
> ld.lld-20: error: undefined symbol: crc8
> >>> vmlinux.o:(ad7779_spi_read)
>
> Select this from Kconfig as we do for other drivers like it.
>
> Fixes: cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Squashed into original patch.
Thanks!
Jonathan
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d8abe28eec89..849c90203071 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -290,6 +290,7 @@ config AD7768_1
> config AD7779
> tristate "Analog Devices AD7779 ADC driver"
> depends on SPI
> + select CRC8
> select IIO_BUFFER
> help
> Say yes here to build support for Analog Devices AD777X family
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-28 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-28 16:29 [PATCH] drivers: iio: adc: ad777x depends on CRC8 Arnd Bergmann
2024-10-28 20:04 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®