* [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()
@ 2024-10-29 10:58 Joerg Roedel
2024-10-29 11:43 ` Jason Gunthorpe
2024-10-29 16:31 ` Vasant Hegde
0 siblings, 2 replies; 3+ messages in thread
From: Joerg Roedel @ 2024-10-29 10:58 UTC (permalink / raw)
To: iommu
Cc: Will Deacon, linux-kernel, Joerg Roedel, Jason Gunthorpe, Vasant Hegde
From: Joerg Roedel <jroedel@suse.de>
The iommu_paging_domain_alloc_flags() prototype for
non-iommu kernel configurations lacks the 'static inline'
prefixes.
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Vasant Hegde <vasant.hegde@amd.com>
Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
include/linux/iommu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iommu.h b/include/linux/iommu.h
index aa78d911fdda..522efdc7d815 100644
--- a/include/linux/iommu.h
+++ b/include/linux/iommu.h
@@ -1080,7 +1080,7 @@ static inline bool device_iommu_capable(struct device *dev, enum iommu_cap cap)
return false;
}
-struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
+static inline struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
unsigned int flags)
{
return ERR_PTR(-ENODEV);
--
2.47.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()
2024-10-29 10:58 [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags() Joerg Roedel
@ 2024-10-29 11:43 ` Jason Gunthorpe
2024-10-29 16:31 ` Vasant Hegde
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2024-10-29 11:43 UTC (permalink / raw)
To: Joerg Roedel; +Cc: iommu, Will Deacon, linux-kernel, Joerg Roedel, Vasant Hegde
On Tue, Oct 29, 2024 at 11:58:49AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The iommu_paging_domain_alloc_flags() prototype for
> non-iommu kernel configurations lacks the 'static inline'
> prefixes.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Vasant Hegde <vasant.hegde@amd.com>
> Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---
> include/linux/iommu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Lacking 0-day again..
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags()
2024-10-29 10:58 [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags() Joerg Roedel
2024-10-29 11:43 ` Jason Gunthorpe
@ 2024-10-29 16:31 ` Vasant Hegde
1 sibling, 0 replies; 3+ messages in thread
From: Vasant Hegde @ 2024-10-29 16:31 UTC (permalink / raw)
To: Joerg Roedel, iommu
Cc: Will Deacon, linux-kernel, Joerg Roedel, Jason Gunthorpe
On 10/29/2024 4:28 PM, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> The iommu_paging_domain_alloc_flags() prototype for
> non-iommu kernel configurations lacks the 'static inline'
> prefixes.
>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Vasant Hegde <vasant.hegde@amd.com>
> Fixes: 20858d4ebb42 ("iommu: Introduce iommu_paging_domain_alloc_flags()")
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
Sorry. I missed to fix this one.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> ---
> include/linux/iommu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index aa78d911fdda..522efdc7d815 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -1080,7 +1080,7 @@ static inline bool device_iommu_capable(struct device *dev, enum iommu_cap cap)
> return false;
> }
>
> -struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
> +static inline struct iommu_domain *iommu_paging_domain_alloc_flags(struct device *dev,
> unsigned int flags)
> {
> return ERR_PTR(-ENODEV);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-29 16:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29 10:58 [PATCH] iommu: Fix prototype of iommu_paging_domain_alloc_flags() Joerg Roedel
2024-10-29 11:43 ` Jason Gunthorpe
2024-10-29 16:31 ` Vasant Hegde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®