* [PATCH] hwmon: tmp108: fix I3C dependency
@ 2024-11-13 17:55 Arnd Bergmann
2024-11-13 20:04 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2024-11-13 17:55 UTC (permalink / raw)
To: Jean Delvare, Guenter Roeck, Frank Li
Cc: Arnd Bergmann, linux-hwmon, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
It's possible to build a kernel with tmp108 built-in but i3c support
in a loadable module, but that results in a link failure:
x86_64-linux-ld: drivers/hwmon/tmp108.o: in function `p3t1085_i3c_probe':
tmp108.c:(.text+0x5f9): undefined reference to `i3cdev_to_dev'
Add a Kconfig dependency to ensure only the working configurations
are allowed.
Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/hwmon/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
index f15e72b319af..dd376602f3f1 100644
--- a/drivers/hwmon/Kconfig
+++ b/drivers/hwmon/Kconfig
@@ -2297,6 +2297,7 @@ config SENSORS_TMP103
config SENSORS_TMP108
tristate "Texas Instruments TMP108"
depends on I2C
+ depends on I3C || !I3C
select REGMAP_I2C
select REGMAP_I3C if I3C
help
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] hwmon: tmp108: fix I3C dependency
2024-11-13 17:55 [PATCH] hwmon: tmp108: fix I3C dependency Arnd Bergmann
@ 2024-11-13 20:04 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2024-11-13 20:04 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jean Delvare, Frank Li, Arnd Bergmann, linux-hwmon, linux-kernel
On Wed, Nov 13, 2024 at 06:55:33PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> It's possible to build a kernel with tmp108 built-in but i3c support
> in a loadable module, but that results in a link failure:
>
> x86_64-linux-ld: drivers/hwmon/tmp108.o: in function `p3t1085_i3c_probe':
> tmp108.c:(.text+0x5f9): undefined reference to `i3cdev_to_dev'
>
> Add a Kconfig dependency to ensure only the working configurations
> are allowed.
>
> Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I knew I missed something ;-).
Thanks a lot for the patch. Applied.
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-13 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-13 17:55 [PATCH] hwmon: tmp108: fix I3C dependency Arnd Bergmann
2024-11-13 20:04 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®