From: Baichuan Qi <zghbqbc@gmail.com>
To: markus.elfring@web.de
Cc: ath11k@lists.infradead.org, jjohnson@kernel.org,
kvalo@kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org, zghbqbc@gmail.com
Subject: Re: Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() ERROR code
Date: Wed, 27 Nov 2024 22:35:06 +0800 [thread overview]
Message-ID: <20241127143506.28267-1-zghbqbc@gmail.com> (raw)
In-Reply-To: <30b208e0-55a2-400f-9638-1765e7ed3bfa@web.de>
thanks for your reply
> May the detection of a null pointer for the data structure members
> “dest_ring” or “status_ring” really be interpreted as a successful execution
> of the function “ath11k_ce_rx_post_pipe”?
i submit this patch just want to ensure the last codes after
`if(...)` in `ath11k_ce_rx_post_pipe` can be successfully executed.
There is no error handling for NULL dest_ring (or status_ring)
in other funtions calling `ath11k_ce_rx_post_pipe()`, because it
would return 0, like successful end.
I think this patch can not change so many codes in other functions in
ce. This may involve a lot of error handling operations,
and depending on the severity of situation, the driver may even
re_setup the ring.
I will submit a v5 patch, and in that patch an error code will be
returned.
Baichuan Qi
next prev parent reply other threads:[~2024-11-27 14:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:08 [PATCH] wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() Baichuan Qi
2024-11-25 10:34 ` Markus Elfring
2024-11-26 2:33 ` Baichuan Qi
2024-11-26 13:44 ` Markus Elfring
2024-11-27 3:28 ` zgBCQ
2024-11-27 12:40 ` Markus Elfring
2024-11-27 14:35 ` Baichuan Qi [this message]
2024-11-27 14:38 ` [PATCH v5] " Baichuan Qi
2024-11-27 15:23 ` Vasanthakumar Thiagarajan
2024-11-28 6:09 ` Re: [PATCH v5] NAK Baichuan Qi
2024-11-27 3:32 ` [PATCH v2 1/1] wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() Baichuan Qi
2024-11-27 9:05 ` [PATCH v4?] " Markus Elfring
2024-11-27 9:43 ` [PATCH v3] " Baichuan Qi
2024-11-27 10:30 ` Kang Yang
2024-11-27 12:00 ` Baichuan Qi
2024-11-27 10:36 ` [PATCH v4?] " Markus Elfring
2024-11-27 11:43 ` [PATCH v4] " Baichuan Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241127143506.28267-1-zghbqbc@gmail.com \
--to=zghbqbc@gmail.com \
--cc=ath11k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markus.elfring@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®