From: Markus Elfring <Markus.Elfring@web.de>
To: Baichuan Qi <zghbqbc@gmail.com>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Kalle Valo <kvalo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Jeff Johnson <jjohnson@kernel.org>
Subject: Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe()
Date: Wed, 27 Nov 2024 13:40:09 +0100 [thread overview]
Message-ID: <30b208e0-55a2-400f-9638-1765e7ed3bfa@web.de> (raw)
In-Reply-To: <20241127032821.57468-1-hbczqbc@163.com>
>> Is there a need to reconsider also such a return value?
>
> According to the current code (commit d5c65159f289) of
> this function, this function should be terminated directly
> after checking the null pointer, the return value may be
> meaningless.
The return value is checked at two source code places at least.
* ath11k_ce_recv_process_cb():
https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L450
* ath11k_ce_rx_post_buf():
https://elixir.bootlin.com/linux/v6.12.1/source/drivers/net/wireless/ath/ath11k/ce.c#L893
May the detection of a null pointer for the data structure members
“dest_ring” or “status_ring” really be interpreted as a successful execution
of the function “ath11k_ce_rx_post_pipe”?
Regards,
Markus
next prev parent reply other threads:[~2024-11-27 12:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 5:08 [PATCH] " Baichuan Qi
2024-11-25 10:34 ` Markus Elfring
2024-11-26 2:33 ` Baichuan Qi
2024-11-26 13:44 ` Markus Elfring
2024-11-27 3:28 ` zgBCQ
2024-11-27 12:40 ` Markus Elfring [this message]
2024-11-27 14:35 ` Re: wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() ERROR code Baichuan Qi
2024-11-27 14:38 ` [PATCH v5] wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() Baichuan Qi
2024-11-27 15:23 ` Vasanthakumar Thiagarajan
2024-11-28 6:09 ` Re: [PATCH v5] NAK Baichuan Qi
2024-11-27 3:32 ` [PATCH v2 1/1] wifi: ath11k: Fix NULL pointer check in ath11k_ce_rx_post_pipe() Baichuan Qi
2024-11-27 9:05 ` [PATCH v4?] " Markus Elfring
2024-11-27 9:43 ` [PATCH v3] " Baichuan Qi
2024-11-27 10:30 ` Kang Yang
2024-11-27 12:00 ` Baichuan Qi
2024-11-27 10:36 ` [PATCH v4?] " Markus Elfring
2024-11-27 11:43 ` [PATCH v4] " Baichuan Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30b208e0-55a2-400f-9638-1765e7ed3bfa@web.de \
--to=markus.elfring@web.de \
--cc=ath11k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zghbqbc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®