mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shinas Rasheed <srasheed@marvell.com>
To: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
	<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
	<konguyen@redhat.com>, <horms@kernel.org>,
	<einstein.xue@synaxg.com>,
	"Shinas Rasheed" <srasheed@marvell.com>,
	Veerasenareddy Burru <vburru@marvell.com>,
	Satananda Burla <sburla@marvell.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net v2 4/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64
Date: Sun, 15 Dec 2024 23:58:42 -0800	[thread overview]
Message-ID: <20241216075842.2394606-5-srasheed@marvell.com> (raw)
In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com>

The per queue stats are available already and are retrieved
from register reads during ndo_get_stats64. The firmware stats
fetch call that happens in ndo_get_stats64() is currently not
required

Fixes: c3fad23cdc06 ("octeon_ep_vf: add support for ndo ops")
Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
---
V2:
  - No changes

V1: https://lore.kernel.org/all/20241203072130.2316913-5-srasheed@marvell.com/

 drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
index e6253f85b623..75dd3bd2b9ba 100644
--- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
+++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c
@@ -800,14 +800,6 @@ static void octep_vf_get_stats64(struct net_device *netdev,
 	stats->tx_bytes = tx_bytes;
 	stats->rx_packets = rx_packets;
 	stats->rx_bytes = rx_bytes;
-	if (!octep_vf_get_if_stats(oct)) {
-		stats->multicast = oct->iface_rx_stats.mcast_pkts;
-		stats->rx_errors = oct->iface_rx_stats.err_pkts;
-		stats->rx_dropped = oct->iface_rx_stats.dropped_pkts_fifo_full +
-				    oct->iface_rx_stats.err_pkts;
-		stats->rx_missed_errors = oct->iface_rx_stats.dropped_pkts_fifo_full;
-		stats->tx_dropped = oct->iface_tx_stats.dropped;
-	}
 }
 
 /**
-- 
2.25.1


      parent reply	other threads:[~2024-12-16  7:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16  7:58 [PATCH net v2 0/4] Fix race conditions " Shinas Rasheed
2024-12-16  7:58 ` [PATCH net v2 1/4] octeon_ep: fix " Shinas Rasheed
2024-12-16 14:30   ` Larysa Zaremba
2024-12-16 14:46     ` Larysa Zaremba
2024-12-16 18:28       ` [EXTERNAL] " Shinas Rasheed
2024-12-17 17:06         ` Larysa Zaremba
2024-12-17 17:49           ` Shinas Rasheed
2024-12-18 13:25             ` Larysa Zaremba
2024-12-18 13:58               ` Shinas Rasheed
2024-12-18 14:21               ` Eric Dumazet
2024-12-18 14:49                 ` Larysa Zaremba
2024-12-18 15:03                   ` Eric Dumazet
2024-12-18 15:25                     ` Shinas Rasheed
2024-12-18 15:39                       ` Eric Dumazet
2024-12-19 16:28                         ` Shinas Rasheed
2024-12-19 16:35                           ` Eric Dumazet
2024-12-16 18:24     ` Shinas Rasheed
2024-12-16  7:58 ` [PATCH net v2 2/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2024-12-16 14:40   ` Larysa Zaremba
2024-12-16 18:31     ` [EXTERNAL] " Shinas Rasheed
2024-12-17 16:37       ` Larysa Zaremba
2024-12-16  7:58 ` [PATCH net v2 3/4] octeon_ep_vf: fix race conditions " Shinas Rasheed
2024-12-16  7:58 ` Shinas Rasheed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241216075842.2394606-5-srasheed@marvell.com \
    --to=srasheed@marvell.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=einstein.xue@synaxg.com \
    --cc=hgani@marvell.com \
    --cc=horms@kernel.org \
    --cc=kheib@redhat.com \
    --cc=konguyen@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sburla@marvell.com \
    --cc=sedara@marvell.com \
    --cc=thaller@redhat.com \
    --cc=vburru@marvell.com \
    --cc=vimleshk@marvell.com \
    --cc=wizhao@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®